From: Markus Armbruster <armbru@redhat.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, Jiri Pirko <jiri@resnulli.us>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Hannes Reinecke <hare@suse.de>,
Dmitry Fleytman <dmitry@daynix.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 00/10] Convert msix_init() to error
Date: Wed, 02 Nov 2016 13:44:43 +0100 [thread overview]
Message-ID: <87wpgmnj9g.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1476859665-30133-1-git-send-email-caoj.fnst@cn.fujitsu.com> (Cao jin's message of "Wed, 19 Oct 2016 14:47:35 +0800")
Cao jin <caoj.fnst@cn.fujitsu.com> writes:
> v4 changelog
> 1. add the missed comment of "errp" in the msix_init's function comment
> 2. fix typo: msic --> msix
> 3. fix a build failure due to "copy&paste" error, in patch
> "megasas: change behaviour of msix switch"
> 4. separate the issus-fix part of vmxnet3's patch
> 5. a new patch added in the end
> 6. rebase on Eric Auger's "Convert VFIO-PCI to realize" series
>
> CC: Jiri Pirko <jiri@resnulli.us>
> CC: Gerd Hoffmann <kraxel@redhat.com>
> CC: Dmitry Fleytman <dmitry@daynix.com>
> CC: Jason Wang <jasowang@redhat.com>
> CC: Michael S. Tsirkin <mst@redhat.com>
> CC: Hannes Reinecke <hare@suse.de>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Alex Williamson <alex.williamson@redhat.com>
> CC: Markus Armbruster <armbru@redhat.com>
> CC: Marcel Apfelbaum <marcel@redhat.com>
I had two small comments that could perhaps be address on commit.
Preferrably with them addressed, series
Reviewed-by: Markus Armbruster <armbru@redhat.com>
prev parent reply other threads:[~2016-11-02 12:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 6:47 [Qemu-devel] [PATCH v4 00/10] Convert msix_init() to error Cao jin
2016-10-19 6:47 ` [Qemu-devel] [PATCH v4 01/10] msix: Follow CODING_STYLE Cao jin
2016-10-19 6:47 ` [Qemu-devel] [PATCH v4 02/10] hcd-xhci: check & correct param before using it Cao jin
2016-11-02 12:21 ` Markus Armbruster
2016-10-19 6:47 ` [Qemu-devel] [PATCH v4 03/10] pci: Convert msix_init() to Error and fix callers to check it Cao jin
2016-10-19 6:47 ` [Qemu-devel] [PATCH v4 04/10] megasas: change behaviour of msix switch Cao jin
2016-10-19 6:47 ` [Qemu-devel] [PATCH v4 05/10] hcd-xhci: " Cao jin
2016-10-19 6:47 ` [Qemu-devel] [PATCH v4 06/10] megasas: remove unnecessary megasas_use_msix() Cao jin
2016-10-19 6:47 ` [Qemu-devel] [PATCH v4 07/10] megasas: undo the overwrites of msi user configuration Cao jin
2016-10-19 6:47 ` [Qemu-devel] [PATCH v4 08/10] vmxnet3: fix reference leak issue Cao jin
2016-10-19 6:51 ` Dmitry Fleytman
2016-10-19 6:47 ` [Qemu-devel] [PATCH v4 09/10] vmxnet3: remove unnecessary internal msix flag Cao jin
2016-10-19 6:50 ` Dmitry Fleytman
2016-10-19 6:47 ` [Qemu-devel] [PATCH v4 10/10] msi_init: convert assert to return -errno Cao jin
2016-11-02 12:37 ` Markus Armbruster
2016-10-30 19:29 ` [Qemu-devel] [PATCH v4 00/10] Convert msix_init() to error Michael S. Tsirkin
2016-10-30 22:45 ` Michael S. Tsirkin
2016-11-02 12:44 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpgmnj9g.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=dmitry@daynix.com \
--cc=hare@suse.de \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=kraxel@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.