* EDID reading failed when using DVI-to-VGA connector in valleyview(device id: 0x0f31)
@ 2016-09-29 6:58 杨波
2016-09-29 7:11 ` Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: 杨波 @ 2016-09-29 6:58 UTC (permalink / raw)
To: daniel.vetter; +Cc: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 564 bytes --]
Hi, everyone:
Reading EDID failed when using DVI-to-VGA connector in valleyview(device id: 0x0f31).
It is not G4X device，but still need to probe digital port.
------------------
武汉深之度科技有限公司
Wuhan Deepin Technology Co., Ltd.
杨波
手机：18523158905
武汉：武汉市光谷大道77号光谷金融港B18栋6楼
北京：北京市海淀区知春路锦秋国际大厦B座501室
上海：上海市长宁区愚园路1258号15A01室
官网：www.deepin.org 官博：深度操作系统
[-- Attachment #1.2: Type: text/html, Size: 1668 bytes --]
[-- Attachment #2: EDID-reading-failure-in-0x0f31.patch --]
[-- Type: application/octet-stream, Size: 1004 bytes --]
From e2dbb517239b5f03da7578e9e350013f8e9c2b3a Mon Sep 17 00:00:00 2001
From: Yang Bo <yangbo@deepin.com>
Date: Thu, 29 Sep 2016 14:48:32 +0800
Subject: [PATCH] EDID reading failure in 0x0f31
EDID reading failure is observed in valleyview(device id: 0x0f31)
when using DVI-to-VGA connector.
Signed-off-by: Yang Bo <yangbo@deepin.com>
---
drivers/gpu/drm/i915/intel_crt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
index 827b6ef..83662fa 100644
--- a/drivers/gpu/drm/i915/intel_crt.c
+++ b/drivers/gpu/drm/i915/intel_crt.c
@@ -715,7 +715,7 @@ static int intel_crt_get_modes(struct drm_connector *connector)
i2c = intel_gmbus_get_adapter(dev_priv, dev_priv->vbt.crt_ddc_pin);
ret = intel_crt_ddc_get_modes(connector, i2c);
- if (ret || !IS_G4X(dev))
+ if (ret || !(IS_G4X(dev) || (dev->pdev->device == 0x0f31)))
goto out;
/* Try to probe digital port for output in DVI-I -> VGA mode. */
--
2.9.3
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: EDID reading failed when using DVI-to-VGA connector in valleyview(device id: 0x0f31)
2016-09-29 6:58 EDID reading failed when using DVI-to-VGA connector in valleyview(device id: 0x0f31) 杨波
@ 2016-09-29 7:11 ` Jani Nikula
2016-09-29 9:28 ` 杨波
0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2016-09-29 7:11 UTC (permalink / raw)
To: 杨波, daniel.vetter; +Cc: dri-devel
On Thu, 29 Sep 2016, 杨波 <yangbo@deepin.com> wrote:
> Hi, everyone:
> Reading EDID failed when using DVI-to-VGA connector in valleyview(device id: 0x0f31).
> It is not G4X device，but still need to probe digital port.
I don't think the patch is acceptable, at least not without a proper
explanation and debugging of the problem. Please file a bug at [1], add
drm.debug=14 module parameter and attach dmesg on the bug.
BR,
Jani.
[1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel
>
>
>
>
>
> ------------------
>
> 武汉深之度科技有限公司
> Wuhan Deepin Technology Co., Ltd.
>
> 杨波
>
> 手机：18523158905
>
>
> 武汉：武汉市光谷大道77号光谷金融港B18栋6楼
> 北京：北京市海淀区知春路锦秋国际大厦B座501室
> 上海：上海市长宁区愚园路1258号15A01室
>
>
> 官网：www.deepin.org 官博：深度操作系统
> From e2dbb517239b5f03da7578e9e350013f8e9c2b3a Mon Sep 17 00:00:00 2001
> From: Yang Bo <yangbo@deepin.com>
> Date: Thu, 29 Sep 2016 14:48:32 +0800
> Subject: [PATCH] EDID reading failure in 0x0f31
>
> EDID reading failure is observed in valleyview(device id: 0x0f31)
> when using DVI-to-VGA connector.
>
> Signed-off-by: Yang Bo <yangbo@deepin.com>
> ---
> drivers/gpu/drm/i915/intel_crt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
> index 827b6ef..83662fa 100644
> --- a/drivers/gpu/drm/i915/intel_crt.c
> +++ b/drivers/gpu/drm/i915/intel_crt.c
> @@ -715,7 +715,7 @@ static int intel_crt_get_modes(struct drm_connector *connector)
>
> i2c = intel_gmbus_get_adapter(dev_priv, dev_priv->vbt.crt_ddc_pin);
> ret = intel_crt_ddc_get_modes(connector, i2c);
> - if (ret || !IS_G4X(dev))
> + if (ret || !(IS_G4X(dev) || (dev->pdev->device == 0x0f31)))
> goto out;
>
> /* Try to probe digital port for output in DVI-I -> VGA mode. */
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: EDID reading failed when using DVI-to-VGA connector in valleyview(device id: 0x0f31)
2016-09-29 7:11 ` Jani Nikula
@ 2016-09-29 9:28 ` 杨波
0 siblings, 0 replies; 3+ messages in thread
From: 杨波 @ 2016-09-29 9:28 UTC (permalink / raw)
To: Jani Nikula, daniel.vetter; +Cc: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 2978 bytes --]
reported bug https://bugs.freedesktop.org/show_bug.cgi?id=97971
If need more info, pls let me know
------------------
武汉深之度科技有限公司
Wuhan Deepin Technology Co., Ltd.
杨波
手机：18523158905
武汉：武汉市光谷大道77号光谷金融港B18栋6楼
北京：北京市海淀区知春路锦秋国际大厦B座501室
上海：上海市长宁区愚园路1258号15A01室
官网：www.deepin.org 官博：深度操作系统
------------------ Original ------------------
From: "Jani Nikula"<jani.nikula@linux.intel.com>;
Date: Thu, Sep 29, 2016 03:11 PM
To: "杨波"<yangbo@deepin.com>; "daniel.vetter"<daniel.vetter@intel.com>;
Cc: "dri-devel"<dri-devel@lists.freedesktop.org>;
Subject: Re: EDID reading failed when using DVI-to-VGA connector in valleyview(device id: 0x0f31)
On Thu, 29 Sep 2016, 杨波 <yangbo@deepin.com> wrote:
> Hi, everyone:
> Reading EDID failed when using DVI-to-VGA connector in valleyview(device id: 0x0f31).
> It is not G4X device，but still need to probe digital port.
I don't think the patch is acceptable, at least not without a proper
explanation and debugging of the problem. Please file a bug at [1], add
drm.debug=14 module parameter and attach dmesg on the bug.
BR,
Jani.
[1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel
>
>
>
>
>
> ------------------
>
> 武汉深之度科技有限公司
> Wuhan Deepin Technology Co., Ltd.
>
> 杨波
>
> 手机：18523158905
>
>
> 武汉：武汉市光谷大道77号光谷金融港B18栋6楼
> 北京：北京市海淀区知春路锦秋国际大厦B座501室
> 上海：上海市长宁区愚园路1258号15A01室
>
>
> 官网：www.deepin.org 官博：深度操作系统
> From e2dbb517239b5f03da7578e9e350013f8e9c2b3a Mon Sep 17 00:00:00 2001
> From: Yang Bo <yangbo@deepin.com>
> Date: Thu, 29 Sep 2016 14:48:32 +0800
> Subject: [PATCH] EDID reading failure in 0x0f31
>
> EDID reading failure is observed in valleyview(device id: 0x0f31)
> when using DVI-to-VGA connector.
>
> Signed-off-by: Yang Bo <yangbo@deepin.com>
> ---
> drivers/gpu/drm/i915/intel_crt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
> index 827b6ef..83662fa 100644
> --- a/drivers/gpu/drm/i915/intel_crt.c
> +++ b/drivers/gpu/drm/i915/intel_crt.c
> @@ -715,7 +715,7 @@ static int intel_crt_get_modes(struct drm_connector *connector)
>
> i2c = intel_gmbus_get_adapter(dev_priv, dev_priv->vbt.crt_ddc_pin);
> ret = intel_crt_ddc_get_modes(connector, i2c);
> - if (ret || !IS_G4X(dev))
> + if (ret || !(IS_G4X(dev) || (dev->pdev->device == 0x0f31)))
> goto out;
>
> /* Try to probe digital port for output in DVI-I -> VGA mode. */
--
Jani Nikula, Intel Open Source Technology Center
[-- Attachment #1.2: Type: text/html, Size: 4834 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-29 9:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-29 6:58 EDID reading failed when using DVI-to-VGA connector in valleyview(device id: 0x0f31) 杨波
2016-09-29 7:11 ` Jani Nikula
2016-09-29 9:28 ` 杨波
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.