From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [Make-wifi-fast] [RFC/RFT 5/5] ath9k: Count RX airtime in airtime deficit
Date: Mon, 13 Jun 2016 07:29:43 -0000 [thread overview]
Message-ID: <87wplxawjx.fsf@toke.dk> (raw)
In-Reply-To: <8737oll6fu.fsf@toke.dk> ("Toke Høiland-Jørgensen"'s message of "Fri, 10 Jun 2016 11:49:25 +0200")
Toke H?iland-J?rgensen <toke@toke.dk> writes:
>> No idea. If that's possible, then track last MPDU within PPDU, so you
>> can at least fallback to _something_ when you detect a new first
>> (A-)MPDU?
>>
>> Or maybe it's impossible (i.e. not worth worrying) and HW always
>> reports last MPDU as far as status bits are concerned (regardless of
>> it being _actual_ last MPDU, i.e. it just says "ok, I'm done with this
>> PPDU").
>
> I'll try a couple of different permutations of this and see what works.
> Thanks for the ideas!
OK, so having tried all the different approaches, this seems to be the
best one. Basically, this:
if (rs->rs_isaggr && rs->rs_firstaggr) {
an->airtime_rx_start = rs->rs_tstamp;
} else if (rs->rs_isaggr && !rs->rs_moreaggr && an->airtime_rx_start) {
airtime = rs->rs_tstamp - an->airtime_rx_start;
} else if (!rs->rs_isaggr) {
an->airtime_rx_start = 0;
/* keeping the previous length-based calculation here */
}
This seems to give me RX airtime figures that correspond fairly well to
the TX airtime for running the same test in the opposite direction (I'm
running a ten-second UDP flood test and looking at the total airtime
accounted after the end of the run).
-Toke
WARNING: multiple messages have this Message-ID (diff)
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Adrian Chadd <adrian@freebsd.org>,
make-wifi-fast@lists.bufferbloat.net,
ath9k-devel <ath9k-devel@lists.ath9k.org>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: [Make-wifi-fast] [RFC/RFT 5/5] ath9k: Count RX airtime in airtime deficit
Date: Fri, 10 Jun 2016 17:33:06 +0200 [thread overview]
Message-ID: <87wplxawjx.fsf@toke.dk> (raw)
In-Reply-To: <8737oll6fu.fsf@toke.dk> ("Toke Høiland-Jørgensen"'s message of "Fri, 10 Jun 2016 11:49:25 +0200")
Toke Høiland-Jørgensen <toke@toke.dk> writes:
>> No idea. If that's possible, then track last MPDU within PPDU, so you
>> can at least fallback to _something_ when you detect a new first
>> (A-)MPDU?
>>
>> Or maybe it's impossible (i.e. not worth worrying) and HW always
>> reports last MPDU as far as status bits are concerned (regardless of
>> it being _actual_ last MPDU, i.e. it just says "ok, I'm done with this
>> PPDU").
>
> I'll try a couple of different permutations of this and see what works.
> Thanks for the ideas!
OK, so having tried all the different approaches, this seems to be the
best one. Basically, this:
if (rs->rs_isaggr && rs->rs_firstaggr) {
an->airtime_rx_start = rs->rs_tstamp;
} else if (rs->rs_isaggr && !rs->rs_moreaggr && an->airtime_rx_start) {
airtime = rs->rs_tstamp - an->airtime_rx_start;
} else if (!rs->rs_isaggr) {
an->airtime_rx_start = 0;
/* keeping the previous length-based calculation here */
}
This seems to give me RX airtime figures that correspond fairly well to
the TX airtime for running the same test in the opposite direction (I'm
running a ten-second UDP flood test and looking at the total airtime
accounted after the end of the run).
-Toke
next prev parent reply other threads:[~2016-06-13 7:29 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 16:51 [RFC/RFT 0/5] Adding an airtime fairness scheduler to ath9k Toke Høiland-Jørgensen
2016-06-03 16:52 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-03 16:51 ` [RFC/RFT 1/5] mac80211: skip netdev queue control with software queuing Toke Høiland-Jørgensen
2016-06-03 16:52 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-06 2:26 ` Julian Calaby
2016-06-06 2:26 ` Julian Calaby
2016-06-06 17:00 ` Toke Høiland-Jørgensen
2016-06-06 17:00 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-03 16:51 ` [RFC/RFT 2/5] ath9k: use mac80211 intermediate software queues Toke Høiland-Jørgensen
2016-06-03 16:52 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-03 17:10 ` Tim Shepard
2016-06-03 17:38 ` [ath9k-devel] " Tim Shepard
2016-06-04 14:32 ` Toke Høiland-Jørgensen
2016-06-04 14:32 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-06 2:59 ` Tim Shepard
2016-06-06 2:59 ` [ath9k-devel] " Tim Shepard
2016-06-06 4:26 ` Dave Taht
2016-06-06 4:26 ` Dave Taht
2016-06-06 5:50 ` Tim Shepard
2016-06-06 5:50 ` [ath9k-devel] " Tim Shepard
2016-06-06 16:55 ` Dave Taht
2016-06-06 16:55 ` Dave Taht
2016-06-06 17:26 ` [ath9k-devel] " Dave Taht
2016-06-06 17:26 ` Dave Taht
2016-06-06 17:31 ` Tim Shepard
2016-06-06 17:31 ` [ath9k-devel] " Tim Shepard
2016-06-06 17:28 ` Toke Høiland-Jørgensen
2016-06-06 17:29 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-03 16:51 ` [RFC/RFT 3/5] ath9k: Add airstame stats to per-station debugfs Toke Høiland-Jørgensen
2016-06-03 16:52 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-03 16:51 ` [RFC/RFT 4/5] ath9k: Add a per-station airtime deficit scheduler Toke Høiland-Jørgensen
2016-06-03 16:52 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-03 16:51 ` [RFC/RFT 5/5] ath9k: Count RX airtime in airtime deficit Toke Høiland-Jørgensen
2016-06-03 16:52 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-04 17:06 ` Adrian Chadd
2016-06-04 17:06 ` Adrian Chadd
2016-06-05 10:55 ` Toke Høiland-Jørgensen
2016-06-05 10:55 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-05 17:23 ` Adrian Chadd
2016-06-05 17:23 ` Adrian Chadd
2016-06-07 0:01 ` [ath9k-devel] " Adrian Chadd
2016-06-07 0:01 ` Adrian Chadd
2016-06-07 1:31 ` [Make-wifi-fast] " Jonathan Morton
2016-06-07 1:31 ` [ath9k-devel] " Jonathan Morton
2016-06-07 8:58 ` Toke Høiland-Jørgensen
2016-06-07 8:58 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-07 11:12 ` Toke Høiland-Jørgensen
2016-06-07 11:13 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-08 1:41 ` Adrian Chadd
2016-06-08 1:41 ` Adrian Chadd
2016-06-08 13:06 ` Toke Høiland-Jørgensen
2016-06-13 7:04 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-10 8:40 ` [ath9k-devel] [Make-wifi-fast] " Michal Kazior
2016-06-10 8:40 ` Michal Kazior
2016-06-10 8:53 ` Toke Høiland-Jørgensen
2016-06-13 7:04 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-10 9:02 ` Michal Kazior
2016-06-10 9:02 ` Michal Kazior
2016-06-10 9:08 ` Toke Høiland-Jørgensen
2016-06-13 7:19 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-10 9:20 ` Michal Kazior
2016-06-10 9:20 ` Michal Kazior
2016-06-10 9:49 ` Toke Høiland-Jørgensen
2016-06-13 6:49 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-10 15:33 ` Toke Høiland-Jørgensen [this message]
2016-06-13 7:29 ` Toke Høiland-Jørgensen
2016-06-10 15:52 ` Adrian Chadd
2016-06-10 15:52 ` Adrian Chadd
2016-06-04 15:31 ` [ath9k-devel] [Make-wifi-fast] [RFC/RFT 0/5] Adding an airtime fairness scheduler to ath9k Luca Muscariello
2016-06-05 10:51 ` Toke Høiland-Jørgensen
2016-06-05 10:52 ` [ath9k-devel] " Toke Høiland-Jørgensen
2016-06-05 11:40 ` Luca Muscariello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wplxawjx.fsf@toke.dk \
--to=toke@toke.dk \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.