From: Markus Armbruster <armbru@redhat.com>
To: Corey Minyard <cminyard@mvista.com>
Cc: Cao jin <caoj.fnst@cn.fujitsu.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
kraxel@redhat.com, mst@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] fw_cfg: follow CODING_STYLE
Date: Thu, 19 May 2016 14:40:17 +0200 [thread overview]
Message-ID: <87wpmqi5la.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <573C7DFF.1090504@mvista.com> (Corey Minyard's message of "Wed, 18 May 2016 09:36:47 -0500")
Corey Minyard <cminyard@mvista.com> writes:
> On 05/18/2016 05:59 AM, Cao jin wrote:
>> Replace tab with 4 spaces; brace the indented statement.
>
> Thanks, I think I have my editor set up to avoid the tab/space issue from
> now on. I'm going to have to handle kernel/qemu switching in my brain
> for the brace issue.
You can outsource some of it to scripts/checkpatch.pl :)
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Corey Minyard <cminyard@mvista.com>
Cc: Cao jin <caoj.fnst@cn.fujitsu.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
kraxel@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] fw_cfg: follow CODING_STYLE
Date: Thu, 19 May 2016 14:40:17 +0200 [thread overview]
Message-ID: <87wpmqi5la.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <573C7DFF.1090504@mvista.com> (Corey Minyard's message of "Wed, 18 May 2016 09:36:47 -0500")
Corey Minyard <cminyard@mvista.com> writes:
> On 05/18/2016 05:59 AM, Cao jin wrote:
>> Replace tab with 4 spaces; brace the indented statement.
>
> Thanks, I think I have my editor set up to avoid the tab/space issue from
> now on. I'm going to have to handle kernel/qemu switching in my brain
> for the brace issue.
You can outsource some of it to scripts/checkpatch.pl :)
next prev parent reply other threads:[~2016-05-19 12:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 10:59 [Qemu-trivial] [PATCH] fw_cfg: follow CODING_STYLE Cao jin
2016-05-18 10:59 ` [Qemu-devel] " Cao jin
2016-05-18 14:36 ` [Qemu-trivial] " Corey Minyard
2016-05-18 14:36 ` [Qemu-devel] " Corey Minyard
2016-05-19 12:40 ` Markus Armbruster [this message]
2016-05-19 12:40 ` Markus Armbruster
2016-05-29 8:35 ` [Qemu-trivial] " Michael Tokarev
2016-05-29 8:35 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpmqi5la.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=cminyard@mvista.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.