All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 1/2] ath10k: don't remove peer that doesn't exist
Date: Thu, 13 Aug 2015 14:31:20 +0300	[thread overview]
Message-ID: <87wpwzmnlj.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1438769724-29438-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Wed, 5 Aug 2015 12:15:23 +0200")

Michal Kazior <michal.kazior@tieto.com> writes:

> If peer creation failed during offchannel Tx the
> driver attempted to delete the peer nonetheless.
> This caused the ar->num_peers counter to be
> incorrectly decremented. This subsequently could
> cause the counter to drop below 0 and also
> eventually lead to firmware crash because host
> would think there are less peer entries created in
> firmware then there really were.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

Thanks, applied.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] ath10k: don't remove peer that doesn't exist
Date: Thu, 13 Aug 2015 14:31:20 +0300	[thread overview]
Message-ID: <87wpwzmnlj.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1438769724-29438-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Wed, 5 Aug 2015 12:15:23 +0200")

Michal Kazior <michal.kazior@tieto.com> writes:

> If peer creation failed during offchannel Tx the
> driver attempted to delete the peer nonetheless.
> This caused the ar->num_peers counter to be
> incorrectly decremented. This subsequently could
> cause the counter to drop below 0 and also
> eventually lead to firmware crash because host
> would think there are less peer entries created in
> firmware then there really were.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

Thanks, applied.

-- 
Kalle Valo

  parent reply	other threads:[~2015-08-13 11:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05 10:15 [PATCH 1/2] ath10k: don't remove peer that doesn't exist Michal Kazior
2015-08-05 10:15 ` Michal Kazior
2015-08-05 10:15 ` [PATCH 2/2] ath10k: fix peer limit enforcement Michal Kazior
2015-08-05 10:15   ` Michal Kazior
2015-08-13 11:31 ` Kalle Valo [this message]
2015-08-13 11:31   ` [PATCH 1/2] ath10k: don't remove peer that doesn't exist Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpwzmnlj.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.