From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 1/3] ath10k: fix ar->rx_channel updating logic
Date: Tue, 9 Jun 2015 13:50:21 +0300 [thread overview]
Message-ID: <87wpzdf95e.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1433326616-23279-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Wed, 3 Jun 2015 12:16:54 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> Channel contexts aren't iterable until after
> they've been added to the driver. The code assumed
> otherwise.
>
> This problem could result in:
>
> * rx_channel being NULL and forcing Rx path to go
> the slow way to get channel on QCA988X,
>
> * report incorrect channel when running
> multi-channel on QCA61X4 hw2.1,
>
> * report incorrect channel after AP channel
> switch.
>
> Fixes: 500ff9f9389d ("ath10k: implement chanctx API")
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Thanks, all three patches applied.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/3] ath10k: fix ar->rx_channel updating logic
Date: Tue, 9 Jun 2015 13:50:21 +0300 [thread overview]
Message-ID: <87wpzdf95e.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1433326616-23279-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Wed, 3 Jun 2015 12:16:54 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> Channel contexts aren't iterable until after
> they've been added to the driver. The code assumed
> otherwise.
>
> This problem could result in:
>
> * rx_channel being NULL and forcing Rx path to go
> the slow way to get channel on QCA988X,
>
> * report incorrect channel when running
> multi-channel on QCA61X4 hw2.1,
>
> * report incorrect channel after AP channel
> switch.
>
> Fixes: 500ff9f9389d ("ath10k: implement chanctx API")
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Thanks, all three patches applied.
--
Kalle Valo
next prev parent reply other threads:[~2015-06-09 10:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 10:16 [PATCH 1/3] ath10k: fix ar->rx_channel updating logic Michal Kazior
2015-06-03 10:16 ` Michal Kazior
2015-06-03 10:16 ` [PATCH 2/3] ath10k: remove ath10k_chanctx struct Michal Kazior
2015-06-03 10:16 ` Michal Kazior
2015-06-03 10:16 ` [PATCH 3/3] ath10k: fix channel switching Michal Kazior
2015-06-03 10:16 ` Michal Kazior
2015-06-09 10:50 ` Kalle Valo [this message]
2015-06-09 10:50 ` [PATCH 1/3] ath10k: fix ar->rx_channel updating logic Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpzdf95e.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.