From: Markus Armbruster <armbru@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 00/20] monitor: Wean core off QError, and other cleanups
Date: Fri, 29 May 2015 10:21:52 +0200 [thread overview]
Message-ID: <87wpzrlrof.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <20150528154257.16510723@redhat.com> (Luiz Capitulino's message of "Thu, 28 May 2015 15:42:57 -0400")
Luiz Capitulino <lcapitulino@redhat.com> writes:
> On Tue, 26 May 2015 17:20:35 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Command handlers still use QError. Left for another day.
>
> Great work! I've found one bug that has to be addressed before merging.
> Also, for the error conversions you're doing you're going from
> qerror_report() to error_set() but I'd recommend going directly to
> error_setg() as that's our final goal. It's totally fine with me
> if you're saving this work for a later series, but I think it will
> you save work if you do it in this series. Your call.
Saving for later, not least because this series has been fully reviewed
now.
> Can you take this through your tree?
Sure!
> Feel free to add this once
> you fix the bug:
>
> Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Thanks!
prev parent reply other threads:[~2015-05-29 8:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 15:20 [Qemu-devel] [PATCH v2 00/20] monitor: Wean core off QError, and other cleanups Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 01/20] monitor: Drop broken, unused asynchronous command interface Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 02/20] monitor: Clean up after previous commit Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 03/20] monitor: Improve and document client_migrate_info protocol error Markus Armbruster
2015-05-27 14:30 ` Gerd Hoffmann
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 04/20] monitor: Convert client_migrate_info to QAPI Markus Armbruster
2015-05-28 18:39 ` Luiz Capitulino
2015-05-29 8:12 ` Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 05/20] monitor: Use traditional command interface for HMP drive_del Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 06/20] monitor: Use traditional command interface for HMP device_add Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 07/20] monitor: Use trad. command interface for HMP pcie_aer_inject_error Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 08/20] monitor: Drop unused "new" HMP command interface Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 09/20] monitor: Propagate errors through qmp_check_client_args() Markus Armbruster
2015-05-28 19:03 ` Luiz Capitulino
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 10/20] monitor: Propagate errors through qmp_check_input_obj() Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 11/20] monitor: Wean monitor_protocol_emitter() off mon->error Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 12/20] monitor: Inline monitor_has_error() into its only caller Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 13/20] monitor: Limit QError use to command handlers Markus Armbruster
2015-05-28 19:35 ` Luiz Capitulino
2015-05-29 8:17 ` Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 14/20] monitor: Rename handle_user_command() to handle_hmp_command() Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 15/20] monitor: Rename monitor_control_read(), monitor_control_event() Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 16/20] monitor: Unbox Monitor member mc and rename to qmp Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 17/20] monitor: Drop do_qmp_capabilities()'s superfluous QMP check Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 18/20] monitor: Turn int command_mode into bool in_command_mode Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 19/20] monitor: Rename monitor_ctrl_mode() to monitor_is_qmp() Markus Armbruster
2015-05-26 15:20 ` [Qemu-devel] [PATCH v2 20/20] monitor: Change return type of monitor_cur_is_qmp() to bool Markus Armbruster
2015-05-28 19:42 ` [Qemu-devel] [PATCH v2 00/20] monitor: Wean core off QError, and other cleanups Luiz Capitulino
2015-05-29 8:21 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpzrlrof.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.