From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: pxa: fix pxa interrupts handling in DT
Date: Mon, 23 Feb 2015 22:41:57 +0100 [thread overview]
Message-ID: <87wq384862.fsf@free.fr> (raw)
In-Reply-To: <1423950116-23856-1-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Sat, 14 Feb 2015 22:41:56 +0100")
Robert Jarzmik <robert.jarzmik@free.fr> writes:
> The commit "ARM: pxa: arbitrarily set first interrupt number" changed
> the first pxa interrupt to 16.
>
> As a consequence, device-tree builds got broken, because :
> - pxa_mask_irq() and pxa_unmask_irq() are using IRQ_BIT()
> - IRQ_BIT(x) calculates the interrupts as : x - PXA_IRQ(0)
>
> Before the commit, the first interrupt shift, PXA_IRQ(0) was 0,
> therefore IRQ_BIT(x) was x. After the change, it is necessary that the
> same shift of 16 is applied between the virtual interrupt number and the
> hardware irq number.
>
> This situation comes from the common irq_chip shared between legacy
> platform builds and device-tree builds.
>
> Fix the broken interrupts in DT case by adding this shift in the DT case
> too.
>
> As a consequence of the IRQ_BIT() is removed alltogether from interrupts
> handling, even in the platform data types of platforms :
> - a legacy irq domain is used
> - the irq_chip handles hardware interrupts
> - the virtual to hardware interrupt conversion is fully handled by irq
> domain mechanics
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Queued in pxa/fixes.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Daniel Mack <daniel@zonque.org>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ARM: pxa: fix pxa interrupts handling in DT
Date: Mon, 23 Feb 2015 22:41:57 +0100 [thread overview]
Message-ID: <87wq384862.fsf@free.fr> (raw)
In-Reply-To: <1423950116-23856-1-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Sat, 14 Feb 2015 22:41:56 +0100")
Robert Jarzmik <robert.jarzmik@free.fr> writes:
> The commit "ARM: pxa: arbitrarily set first interrupt number" changed
> the first pxa interrupt to 16.
>
> As a consequence, device-tree builds got broken, because :
> - pxa_mask_irq() and pxa_unmask_irq() are using IRQ_BIT()
> - IRQ_BIT(x) calculates the interrupts as : x - PXA_IRQ(0)
>
> Before the commit, the first interrupt shift, PXA_IRQ(0) was 0,
> therefore IRQ_BIT(x) was x. After the change, it is necessary that the
> same shift of 16 is applied between the virtual interrupt number and the
> hardware irq number.
>
> This situation comes from the common irq_chip shared between legacy
> platform builds and device-tree builds.
>
> Fix the broken interrupts in DT case by adding this shift in the DT case
> too.
>
> As a consequence of the IRQ_BIT() is removed alltogether from interrupts
> handling, even in the platform data types of platforms :
> - a legacy irq domain is used
> - the irq_chip handles hardware interrupts
> - the virtual to hardware interrupt conversion is fully handled by irq
> domain mechanics
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Queued in pxa/fixes.
--
Robert
next prev parent reply other threads:[~2015-02-23 21:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-14 21:41 [PATCH v3] ARM: pxa: fix pxa interrupts handling in DT Robert Jarzmik
2015-02-14 21:41 ` Robert Jarzmik
2015-02-23 21:41 ` Robert Jarzmik [this message]
2015-02-23 21:41 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wq384862.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.