All of lore.kernel.org
 help / color / mirror / Atom feed
From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: pxa: fix pxa interrupts handling in DT
Date: Mon, 02 Feb 2015 21:22:01 +0100	[thread overview]
Message-ID: <87wq409i8m.fsf@free.fr> (raw)
In-Reply-To: <1422814816-23887-1-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Sun, 1 Feb 2015 19:20:16 +0100")

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> @@ -66,18 +67,20 @@ static inline void __iomem *irq_base(int i)
>  void pxa_mask_irq(struct irq_data *d)
>  {
>  	void __iomem *base = irq_data_get_irq_chip_data(d);
> +	irq_hw_number_t irq = irqd_to_hwirq(d);
>  	uint32_t icmr = __raw_readl(base + ICMR);
>  
> -	icmr &= ~(1 << IRQ_BIT(d->irq));
> +	icmr &= ~BIT(irq);
This should be : icmr &= ~BIT(irq & 0x1f);

>  	__raw_writel(icmr, base + ICMR);
>  }
>  
>  void pxa_unmask_irq(struct irq_data *d)
>  {
>  	void __iomem *base = irq_data_get_irq_chip_data(d);
> +	irq_hw_number_t irq = irqd_to_hwirq(d);
>  	uint32_t icmr = __raw_readl(base + ICMR);
>  
> -	icmr |= 1 << IRQ_BIT(d->irq);
> +	icmr |= BIT(irq);
Ditto.

> +void __init pxa_init_irq(int irq_nr, int (*fn)(struct irq_data *, unsigned int))
> +{
> +	BUG_ON(irq_nr > MAX_INTERNAL_IRQS);
> +
> +	pxa_irq_base = io_p2v(0x40d00000);
> +	cpu_has_ipr = !cpu_is_pxa25x();
> +	pxa_init_irq_common(NULL, irq_nr, fn);
> +}
This requires "select IRQ_DOMAIN" in arch/arm/Kconfig in ARCH_PXA.

-- 
Robert

WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Daniel Mack <daniel@zonque.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: pxa: fix pxa interrupts handling in DT
Date: Mon, 02 Feb 2015 21:22:01 +0100	[thread overview]
Message-ID: <87wq409i8m.fsf@free.fr> (raw)
In-Reply-To: <1422814816-23887-1-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Sun, 1 Feb 2015 19:20:16 +0100")

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> @@ -66,18 +67,20 @@ static inline void __iomem *irq_base(int i)
>  void pxa_mask_irq(struct irq_data *d)
>  {
>  	void __iomem *base = irq_data_get_irq_chip_data(d);
> +	irq_hw_number_t irq = irqd_to_hwirq(d);
>  	uint32_t icmr = __raw_readl(base + ICMR);
>  
> -	icmr &= ~(1 << IRQ_BIT(d->irq));
> +	icmr &= ~BIT(irq);
This should be : icmr &= ~BIT(irq & 0x1f);

>  	__raw_writel(icmr, base + ICMR);
>  }
>  
>  void pxa_unmask_irq(struct irq_data *d)
>  {
>  	void __iomem *base = irq_data_get_irq_chip_data(d);
> +	irq_hw_number_t irq = irqd_to_hwirq(d);
>  	uint32_t icmr = __raw_readl(base + ICMR);
>  
> -	icmr |= 1 << IRQ_BIT(d->irq);
> +	icmr |= BIT(irq);
Ditto.

> +void __init pxa_init_irq(int irq_nr, int (*fn)(struct irq_data *, unsigned int))
> +{
> +	BUG_ON(irq_nr > MAX_INTERNAL_IRQS);
> +
> +	pxa_irq_base = io_p2v(0x40d00000);
> +	cpu_has_ipr = !cpu_is_pxa25x();
> +	pxa_init_irq_common(NULL, irq_nr, fn);
> +}
This requires "select IRQ_DOMAIN" in arch/arm/Kconfig in ARCH_PXA.

-- 
Robert

  reply	other threads:[~2015-02-02 20:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-31 22:36 [PATCH] ARM: pxa: pxa27x skip default device initialization with DT Robert Jarzmik
2015-01-31 22:36 ` Robert Jarzmik
2015-02-01 18:20 ` [PATCH v2] ARM: pxa: fix pxa interrupts handling in DT Robert Jarzmik
2015-02-01 18:20   ` Robert Jarzmik
2015-02-02 20:22   ` Robert Jarzmik [this message]
2015-02-02 20:22     ` Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wq409i8m.fsf@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.