All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Amit Shah <amit.shah@redhat.com>, Amos Kong <akong@redhat.com>
Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v3 1/2] virtio-rng: fix stuck of hot-unplugging busy device
Date: Thu, 11 Sep 2014 22:20:42 +0930	[thread overview]
Message-ID: <87wq9agw2l.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20140910070354.GC29832@grmbl.mre>

Amit Shah <amit.shah@redhat.com> writes:
> On (Wed) 10 Sep 2014 [14:11:36], Amos Kong wrote:
>> When we try to hot-remove a busy virtio-rng device from QEMU monitor,
>> the device can't be hot-removed. Because virtio-rng driver hangs at
>> wait_for_completion_killable().
>> 
>> This patch exits the waiting by completing have_data completion before
>> unregistering, resets data_avail to avoid the hwrng core use wrong
>> buffer bytes.
>> 
>> Signed-off-by: Amos Kong <akong@redhat.com>
>> Cc: stable@vger.kernel.org
>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>

Thanks, applied.

Cheers,
Rusty.

  parent reply	other threads:[~2014-09-11 12:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-10  6:11 [PATCH v3 0/2] virtio-rng: fix hotunplug Amos Kong
2014-09-10  6:11 ` Amos Kong
2014-09-10  6:11 ` [PATCH v3 1/2] virtio-rng: fix stuck of hot-unplugging busy device Amos Kong
2014-09-10  6:11   ` Amos Kong
2014-09-10  7:03   ` Amit Shah
2014-09-10  7:03     ` Amit Shah
2014-09-11 12:50     ` Rusty Russell
2014-09-11 12:50     ` Rusty Russell [this message]
2014-09-10  6:11 ` [PATCH v3 2/2] virtio-rng: skip reading when we start to remove the device Amos Kong
2014-09-10  6:11 ` Amos Kong
2014-09-10  7:04   ` Amit Shah
2014-09-10  7:04     ` Amit Shah
2014-09-12  1:37     ` Rusty Russell
2014-09-12  1:37       ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wq9agw2l.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=akong@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.