All of lore.kernel.org
 help / color / mirror / Atom feed
From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] rtc: omap: add option to indicate wakeup support through DT
Date: Fri, 31 May 2013 10:48:03 -0700	[thread overview]
Message-ID: <87wqqf11nw.fsf@linaro.org> (raw)
In-Reply-To: <1369982005-8572-2-git-send-email-gururaja.hebbar@ti.com> (Hebbar Gururaja's message of "Fri, 31 May 2013 12:03:24 +0530")

Hebbar Gururaja <gururaja.hebbar@ti.com> writes:

> Even though RTC-IP is wakeup capable, Not all Boards support it.
>
> For example
> The rtc alarm wakeup is available in rtc-ip since omap1 days but alarm
> was not wired properly in previous ompa1 boards.
>
> 	commit fa5b07820fe3a0fc06ac368516e71f10a59b9539
> 	Author: Sekhar Nori <nsekhar@ti.com>
> 	Date:   Wed Oct 27 15:33:05 2010 -0700
>
> 	rtc: omap: let device wakeup capability be configured from chip
> 	init logic
>
> 	The rtc-omap driver currently hardcodes the RTC wakeup
> 	capability to be "not capable".  While this seems to be true for
> 	existing OMAP1 boards which are not wired for this, the
> 	DA850/OMAP-L138 SoC, the RTC can always be wake up source from
> 	its "deep sleep" mode.
>
> Current rtc-omap driver expects the rtc module wake-up capabilities to
> be set up by board specific code. However, in case of DT, this is not
> possible.
>
> So, add a DT property "ti,wakeup_capable" to indicate that the module is
> wake-up capable.

Why is this a TI-specific property?  

Also, I think we can do this without a new DT property.Did you see this
patch from Tony which is already queued for v3.11:

    http://marc.info/?l=linux-omap&m=136917244530612&w=2

I think this is the right way to go.  Platforms that don't want/need
wakeup support can disable it from userspace via:

    echo disabled > /sys/devices/.../power/wakeup

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@linaro.org>
To: Hebbar Gururaja <gururaja.hebbar@ti.com>
Cc: akpm@linux-foundation.org, linux@arm.linux.org.uk,
	zonque@gmail.com, linux-arm-kernel@lists.infradead.org,
	grant.likely@linaro.org, rob.herring@calxeda.com,
	rob@landley.net, a.zummo@towertech.it,
	devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
	davinci-linux-open-source@linux.davincidsp.com,
	vaibhav.bedia@ti.com, sudhakar.raj@ti.com
Subject: Re: [PATCH 1/2] rtc: omap: add option to indicate wakeup support through DT
Date: Fri, 31 May 2013 10:48:03 -0700	[thread overview]
Message-ID: <87wqqf11nw.fsf@linaro.org> (raw)
In-Reply-To: <1369982005-8572-2-git-send-email-gururaja.hebbar@ti.com> (Hebbar Gururaja's message of "Fri, 31 May 2013 12:03:24 +0530")

Hebbar Gururaja <gururaja.hebbar@ti.com> writes:

> Even though RTC-IP is wakeup capable, Not all Boards support it.
>
> For example
> The rtc alarm wakeup is available in rtc-ip since omap1 days but alarm
> was not wired properly in previous ompa1 boards.
>
> 	commit fa5b07820fe3a0fc06ac368516e71f10a59b9539
> 	Author: Sekhar Nori <nsekhar@ti.com>
> 	Date:   Wed Oct 27 15:33:05 2010 -0700
>
> 	rtc: omap: let device wakeup capability be configured from chip
> 	init logic
>
> 	The rtc-omap driver currently hardcodes the RTC wakeup
> 	capability to be "not capable".  While this seems to be true for
> 	existing OMAP1 boards which are not wired for this, the
> 	DA850/OMAP-L138 SoC, the RTC can always be wake up source from
> 	its "deep sleep" mode.
>
> Current rtc-omap driver expects the rtc module wake-up capabilities to
> be set up by board specific code. However, in case of DT, this is not
> possible.
>
> So, add a DT property "ti,wakeup_capable" to indicate that the module is
> wake-up capable.

Why is this a TI-specific property?  

Also, I think we can do this without a new DT property.Did you see this
patch from Tony which is already queued for v3.11:

    http://marc.info/?l=linux-omap&m=136917244530612&w=2

I think this is the right way to go.  Platforms that don't want/need
wakeup support can disable it from userspace via:

    echo disabled > /sys/devices/.../power/wakeup

Kevin


WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@linaro.org>
To: Hebbar Gururaja <gururaja.hebbar@ti.com>
Cc: <akpm@linux-foundation.org>, <linux@arm.linux.org.uk>,
	<zonque@gmail.com>, <linux-arm-kernel@lists.infradead.org>,
	<grant.likely@linaro.org>, <rob.herring@calxeda.com>,
	<rob@landley.net>, <a.zummo@towertech.it>,
	<devicetree-discuss@lists.ozlabs.org>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<rtc-linux@googlegroups.com>,
	<davinci-linux-open-source@linux.davincidsp.com>,
	<vaibhav.bedia@ti.com>, <sudhakar.raj@ti.com>
Subject: Re: [PATCH 1/2] rtc: omap: add option to indicate wakeup support through DT
Date: Fri, 31 May 2013 10:48:03 -0700	[thread overview]
Message-ID: <87wqqf11nw.fsf@linaro.org> (raw)
In-Reply-To: <1369982005-8572-2-git-send-email-gururaja.hebbar@ti.com> (Hebbar Gururaja's message of "Fri, 31 May 2013 12:03:24 +0530")

Hebbar Gururaja <gururaja.hebbar@ti.com> writes:

> Even though RTC-IP is wakeup capable, Not all Boards support it.
>
> For example
> The rtc alarm wakeup is available in rtc-ip since omap1 days but alarm
> was not wired properly in previous ompa1 boards.
>
> 	commit fa5b07820fe3a0fc06ac368516e71f10a59b9539
> 	Author: Sekhar Nori <nsekhar@ti.com>
> 	Date:   Wed Oct 27 15:33:05 2010 -0700
>
> 	rtc: omap: let device wakeup capability be configured from chip
> 	init logic
>
> 	The rtc-omap driver currently hardcodes the RTC wakeup
> 	capability to be "not capable".  While this seems to be true for
> 	existing OMAP1 boards which are not wired for this, the
> 	DA850/OMAP-L138 SoC, the RTC can always be wake up source from
> 	its "deep sleep" mode.
>
> Current rtc-omap driver expects the rtc module wake-up capabilities to
> be set up by board specific code. However, in case of DT, this is not
> possible.
>
> So, add a DT property "ti,wakeup_capable" to indicate that the module is
> wake-up capable.

Why is this a TI-specific property?  

Also, I think we can do this without a new DT property.Did you see this
patch from Tony which is already queued for v3.11:

    http://marc.info/?l=linux-omap&m=136917244530612&w=2

I think this is the right way to go.  Platforms that don't want/need
wakeup support can disable it from userspace via:

    echo disabled > /sys/devices/.../power/wakeup

Kevin


  parent reply	other threads:[~2013-05-31 17:48 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-31  6:33 [PATCH 0/2] rtc: rtc-omap: add support for DT wakeup & alarm events Hebbar Gururaja
2013-05-31  6:33 ` Hebbar Gururaja
2013-05-31  6:33 ` Hebbar Gururaja
2013-05-31  6:33 ` [PATCH 1/2] rtc: omap: add option to indicate wakeup support through DT Hebbar Gururaja
2013-05-31  6:33   ` Hebbar Gururaja
2013-05-31  6:33   ` Hebbar Gururaja
2013-05-31  6:44   ` Prabhakar Lad
2013-05-31  6:44     ` Prabhakar Lad
2013-05-31  6:46     ` Hebbar, Gururaja
2013-05-31  6:46       ` Hebbar, Gururaja
2013-05-31  6:46       ` Hebbar, Gururaja
2013-05-31 17:48   ` Kevin Hilman [this message]
2013-05-31 17:48     ` Kevin Hilman
2013-05-31 17:48     ` Kevin Hilman
2013-06-04  9:48     ` Hebbar, Gururaja
2013-06-04  9:48       ` Hebbar, Gururaja
2013-06-04  9:48       ` Hebbar, Gururaja
2013-05-31  6:33 ` [PATCH 2/2] rtc: omap: add rtc wakeup support to alarm events Hebbar Gururaja
2013-05-31  6:33   ` Hebbar Gururaja
2013-05-31  6:33   ` Hebbar Gururaja
2013-05-31  6:50   ` Prabhakar Lad
2013-05-31  6:50     ` Prabhakar Lad
2013-05-31 17:41   ` Kevin Hilman
2013-05-31 17:41     ` Kevin Hilman
2013-05-31 17:41     ` Kevin Hilman
2013-06-04  9:39     ` Hebbar, Gururaja
2013-06-04  9:39       ` Hebbar, Gururaja
2013-06-04  9:39       ` Hebbar, Gururaja
2013-06-10 11:25     ` Hebbar, Gururaja
2013-06-10 11:25       ` Hebbar, Gururaja
2013-06-10 11:25       ` Hebbar, Gururaja
2013-06-13  9:39     ` Hebbar, Gururaja
2013-06-13  9:39       ` Hebbar, Gururaja
2013-06-13  9:39       ` Hebbar, Gururaja
2013-06-13 22:21       ` Kevin Hilman
2013-06-13 22:21         ` Kevin Hilman
2013-06-13 22:21         ` Kevin Hilman
2013-06-14 11:38         ` Hebbar, Gururaja
2013-06-14 11:38           ` Hebbar, Gururaja
2013-06-14 11:38           ` Hebbar, Gururaja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqqf11nw.fsf@linaro.org \
    --to=khilman@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.