All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: t-kristo@ti.com
Cc: linux-omap@vger.kernel.org, paul@pwsan.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv9 0/8] ARM: OMAP4: core retention support
Date: Tue, 06 Nov 2012 13:19:05 -0800	[thread overview]
Message-ID: <87wqxy77li.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1352193483.8788.43.camel@sokoban> (Tero Kristo's message of "Tue, 6 Nov 2012 11:18:02 +0200")

Tero Kristo <t-kristo@ti.com> writes:

> Hi Kevin,
>
> On Mon, 2012-11-05 at 14:23 -0800, Kevin Hilman wrote:
>> Hi Tero,
>> 
>> Tero Kristo <t-kristo@ti.com> writes:
>> 
>> > Hi,
>> >
>> > Changes compared to previous version:
>> > - rebased on top of 3.7-rc1
>> > - applies on top of latest func pwrst code (v6)
>> > - added back patch #1 to this set (it wasn't queued yet after all)
>> > - added patch #7 for fixing a bug in the functional pwrst code
>> > - added patch #8 for fixing a regression with MUSB PHY power handling
>> >   (not quite sure if this is the correct way to fix this or not)
>> >
>> > Tested with omap4460 gp panda + omap4430 emu blaze boards, with cpuidle +
>> > suspend.
>> >
>> > Branch also available here:
>> > git://gitorious.org/~kristo/omap-pm/omap-pm-work.git
>> > branch: mainline-3.7-rc1-omap4-ret-v9
>> 
>> I tested this branch on 4430/Panda and 4460/Panda-ES and I'm seeing
>> several domains not hitting target power state in suspend[1].
>> 
>> Am I missing some other fixes?  Using omap2plus_defconfig, I tried your
>> branch alone, and merged with v3.7-rc4, and I get the same errors.

[...]

> This looks like a combination of boot loader/kernel problems. My guess
> is that l3init is probably held on by the USB, and both ivahd / tesla
> are held on by some DSP/IVA modules which are not idling properly.
>
> The last patch in this set should fix the USB problems at least
> partially, but also the USB DPLL itself might be in wrong state,
> attached patch might help for that one and get l3init to idle.
>
> For DSP I don't have a patch right now, what is the boot loader you are
> using? (Can you provide git / commit / config info?)

I was using mainline u-boot at tag v2012.04.01 when I saw the errors.  

To check the bootloader, I upgraded to the latest mainline tag
(v2012.10) and the problems are gone on both 4430/Panda and
4460/Panda-ES...   Interesting.

That suggests that there's still some kernel assumptions/dependencies on
the bootloader that need to be addressed.

Kevin




WARNING: multiple messages have this Message-ID (diff)
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv9 0/8] ARM: OMAP4: core retention support
Date: Tue, 06 Nov 2012 13:19:05 -0800	[thread overview]
Message-ID: <87wqxy77li.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1352193483.8788.43.camel@sokoban> (Tero Kristo's message of "Tue, 6 Nov 2012 11:18:02 +0200")

Tero Kristo <t-kristo@ti.com> writes:

> Hi Kevin,
>
> On Mon, 2012-11-05 at 14:23 -0800, Kevin Hilman wrote:
>> Hi Tero,
>> 
>> Tero Kristo <t-kristo@ti.com> writes:
>> 
>> > Hi,
>> >
>> > Changes compared to previous version:
>> > - rebased on top of 3.7-rc1
>> > - applies on top of latest func pwrst code (v6)
>> > - added back patch #1 to this set (it wasn't queued yet after all)
>> > - added patch #7 for fixing a bug in the functional pwrst code
>> > - added patch #8 for fixing a regression with MUSB PHY power handling
>> >   (not quite sure if this is the correct way to fix this or not)
>> >
>> > Tested with omap4460 gp panda + omap4430 emu blaze boards, with cpuidle +
>> > suspend.
>> >
>> > Branch also available here:
>> > git://gitorious.org/~kristo/omap-pm/omap-pm-work.git
>> > branch: mainline-3.7-rc1-omap4-ret-v9
>> 
>> I tested this branch on 4430/Panda and 4460/Panda-ES and I'm seeing
>> several domains not hitting target power state in suspend[1].
>> 
>> Am I missing some other fixes?  Using omap2plus_defconfig, I tried your
>> branch alone, and merged with v3.7-rc4, and I get the same errors.

[...]

> This looks like a combination of boot loader/kernel problems. My guess
> is that l3init is probably held on by the USB, and both ivahd / tesla
> are held on by some DSP/IVA modules which are not idling properly.
>
> The last patch in this set should fix the USB problems at least
> partially, but also the USB DPLL itself might be in wrong state,
> attached patch might help for that one and get l3init to idle.
>
> For DSP I don't have a patch right now, what is the boot loader you are
> using? (Can you provide git / commit / config info?)

I was using mainline u-boot at tag v2012.04.01 when I saw the errors.  

To check the bootloader, I upgraded to the latest mainline tag
(v2012.10) and the problems are gone on both 4430/Panda and
4460/Panda-ES...   Interesting.

That suggests that there's still some kernel assumptions/dependencies on
the bootloader that need to be addressed.

Kevin

  reply	other threads:[~2012-11-06 21:19 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18  9:20 [PATCHv9 0/8] ARM: OMAP4: core retention support Tero Kristo
2012-10-18  9:20 ` Tero Kristo
2012-10-18  9:20 ` [PATCHv9 1/8] ARM: OMAP: hwmod: Add support for per hwmod/module context lost count Tero Kristo
2012-10-18  9:20   ` Tero Kristo
2012-10-27  3:00   ` Paul Walmsley
2012-10-27  3:00     ` Paul Walmsley
2012-11-21 23:05   ` Paul Walmsley
2012-11-21 23:05     ` Paul Walmsley
2012-10-18  9:20 ` [PATCHv9 2/8] ARM: OMAP4: PM: add errata support Tero Kristo
2012-10-18  9:20   ` Tero Kristo
2012-11-05 22:36   ` Kevin Hilman
2012-11-05 22:36     ` Kevin Hilman
2012-11-06 21:52     ` Kevin Hilman
2012-11-06 21:52       ` Kevin Hilman
2012-11-07 10:11       ` Tero Kristo
2012-11-07 10:11         ` Tero Kristo
2012-10-18  9:20 ` [PATCHv9 3/8] ARM: OMAP4460: Workaround for ROM bug because of CA9 r2pX GIC control register change Tero Kristo
2012-10-18  9:20   ` Tero Kristo
2012-10-18  9:20 ` [PATCHv9 4/8] ARM: OMAP4: suspend: Program all domains to retention Tero Kristo
2012-10-18  9:20   ` Tero Kristo
2012-10-18  9:20 ` [PATCHv9 5/8] ARM: OMAP4: PM: put all domains to OSWR during suspend Tero Kristo
2012-10-18  9:20   ` Tero Kristo
2012-10-18  9:20 ` [PATCHv9 6/8] ARM: OMAP4: retrigger localtimers after re-enabling gic Tero Kristo
2012-10-18  9:20   ` Tero Kristo
2012-10-27  2:51   ` Paul Walmsley
2012-10-27  2:51     ` Paul Walmsley
2012-11-05 22:25   ` Kevin Hilman
2012-11-05 22:25     ` Kevin Hilman
2012-11-06  9:15     ` Tero Kristo
2012-11-06  9:15       ` Tero Kristo
2012-10-18  9:20 ` [PATCHv9 7/8] ARM: OMAP: PM: update target fpwrst to what pwrdm can reach Tero Kristo
2012-10-18  9:20   ` Tero Kristo
2012-10-18  9:20 ` [PATCHv9 8/8] ARM: OMAP4: USB: power down MUSB PHY if not used Tero Kristo
2012-10-18  9:20   ` Tero Kristo
2012-10-18 10:33   ` Felipe Balbi
2012-10-18 10:33     ` Felipe Balbi
2012-10-18 12:18     ` Tero Kristo
2012-10-18 12:18       ` Tero Kristo
2012-10-18 13:53       ` Felipe Balbi
2012-10-18 13:53         ` Felipe Balbi
2012-10-18 14:39         ` Tero Kristo
2012-10-18 14:39           ` Tero Kristo
2012-10-18 14:41           ` Felipe Balbi
2012-10-18 14:41             ` Felipe Balbi
2012-10-22  8:54           ` kishon
2012-10-22  8:54             ` kishon
2012-10-22  9:07             ` Felipe Balbi
2012-10-22  9:07               ` Felipe Balbi
2012-10-22  9:25               ` kishon
2012-10-22  9:25                 ` kishon
2012-10-27  2:52   ` Paul Walmsley
2012-10-27  2:52     ` Paul Walmsley
2012-10-27  3:02 ` [PATCHv9 0/8] ARM: OMAP4: core retention support Paul Walmsley
2012-10-27  3:02   ` Paul Walmsley
2012-11-05 22:23 ` Kevin Hilman
2012-11-05 22:23   ` Kevin Hilman
2012-11-06  9:18   ` Tero Kristo
2012-11-06  9:18     ` Tero Kristo
2012-11-06 21:19     ` Kevin Hilman [this message]
2012-11-06 21:19       ` Kevin Hilman
2012-11-07 10:17       ` Tero Kristo
2012-11-07 10:17         ` Tero Kristo
2012-11-12 14:41       ` Tero Kristo
2012-11-12 14:41         ` Tero Kristo
2012-11-13 19:18         ` Kevin Hilman
2012-11-13 19:18           ` Kevin Hilman
2012-11-07 18:35   ` Paul Walmsley
2012-11-07 18:35     ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqxy77li.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.