From: Jian-Jhong Ding <jj_ding-9cfG7bMpBgR9nmWX13WWKA@public.gmane.org>
To: Benjamin Tissoires
<benjamin.tissoires-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>,
Stephane Chatty <chatty-rXV5z7KbLFk@public.gmane.org>,
fabien.andre-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
scott.liu-9cfG7bMpBgR9nmWX13WWKA@public.gmane.org,
Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
Shubhrajyoti Datta
<omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] i2c-hid: introduce HID over i2c specification implementation
Date: Thu, 18 Oct 2012 18:16:21 +0800 [thread overview]
Message-ID: <87wqyojdai.fsf@emc.com.tw> (raw)
In-Reply-To: <CAN+gG=HLxXJAwZ8mWzuDFVBht4BeWaSEvXOQZEBgS8akyerQEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Benjamin Tissoires <benjamin.tissoires-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
> Hi JJ,
>
> On Thu, Oct 18, 2012 at 11:07 AM, Jian-Jhong Ding <jj_ding-9cfG7bMpBgR9nmWX13WWKA@public.gmane.org> wrote:
>> Hi Benjamin,
>>
>> Some suggestions to make the error messages more "human", and a little
>> question on the return value of i2c_hid_fetch_hid_descriptor. Please see below:
>
> I fully agree with the more "human" error messages.
>
> However, for i2c_hid_fetch_hid_descriptor return values, I'm affraid I
> can't use -EINVAL.
>
> Jean Delvare (one of the i2c maintainers) told in his review of the v1:
> "
> These should all be -ENODEV in this function
> [i2c_hid_fetch_hid_descriptor]: the device isn't what you
> expected. EINVAL is for invalid argument.
> "
I must have missed that mail. Thank you for pointing this out.
-JJ
> So ENODEV is the right return value.
>
> Anyway, thanks for the review.
>
> Cheers,
> Benjamin
WARNING: multiple messages have this Message-ID (diff)
From: Jian-Jhong Ding <jj_ding@emc.com.tw>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Stephane Chatty <chatty@enac.fr>,
fabien.andre@gmail.com, scott.liu@emc.com.tw,
Jean Delvare <khali@linux-fr.org>,
Shubhrajyoti Datta <omaplinuxkernel@gmail.com>,
linux-i2c@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c-hid: introduce HID over i2c specification implementation
Date: Thu, 18 Oct 2012 18:16:21 +0800 [thread overview]
Message-ID: <87wqyojdai.fsf@emc.com.tw> (raw)
In-Reply-To: <CAN+gG=HLxXJAwZ8mWzuDFVBht4BeWaSEvXOQZEBgS8akyerQEw@mail.gmail.com>
Benjamin Tissoires <benjamin.tissoires@gmail.com> writes:
> Hi JJ,
>
> On Thu, Oct 18, 2012 at 11:07 AM, Jian-Jhong Ding <jj_ding@emc.com.tw> wrote:
>> Hi Benjamin,
>>
>> Some suggestions to make the error messages more "human", and a little
>> question on the return value of i2c_hid_fetch_hid_descriptor. Please see below:
>
> I fully agree with the more "human" error messages.
>
> However, for i2c_hid_fetch_hid_descriptor return values, I'm affraid I
> can't use -EINVAL.
>
> Jean Delvare (one of the i2c maintainers) told in his review of the v1:
> "
> These should all be -ENODEV in this function
> [i2c_hid_fetch_hid_descriptor]: the device isn't what you
> expected. EINVAL is for invalid argument.
> "
I must have missed that mail. Thank you for pointing this out.
-JJ
> So ENODEV is the right return value.
>
> Anyway, thanks for the review.
>
> Cheers,
> Benjamin
next prev parent reply other threads:[~2012-10-18 10:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 20:38 [PATCH v2] i2c-hid: introduce HID over i2c specification implementation Benjamin Tissoires
2012-10-15 20:38 ` Benjamin Tissoires
[not found] ` <1350333533-13366-1-git-send-email-benjamin.tissoires-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-16 8:17 ` Jiri Slaby
2012-10-16 8:17 ` Jiri Slaby
[not found] ` <507D182E.9010902-AlSwsSmVLrQ@public.gmane.org>
2012-10-16 17:36 ` Benjamin Tissoires
2012-10-16 17:36 ` Benjamin Tissoires
[not found] ` <CAN+gG=E3QhwKeZfJtOhFrOqOnPW=hdbij-U7euvVEQ_MuNaXaQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-09 9:49 ` Jiri Kosina
2012-11-09 9:49 ` Jiri Kosina
[not found] ` <alpine.LNX.2.00.1211091048590.27271-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2012-11-09 9:59 ` Benjamin Tissoires
2012-11-09 9:59 ` Benjamin Tissoires
2012-10-18 9:07 ` Jian-Jhong Ding
2012-10-18 9:07 ` Jian-Jhong Ding
[not found] ` <87zk3kjghz.fsf-9cfG7bMpBgR9nmWX13WWKA@public.gmane.org>
2012-10-18 9:16 ` Benjamin Tissoires
2012-10-18 9:16 ` Benjamin Tissoires
[not found] ` <CAN+gG=HLxXJAwZ8mWzuDFVBht4BeWaSEvXOQZEBgS8akyerQEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-18 10:16 ` Jian-Jhong Ding [this message]
2012-10-18 10:16 ` Jian-Jhong Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqyojdai.fsf@emc.com.tw \
--to=jj_ding-9cfg7bmpbgr9nmwx13wwka@public.gmane.org \
--cc=benjamin.tissoires-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=chatty-rXV5z7KbLFk@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=fabien.andre-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jkosina-AlSwsSmVLrQ@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=scott.liu-9cfG7bMpBgR9nmWX13WWKA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.