From: Kevin Hilman <khilman@ti.com>
To: Sergio Aguirre <saaguirre@ti.com>
Cc: linux-media@vger.kernel.org, linux-omap@vger.kernel.org,
laurent.pinchart@ideasonboard.com, sakari.ailus@iki.fi
Subject: Re: [PATCH v2 05/11] OMAP4: Add base addresses for ISS
Date: Fri, 02 Dec 2011 14:45:38 -0800 [thread overview]
Message-ID: <87wraelhil.fsf@ti.com> (raw)
In-Reply-To: <1322698500-29924-6-git-send-email-saaguirre@ti.com> (Sergio Aguirre's message of "Wed, 30 Nov 2011 18:14:54 -0600")
Sergio Aguirre <saaguirre@ti.com> writes:
> NOTE: This isn't the whole list of features that the
> ISS supports, but the only ones supported at the moment.
>
> Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
[...]
> diff --git a/arch/arm/plat-omap/include/plat/omap44xx.h b/arch/arm/plat-omap/include/plat/omap44xx.h
> index ea2b8a6..31432aa 100644
> --- a/arch/arm/plat-omap/include/plat/omap44xx.h
> +++ b/arch/arm/plat-omap/include/plat/omap44xx.h
> @@ -49,6 +49,15 @@
> #define OMAP44XX_MAILBOX_BASE (L4_44XX_BASE + 0xF4000)
> #define OMAP44XX_HSUSB_OTG_BASE (L4_44XX_BASE + 0xAB000)
>
> +#define OMAP44XX_ISS_BASE 0x52000000
> +#define OMAP44XX_ISS_TOP_BASE (OMAP44XX_ISS_BASE + 0x0)
> +#define OMAP44XX_ISS_CSI2_A_REGS1_BASE (OMAP44XX_ISS_BASE + 0x1000)
> +#define OMAP44XX_ISS_CAMERARX_CORE1_BASE (OMAP44XX_ISS_BASE + 0x1170)
> +
> +#define OMAP44XX_ISS_TOP_END (OMAP44XX_ISS_TOP_BASE + 256 - 1)
> +#define OMAP44XX_ISS_CSI2_A_REGS1_END (OMAP44XX_ISS_CSI2_A_REGS1_BASE + 368 - 1)
> +#define OMAP44XX_ISS_CAMERARX_CORE1_END (OMAP44XX_ISS_CAMERARX_CORE1_BASE + 32 - 1)
> +
> #define OMAP4_MMU1_BASE 0x55082000
> #define OMAP4_MMU2_BASE 0x4A066000
Who are the users of thes address ranges?
IMO, we shouldn't ned to add anymore based address definitions. These
should be done in the hwmod data, and drivers get base addresses using
the standard ways of getting resources (DT or platform_get_resource())
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@ti.com>
To: Sergio Aguirre <saaguirre@ti.com>
Cc: <linux-media@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<laurent.pinchart@ideasonboard.com>, <sakari.ailus@iki.fi>
Subject: Re: [PATCH v2 05/11] OMAP4: Add base addresses for ISS
Date: Fri, 02 Dec 2011 14:45:38 -0800 [thread overview]
Message-ID: <87wraelhil.fsf@ti.com> (raw)
In-Reply-To: <1322698500-29924-6-git-send-email-saaguirre@ti.com> (Sergio Aguirre's message of "Wed, 30 Nov 2011 18:14:54 -0600")
Sergio Aguirre <saaguirre@ti.com> writes:
> NOTE: This isn't the whole list of features that the
> ISS supports, but the only ones supported at the moment.
>
> Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
[...]
> diff --git a/arch/arm/plat-omap/include/plat/omap44xx.h b/arch/arm/plat-omap/include/plat/omap44xx.h
> index ea2b8a6..31432aa 100644
> --- a/arch/arm/plat-omap/include/plat/omap44xx.h
> +++ b/arch/arm/plat-omap/include/plat/omap44xx.h
> @@ -49,6 +49,15 @@
> #define OMAP44XX_MAILBOX_BASE (L4_44XX_BASE + 0xF4000)
> #define OMAP44XX_HSUSB_OTG_BASE (L4_44XX_BASE + 0xAB000)
>
> +#define OMAP44XX_ISS_BASE 0x52000000
> +#define OMAP44XX_ISS_TOP_BASE (OMAP44XX_ISS_BASE + 0x0)
> +#define OMAP44XX_ISS_CSI2_A_REGS1_BASE (OMAP44XX_ISS_BASE + 0x1000)
> +#define OMAP44XX_ISS_CAMERARX_CORE1_BASE (OMAP44XX_ISS_BASE + 0x1170)
> +
> +#define OMAP44XX_ISS_TOP_END (OMAP44XX_ISS_TOP_BASE + 256 - 1)
> +#define OMAP44XX_ISS_CSI2_A_REGS1_END (OMAP44XX_ISS_CSI2_A_REGS1_BASE + 368 - 1)
> +#define OMAP44XX_ISS_CAMERARX_CORE1_END (OMAP44XX_ISS_CAMERARX_CORE1_BASE + 32 - 1)
> +
> #define OMAP4_MMU1_BASE 0x55082000
> #define OMAP4_MMU2_BASE 0x4A066000
Who are the users of thes address ranges?
IMO, we shouldn't ned to add anymore based address definitions. These
should be done in the hwmod data, and drivers get base addresses using
the standard ways of getting resources (DT or platform_get_resource())
Kevin
next prev parent reply other threads:[~2011-12-02 22:45 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 0:14 [PATCH v2 00/11] v4l2: OMAP4 ISS driver + Sensor + Board support Sergio Aguirre
2011-12-01 0:14 ` Sergio Aguirre
2011-12-01 0:14 ` [PATCH v2 01/11] TWL6030: Add mapping for auxiliary regs Sergio Aguirre
2011-12-01 0:14 ` Sergio Aguirre
2011-12-01 15:58 ` T Krishnamoorthy, Balaji
2011-12-01 17:47 ` Aguirre, Sergio
2011-12-01 17:47 ` Aguirre, Sergio
2011-12-01 0:14 ` [PATCH v2 02/11] mfd: twl6040: Fix wrong TWL6040_GPO3 bitfield value Sergio Aguirre
2011-12-01 0:14 ` Sergio Aguirre
2011-12-01 17:24 ` Laurent Pinchart
2011-12-01 17:35 ` Aguirre, Sergio
2011-12-02 1:08 ` Laurent Pinchart
2011-12-01 0:14 ` [PATCH v2 03/11] v4l: Introduce sensor operation for getting interface configuration Sergio Aguirre
2011-12-01 0:14 ` Sergio Aguirre
2011-12-02 13:32 ` Stanimir Varbanov
2011-12-02 16:04 ` Aguirre, Sergio
2011-12-01 0:14 ` [PATCH v2 04/11] OMAP4: hwmod: Include CSI2A and CSIPHY1 memory sections Sergio Aguirre
2011-12-01 0:14 ` Sergio Aguirre
2011-12-01 6:34 ` Hiremath, Vaibhav
2011-12-01 13:17 ` Aguirre, Sergio
2011-12-01 13:17 ` Aguirre, Sergio
2011-12-02 22:49 ` Kevin Hilman
2011-12-02 22:49 ` Kevin Hilman
2011-12-02 22:59 ` Aguirre, Sergio
2011-12-02 23:18 ` Kevin Hilman
2011-12-02 23:18 ` Kevin Hilman
2011-12-01 0:14 ` [PATCH v2 05/11] OMAP4: Add base addresses for ISS Sergio Aguirre
2011-12-01 0:14 ` Sergio Aguirre
2011-12-01 17:24 ` Laurent Pinchart
2011-12-01 17:30 ` Aguirre, Sergio
2011-12-02 22:45 ` Kevin Hilman [this message]
2011-12-02 22:45 ` Kevin Hilman
2011-12-02 23:01 ` Aguirre, Sergio
2011-12-02 23:01 ` Aguirre, Sergio
2011-12-01 0:14 ` [PATCH v2 06/11] v4l: Add support for omap4iss driver Sergio Aguirre
2011-12-01 0:14 ` Sergio Aguirre
2011-12-11 9:11 ` Sakari Ailus
2012-01-23 9:10 ` Aguirre, Sergio
2012-01-14 17:51 ` Sakari Ailus
2012-01-25 8:58 ` Aguirre, Sergio
2012-01-26 21:05 ` Sakari Ailus
2012-03-09 3:14 ` Aguirre, Sergio
2012-03-09 3:14 ` Aguirre, Sergio
2011-12-01 0:14 ` [PATCH v2 07/11] v4l: Add support for ov5640 sensor Sergio Aguirre
2011-12-01 0:14 ` Sergio Aguirre
2011-12-01 0:14 ` [PATCH v2 08/11] v4l: Add support for ov5650 sensor Sergio Aguirre
2011-12-01 0:14 ` Sergio Aguirre
2011-12-01 0:14 ` [PATCH v2 09/11] arm: omap4430sdp: Add support for omap4iss camera Sergio Aguirre
2011-12-01 0:14 ` Sergio Aguirre
2011-12-11 8:05 ` Sakari Ailus
2011-12-01 0:14 ` [PATCH v2 10/11] arm: omap4panda: " Sergio Aguirre
2011-12-01 0:14 ` Sergio Aguirre
2011-12-01 6:24 ` Hiremath, Vaibhav
2011-12-01 13:34 ` Aguirre, Sergio
2011-12-01 13:34 ` Aguirre, Sergio
2011-12-01 0:15 ` [PATCH v2 11/11] arm: Add support for CMA for omap4iss driver Sergio Aguirre
2011-12-01 0:15 ` Sergio Aguirre
2011-12-01 4:05 ` [PATCH v2 00/11] v4l2: OMAP4 ISS driver + Sensor + Board support Aguirre, Sergio
2011-12-01 4:05 ` Aguirre, Sergio
2011-12-01 16:14 ` Sakari Ailus
2011-12-01 17:41 ` Aguirre, Sergio
2011-12-01 17:26 ` Laurent Pinchart
2011-12-01 17:43 ` Aguirre, Sergio
2011-12-01 17:43 ` Aguirre, Sergio
2011-12-07 21:50 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wraelhil.fsf@ti.com \
--to=khilman@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=saaguirre@ti.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.