All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francisco Jerez <currojerez-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org>
To: Luca Barbieri <luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] renouveau/nv10: remove duplicate vertex buffer registers
Date: Mon, 01 Mar 2010 02:34:03 +0100	[thread overview]
Message-ID: <87wrxwn7uc.fsf@riseup.net> (raw)
In-Reply-To: <1267211574-2443-1-git-send-email-luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org> (Luca Barbieri's message of "Fri, 26 Feb 2010 20:12:54 +0100")


[-- Attachment #1.1.1: Type: text/plain, Size: 4012 bytes --]

Luca Barbieri <luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org> writes:

> NV10TCL defines the vertex buffer registers both as arrays and as
> individual named registers.
>
> This causes duplicate register definitions and the individual registers
> are not used either by the DDX or by the Mesa driver.
>
> Francisco Jerez said to remove them all.
>
I forgot to ask: why do they bother you?

> Signed-off-by: Luca Barbieri <luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org>
> ---
>  renouveau.xml |   49 -------------------------------------------------
>  1 files changed, 0 insertions(+), 49 deletions(-)
>
> diff --git a/renouveau.xml b/renouveau.xml
> index 8fb35a5..3fb9d9a 100644
> --- a/renouveau.xml
> +++ b/renouveau.xml
> @@ -2498,55 +2498,6 @@
>        <bitfield name="STRIDE" high="15" low="8" type="int"/>
>        <bitfield name="POS_HOMOGENEOUS" high="24" low="24" type="boolean"/>
>      </reg32>
> -
> -    <reg32 offset="0x0d00" name="VERTEX_ARRAY_OFFSET_POS" type="hexa"/>
> -    <reg32 offset="0x0d04" name="VERTEX_ARRAY_FORMAT_POS" type="bitfield">
> -      <bitfield name="TYPE" high="3" low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7" low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15" low="8" type="int"/>
> -    </reg32>
> -    <reg32 offset="0x0d08" name="VERTEX_ARRAY_OFFSET_COL" type="hexa"/>
> -    <reg32 offset="0x0d0c" name="VERTEX_ARRAY_FORMAT_COL" type="bitfield">
> -      <bitfield name="TYPE" high="3" low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7" low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15" low="8" type="int"/>
> -    </reg32>
> -    <reg32 offset="0x0d10" name="VERTEX_ARRAY_OFFSET_COL2" type="hexa"/>
> -    <reg32 offset="0x0d14" name="VERTEX_ARRAY_FORMAT_COL2" type="bitfield">
> -      <bitfield name="TYPE" high="3" low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7" low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15" low="8" type="int"/>
> -    </reg32>
> -    <reg32 offset="0x0d18" name="VERTEX_ARRAY_OFFSET_TX0" type="hexa"/>
> -    <reg32 offset="0x0d1c" name="VERTEX_ARRAY_FORMAT_TX0" type="bitfield">
> -      <bitfield name="TYPE" high="3" low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7" low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15" low="8" type="int"/>
> -    </reg32>
> -    <reg32 offset="0x0d20" name="VERTEX_ARRAY_OFFSET_TX1" type="hexa"/>
> -    <reg32 offset="0x0d24" name="VERTEX_ARRAY_FORMAT_TX1" type="bitfield">
> -      <bitfield name="TYPE" high="3" low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7" low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15" low="8" type="int"/>
> -    </reg32>
> -    <reg32 offset="0x0d28" name="VERTEX_ARRAY_OFFSET_NOR" type="hexa"/>
> -    <reg32 offset="0x0d2c" name="VERTEX_ARRAY_FORMAT_NOR" type="bitfield">
> -      <bitfield name="TYPE" high="3" low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7" low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15" low="8" type="int"/>
> -    </reg32>
> -    <reg32 offset="0x0d30" name="VERTEX_ARRAY_OFFSET_WGH" type="hexa"/>
> -    <reg32 offset="0x0d34" name="VERTEX_ARRAY_FORMAT_WGH" type="bitfield">
> -      <bitfield name="TYPE" high="3" low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7" low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15" low="8" type="int"/>
> -    </reg32>
> -    <reg32 offset="0x0d38" name="VERTEX_ARRAY_OFFSET_FOG" type="hexa"/>
> -    <reg32 offset="0x0d3c" name="VERTEX_ARRAY_FORMAT_FOG" type="bitfield">
> -      <bitfield name="TYPE" high="3" low="0" type="int"/>
> -      <bitfield name="FIELDS" high="7" low="4" type="int"/>
> -      <bitfield name="STRIDE" high="15" low="8" type="int"/>
> -    </reg32>
>      <reg32 offset="0x0dfc" name="VERTEX_BEGIN_END" type="enum" enum_name="nv10_begin_end"/>
>      <reg32 offset="0x0e00" name="VB_ELEMENT_U16" type="bitfield">
>        <bitfield name="I0" high="15" low="0" type="int"/>

[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

  parent reply	other threads:[~2010-03-01  1:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-26 19:12 [PATCH] renouveau/nv10: remove duplicate vertex buffer registers Luca Barbieri
     [not found] ` <1267211574-2443-1-git-send-email-luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org>
2010-03-01  1:34   ` Francisco Jerez [this message]
     [not found]     ` <87wrxwn7uc.fsf-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org>
2010-03-01 13:18       ` Luca Barbieri
     [not found]         ` <ff13bc9a1003010518s1fb4db5cj7ada2adc6d7e2604-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-01 21:42           ` Francisco Jerez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wrxwn7uc.fsf@riseup.net \
    --to=currojerez-sgozh3hwpm2stnjn9+bgxg@public.gmane.org \
    --cc=luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.