Re: [PATCH] renouveau/nv10: remove duplicate vertex buffer registers

From: Francisco Jerez <currojerez-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org>
To: Luca Barbieri <luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] renouveau/nv10: remove duplicate vertex buffer registers
Date: Mon, 01 Mar 2010 22:42:18 +0100	[thread overview]
Message-ID: <87aaurk9c5.fsf@riseup.net> (raw)
In-Reply-To: <ff13bc9a1003010518s1fb4db5cj7ada2adc6d7e2604-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> (Luca Barbieri's message of "Mon, 1 Mar 2010 14:18:04 +0100")

[-- Attachment #1.1.1: Type: text/plain, Size: 986 bytes --]

Luca Barbieri <luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org> writes:

> On Mon, Mar 1, 2010 at 2:34 AM, Francisco Jerez <currojerez-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org> wrote:
>> Luca Barbieri <luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org> writes:
>>
>>> NV10TCL defines the vertex buffer registers both as arrays and as
>>> individual named registers.
>>>
>>> This causes duplicate register definitions and the individual registers
>>> are not used either by the DDX or by the Mesa driver.
>>>
>>> Francisco Jerez said to remove them all.
>>>
>> I forgot to ask: why do they bother you?
>
> I am experimenting with rewriting renouveau-gen.c in Python, and
> stored registers in a dictionary with the register offset as key.
>
> Having multiple registers at the same offset obviously causes issues
> with that, and this is the only instance of that problem, so it seems
> better to remove it than adding complexity to tools to handle it.

Fair enough, commited.

[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau