* [PATCH] renouveau/nv10: remove duplicate vertex buffer registers
@ 2010-02-26 19:12 Luca Barbieri
[not found] ` <1267211574-2443-1-git-send-email-luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Luca Barbieri @ 2010-02-26 19:12 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Luca Barbieri
NV10TCL defines the vertex buffer registers both as arrays and as
individual named registers.
This causes duplicate register definitions and the individual registers
are not used either by the DDX or by the Mesa driver.
Francisco Jerez said to remove them all.
Signed-off-by: Luca Barbieri <luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org>
---
renouveau.xml | 49 -------------------------------------------------
1 files changed, 0 insertions(+), 49 deletions(-)
diff --git a/renouveau.xml b/renouveau.xml
index 8fb35a5..3fb9d9a 100644
--- a/renouveau.xml
+++ b/renouveau.xml
@@ -2498,55 +2498,6 @@
<bitfield name="STRIDE" high="15" low="8" type="int"/>
<bitfield name="POS_HOMOGENEOUS" high="24" low="24" type="boolean"/>
</reg32>
-
- <reg32 offset="0x0d00" name="VERTEX_ARRAY_OFFSET_POS" type="hexa"/>
- <reg32 offset="0x0d04" name="VERTEX_ARRAY_FORMAT_POS" type="bitfield">
- <bitfield name="TYPE" high="3" low="0" type="int"/>
- <bitfield name="FIELDS" high="7" low="4" type="int"/>
- <bitfield name="STRIDE" high="15" low="8" type="int"/>
- </reg32>
- <reg32 offset="0x0d08" name="VERTEX_ARRAY_OFFSET_COL" type="hexa"/>
- <reg32 offset="0x0d0c" name="VERTEX_ARRAY_FORMAT_COL" type="bitfield">
- <bitfield name="TYPE" high="3" low="0" type="int"/>
- <bitfield name="FIELDS" high="7" low="4" type="int"/>
- <bitfield name="STRIDE" high="15" low="8" type="int"/>
- </reg32>
- <reg32 offset="0x0d10" name="VERTEX_ARRAY_OFFSET_COL2" type="hexa"/>
- <reg32 offset="0x0d14" name="VERTEX_ARRAY_FORMAT_COL2" type="bitfield">
- <bitfield name="TYPE" high="3" low="0" type="int"/>
- <bitfield name="FIELDS" high="7" low="4" type="int"/>
- <bitfield name="STRIDE" high="15" low="8" type="int"/>
- </reg32>
- <reg32 offset="0x0d18" name="VERTEX_ARRAY_OFFSET_TX0" type="hexa"/>
- <reg32 offset="0x0d1c" name="VERTEX_ARRAY_FORMAT_TX0" type="bitfield">
- <bitfield name="TYPE" high="3" low="0" type="int"/>
- <bitfield name="FIELDS" high="7" low="4" type="int"/>
- <bitfield name="STRIDE" high="15" low="8" type="int"/>
- </reg32>
- <reg32 offset="0x0d20" name="VERTEX_ARRAY_OFFSET_TX1" type="hexa"/>
- <reg32 offset="0x0d24" name="VERTEX_ARRAY_FORMAT_TX1" type="bitfield">
- <bitfield name="TYPE" high="3" low="0" type="int"/>
- <bitfield name="FIELDS" high="7" low="4" type="int"/>
- <bitfield name="STRIDE" high="15" low="8" type="int"/>
- </reg32>
- <reg32 offset="0x0d28" name="VERTEX_ARRAY_OFFSET_NOR" type="hexa"/>
- <reg32 offset="0x0d2c" name="VERTEX_ARRAY_FORMAT_NOR" type="bitfield">
- <bitfield name="TYPE" high="3" low="0" type="int"/>
- <bitfield name="FIELDS" high="7" low="4" type="int"/>
- <bitfield name="STRIDE" high="15" low="8" type="int"/>
- </reg32>
- <reg32 offset="0x0d30" name="VERTEX_ARRAY_OFFSET_WGH" type="hexa"/>
- <reg32 offset="0x0d34" name="VERTEX_ARRAY_FORMAT_WGH" type="bitfield">
- <bitfield name="TYPE" high="3" low="0" type="int"/>
- <bitfield name="FIELDS" high="7" low="4" type="int"/>
- <bitfield name="STRIDE" high="15" low="8" type="int"/>
- </reg32>
- <reg32 offset="0x0d38" name="VERTEX_ARRAY_OFFSET_FOG" type="hexa"/>
- <reg32 offset="0x0d3c" name="VERTEX_ARRAY_FORMAT_FOG" type="bitfield">
- <bitfield name="TYPE" high="3" low="0" type="int"/>
- <bitfield name="FIELDS" high="7" low="4" type="int"/>
- <bitfield name="STRIDE" high="15" low="8" type="int"/>
- </reg32>
<reg32 offset="0x0dfc" name="VERTEX_BEGIN_END" type="enum" enum_name="nv10_begin_end"/>
<reg32 offset="0x0e00" name="VB_ELEMENT_U16" type="bitfield">
<bitfield name="I0" high="15" low="0" type="int"/>
--
1.6.6.1.476.g01ddb
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1267211574-2443-1-git-send-email-luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org>]
* Re: [PATCH] renouveau/nv10: remove duplicate vertex buffer registers [not found] ` <1267211574-2443-1-git-send-email-luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org> @ 2010-03-01 1:34 ` Francisco Jerez [not found] ` <87wrxwn7uc.fsf-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Francisco Jerez @ 2010-03-01 1:34 UTC (permalink / raw) To: Luca Barbieri; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW [-- Attachment #1.1.1: Type: text/plain, Size: 4012 bytes --] Luca Barbieri <luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org> writes: > NV10TCL defines the vertex buffer registers both as arrays and as > individual named registers. > > This causes duplicate register definitions and the individual registers > are not used either by the DDX or by the Mesa driver. > > Francisco Jerez said to remove them all. > I forgot to ask: why do they bother you? > Signed-off-by: Luca Barbieri <luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org> > --- > renouveau.xml | 49 ------------------------------------------------- > 1 files changed, 0 insertions(+), 49 deletions(-) > > diff --git a/renouveau.xml b/renouveau.xml > index 8fb35a5..3fb9d9a 100644 > --- a/renouveau.xml > +++ b/renouveau.xml > @@ -2498,55 +2498,6 @@ > <bitfield name="STRIDE" high="15" low="8" type="int"/> > <bitfield name="POS_HOMOGENEOUS" high="24" low="24" type="boolean"/> > </reg32> > - > - <reg32 offset="0x0d00" name="VERTEX_ARRAY_OFFSET_POS" type="hexa"/> > - <reg32 offset="0x0d04" name="VERTEX_ARRAY_FORMAT_POS" type="bitfield"> > - <bitfield name="TYPE" high="3" low="0" type="int"/> > - <bitfield name="FIELDS" high="7" low="4" type="int"/> > - <bitfield name="STRIDE" high="15" low="8" type="int"/> > - </reg32> > - <reg32 offset="0x0d08" name="VERTEX_ARRAY_OFFSET_COL" type="hexa"/> > - <reg32 offset="0x0d0c" name="VERTEX_ARRAY_FORMAT_COL" type="bitfield"> > - <bitfield name="TYPE" high="3" low="0" type="int"/> > - <bitfield name="FIELDS" high="7" low="4" type="int"/> > - <bitfield name="STRIDE" high="15" low="8" type="int"/> > - </reg32> > - <reg32 offset="0x0d10" name="VERTEX_ARRAY_OFFSET_COL2" type="hexa"/> > - <reg32 offset="0x0d14" name="VERTEX_ARRAY_FORMAT_COL2" type="bitfield"> > - <bitfield name="TYPE" high="3" low="0" type="int"/> > - <bitfield name="FIELDS" high="7" low="4" type="int"/> > - <bitfield name="STRIDE" high="15" low="8" type="int"/> > - </reg32> > - <reg32 offset="0x0d18" name="VERTEX_ARRAY_OFFSET_TX0" type="hexa"/> > - <reg32 offset="0x0d1c" name="VERTEX_ARRAY_FORMAT_TX0" type="bitfield"> > - <bitfield name="TYPE" high="3" low="0" type="int"/> > - <bitfield name="FIELDS" high="7" low="4" type="int"/> > - <bitfield name="STRIDE" high="15" low="8" type="int"/> > - </reg32> > - <reg32 offset="0x0d20" name="VERTEX_ARRAY_OFFSET_TX1" type="hexa"/> > - <reg32 offset="0x0d24" name="VERTEX_ARRAY_FORMAT_TX1" type="bitfield"> > - <bitfield name="TYPE" high="3" low="0" type="int"/> > - <bitfield name="FIELDS" high="7" low="4" type="int"/> > - <bitfield name="STRIDE" high="15" low="8" type="int"/> > - </reg32> > - <reg32 offset="0x0d28" name="VERTEX_ARRAY_OFFSET_NOR" type="hexa"/> > - <reg32 offset="0x0d2c" name="VERTEX_ARRAY_FORMAT_NOR" type="bitfield"> > - <bitfield name="TYPE" high="3" low="0" type="int"/> > - <bitfield name="FIELDS" high="7" low="4" type="int"/> > - <bitfield name="STRIDE" high="15" low="8" type="int"/> > - </reg32> > - <reg32 offset="0x0d30" name="VERTEX_ARRAY_OFFSET_WGH" type="hexa"/> > - <reg32 offset="0x0d34" name="VERTEX_ARRAY_FORMAT_WGH" type="bitfield"> > - <bitfield name="TYPE" high="3" low="0" type="int"/> > - <bitfield name="FIELDS" high="7" low="4" type="int"/> > - <bitfield name="STRIDE" high="15" low="8" type="int"/> > - </reg32> > - <reg32 offset="0x0d38" name="VERTEX_ARRAY_OFFSET_FOG" type="hexa"/> > - <reg32 offset="0x0d3c" name="VERTEX_ARRAY_FORMAT_FOG" type="bitfield"> > - <bitfield name="TYPE" high="3" low="0" type="int"/> > - <bitfield name="FIELDS" high="7" low="4" type="int"/> > - <bitfield name="STRIDE" high="15" low="8" type="int"/> > - </reg32> > <reg32 offset="0x0dfc" name="VERTEX_BEGIN_END" type="enum" enum_name="nv10_begin_end"/> > <reg32 offset="0x0e00" name="VB_ELEMENT_U16" type="bitfield"> > <bitfield name="I0" high="15" low="0" type="int"/> [-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --] [-- Attachment #2: Type: text/plain, Size: 181 bytes --] _______________________________________________ Nouveau mailing list Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <87wrxwn7uc.fsf-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org>]
* Re: [PATCH] renouveau/nv10: remove duplicate vertex buffer registers [not found] ` <87wrxwn7uc.fsf-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org> @ 2010-03-01 13:18 ` Luca Barbieri [not found] ` <ff13bc9a1003010518s1fb4db5cj7ada2adc6d7e2604-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Luca Barbieri @ 2010-03-01 13:18 UTC (permalink / raw) To: Francisco Jerez; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On Mon, Mar 1, 2010 at 2:34 AM, Francisco Jerez <currojerez-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org> wrote: > Luca Barbieri <luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org> writes: > >> NV10TCL defines the vertex buffer registers both as arrays and as >> individual named registers. >> >> This causes duplicate register definitions and the individual registers >> are not used either by the DDX or by the Mesa driver. >> >> Francisco Jerez said to remove them all. >> > I forgot to ask: why do they bother you? I am experimenting with rewriting renouveau-gen.c in Python, and stored registers in a dictionary with the register offset as key. Having multiple registers at the same offset obviously causes issues with that, and this is the only instance of that problem, so it seems better to remove it than adding complexity to tools to handle it. ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <ff13bc9a1003010518s1fb4db5cj7ada2adc6d7e2604-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] renouveau/nv10: remove duplicate vertex buffer registers [not found] ` <ff13bc9a1003010518s1fb4db5cj7ada2adc6d7e2604-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2010-03-01 21:42 ` Francisco Jerez 0 siblings, 0 replies; 4+ messages in thread From: Francisco Jerez @ 2010-03-01 21:42 UTC (permalink / raw) To: Luca Barbieri; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW [-- Attachment #1.1.1: Type: text/plain, Size: 986 bytes --] Luca Barbieri <luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org> writes: > On Mon, Mar 1, 2010 at 2:34 AM, Francisco Jerez <currojerez-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org> wrote: >> Luca Barbieri <luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org> writes: >> >>> NV10TCL defines the vertex buffer registers both as arrays and as >>> individual named registers. >>> >>> This causes duplicate register definitions and the individual registers >>> are not used either by the DDX or by the Mesa driver. >>> >>> Francisco Jerez said to remove them all. >>> >> I forgot to ask: why do they bother you? > > I am experimenting with rewriting renouveau-gen.c in Python, and > stored registers in a dictionary with the register offset as key. > > Having multiple registers at the same offset obviously causes issues > with that, and this is the only instance of that problem, so it seems > better to remove it than adding complexity to tools to handle it. Fair enough, commited. [-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --] [-- Attachment #2: Type: text/plain, Size: 181 bytes --] _______________________________________________ Nouveau mailing list Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-01 21:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-26 19:12 [PATCH] renouveau/nv10: remove duplicate vertex buffer registers Luca Barbieri
[not found] ` <1267211574-2443-1-git-send-email-luca-Ukmtq+NC3rhBHFWNQifrYwC/G2K4zDHf@public.gmane.org>
2010-03-01 1:34 ` Francisco Jerez
[not found] ` <87wrxwn7uc.fsf-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org>
2010-03-01 13:18 ` Luca Barbieri
[not found] ` <ff13bc9a1003010518s1fb4db5cj7ada2adc6d7e2604-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-01 21:42 ` Francisco Jerez
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.