All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 0/6] gst-plugins-bad dependencies fix v2
@ 2009-12-10 23:31 llandwerlin at gmail.com
  2009-12-10 23:31 ` [Buildroot] [PATCH 1/6] package: Added libcdaudio package (dependency of gst-plugins-bad) llandwerlin at gmail.com
                   ` (5 more replies)
  0 siblings, 6 replies; 14+ messages in thread
From: llandwerlin at gmail.com @ 2009-12-10 23:31 UTC (permalink / raw)
  To: buildroot

The following patches fix dependencies problems I had seen when
compiling the gst-plugins-bad package.

The thing is that the configure script did not raised any error on
missing librairies (libcdaudio, libdvdread, libdvdnav and openssl), I
just got error at compilation/link time (missing headers, missing
library at link). I guess there is something wrong with the check of
those packages (there are probably not using pkg-config), because they
are installed on my host system and detected when cross compiling.
Anyway, those patches still fix a real problem.

Here the patch list updated upon Peter's feedback :
[PATCH 1/6] package: Added libcdaudio package (dependency of gst-plugins-bad)
[PATCH 2/6] gst-plugins-bad: Fix dependency on libcdaudio
[PATCH 3/6] gst-plugins-bad: Fix dependency on openssl through the apexsink element
[PATCH 4/6] package: Added libdvdread package (dependency of gst-plugins-bad)
[PATCH 5/6] package: Added libdvdnav package (dependency of gst-plugins-bad)
[PATCH 6/6] gst-plugins-bad: Fix dependency on libdvdnav

--
Lionel Landwerlin

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/6] package: Added libcdaudio package (dependency of gst-plugins-bad)
  2009-12-10 23:31 [Buildroot] [PATCH 0/6] gst-plugins-bad dependencies fix v2 llandwerlin at gmail.com
@ 2009-12-10 23:31 ` llandwerlin at gmail.com
  2009-12-10 23:31 ` [Buildroot] [PATCH 2/6] gst-plugins-bad: Fix dependency on libcdaudio llandwerlin at gmail.com
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 14+ messages in thread
From: llandwerlin at gmail.com @ 2009-12-10 23:31 UTC (permalink / raw)
  To: buildroot

From: Lionel Landwerlin <llandwerlin@gmail.com>

Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
---
 package/multimedia/Config.in                |    1 +
 package/multimedia/libcdaudio/Config.in     |    8 ++++++++
 package/multimedia/libcdaudio/libcdaudio.mk |   13 +++++++++++++
 3 files changed, 22 insertions(+), 0 deletions(-)
 create mode 100644 package/multimedia/libcdaudio/Config.in
 create mode 100644 package/multimedia/libcdaudio/libcdaudio.mk

diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in
index 49932d0..7f60dcd 100644
--- a/package/multimedia/Config.in
+++ b/package/multimedia/Config.in
@@ -9,6 +9,7 @@ source "package/multimedia/gst-plugins-base/Config.in"
 source "package/multimedia/gst-plugins-good/Config.in"
 source "package/multimedia/gst-plugins-bad/Config.in"
 source "package/multimedia/gst-plugins-ugly/Config.in"
+source "package/multimedia/libcdaudio/Config.in"
 source "package/multimedia/libid3tag/Config.in"
 source "package/multimedia/libmad/Config.in"
 source "package/multimedia/libmms/Config.in"
diff --git a/package/multimedia/libcdaudio/Config.in b/package/multimedia/libcdaudio/Config.in
new file mode 100644
index 0000000..cb29ea8
--- /dev/null
+++ b/package/multimedia/libcdaudio/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LIBCDAUDIO
+	bool "libcdaudio"
+	help
+	  libcdaudio is a library designed to provide functions to
+	  control operation of a CD-ROM when playing audio CDs. It
+	  also contains functions for CDDB and CD Index lookup.
+
+          http://libcdaudio.sourceforge.net/
diff --git a/package/multimedia/libcdaudio/libcdaudio.mk b/package/multimedia/libcdaudio/libcdaudio.mk
new file mode 100644
index 0000000..a168562
--- /dev/null
+++ b/package/multimedia/libcdaudio/libcdaudio.mk
@@ -0,0 +1,13 @@
+#############################################################
+#
+# libcdaudio
+#
+#############################################################
+
+LIBCDAUDIO_VERSION = 0.99.12p2
+LIBCDAUDIO_SOURCE = libcdaudio-$(LIBCDAUDIO_VERSION).tar.gz
+LIBCDAUDIO_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/libcdaudio/libcdaudio/$(LIBCDAUDIO_VERSION)/
+LIBCDAUDIO_INSTALL_STAGING = YES
+LIBCDAUDIO_INSTALL_TARGET = YES
+
+$(eval $(call AUTOTARGETS,package/multimedia,libcdaudio))
-- 
1.6.5.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 2/6] gst-plugins-bad: Fix dependency on libcdaudio
  2009-12-10 23:31 [Buildroot] [PATCH 0/6] gst-plugins-bad dependencies fix v2 llandwerlin at gmail.com
  2009-12-10 23:31 ` [Buildroot] [PATCH 1/6] package: Added libcdaudio package (dependency of gst-plugins-bad) llandwerlin at gmail.com
@ 2009-12-10 23:31 ` llandwerlin at gmail.com
  2009-12-10 23:31 ` [Buildroot] [PATCH 3/6] gst-plugins-bad: Fix dependency on openssl through the apexsink element llandwerlin at gmail.com
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 14+ messages in thread
From: llandwerlin at gmail.com @ 2009-12-10 23:31 UTC (permalink / raw)
  To: buildroot

From: Lionel Landwerlin <llandwerlin@gmail.com>

Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
---
 package/multimedia/gst-plugins-bad/Config.in       |    4 ++++
 .../multimedia/gst-plugins-bad/gst-plugins-bad.mk  |    7 +++++++
 2 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/package/multimedia/gst-plugins-bad/Config.in b/package/multimedia/gst-plugins-bad/Config.in
index 8601cf4..6aebefd 100644
--- a/package/multimedia/gst-plugins-bad/Config.in
+++ b/package/multimedia/gst-plugins-bad/Config.in
@@ -33,6 +33,10 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_LEGACYRESAMPLE
 config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_BAYER
 	bool "bayer"
 
+config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_CDAUDIO
+	bool "cdaudio"
+	select BR2_PACKAGE_LIBCDAUDIO
+
 config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_CDXAPARSE
 	bool "cdxaparse"
 
diff --git a/package/multimedia/gst-plugins-bad/gst-plugins-bad.mk b/package/multimedia/gst-plugins-bad/gst-plugins-bad.mk
index c6c5fd0..282445e 100644
--- a/package/multimedia/gst-plugins-bad/gst-plugins-bad.mk
+++ b/package/multimedia/gst-plugins-bad/gst-plugins-bad.mk
@@ -63,6 +63,13 @@ else
 GST_PLUGINS_BAD_CONF_OPT += --disable-cdxaparse
 endif
 
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_CDAUDIO),y)
+GST_PLUGINS_BAD_CONF_OPT += --enable-cdaudio
+GST_PLUGINS_BAD_DEPENDENCIES += libcdaudio
+else
+GST_PLUGINS_BAD_CONF_OPT += --disable-cdaudio
+endif
+
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DCCP),y)
 GST_PLUGINS_BAD_CONF_OPT += --enable-dccp
 else
-- 
1.6.5.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 3/6] gst-plugins-bad: Fix dependency on openssl through the apexsink element
  2009-12-10 23:31 [Buildroot] [PATCH 0/6] gst-plugins-bad dependencies fix v2 llandwerlin at gmail.com
  2009-12-10 23:31 ` [Buildroot] [PATCH 1/6] package: Added libcdaudio package (dependency of gst-plugins-bad) llandwerlin at gmail.com
  2009-12-10 23:31 ` [Buildroot] [PATCH 2/6] gst-plugins-bad: Fix dependency on libcdaudio llandwerlin at gmail.com
@ 2009-12-10 23:31 ` llandwerlin at gmail.com
  2009-12-10 23:31 ` [Buildroot] [PATCH 4/6] package: Added libdvdread package (dependency of gst-plugins-bad) llandwerlin at gmail.com
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 14+ messages in thread
From: llandwerlin at gmail.com @ 2009-12-10 23:31 UTC (permalink / raw)
  To: buildroot

From: Lionel Landwerlin <llandwerlin@gmail.com>

Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
---
 package/multimedia/gst-plugins-bad/Config.in       |    4 ++++
 .../multimedia/gst-plugins-bad/gst-plugins-bad.mk  |    7 +++++++
 2 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/package/multimedia/gst-plugins-bad/Config.in b/package/multimedia/gst-plugins-bad/Config.in
index 6aebefd..3061822 100644
--- a/package/multimedia/gst-plugins-bad/Config.in
+++ b/package/multimedia/gst-plugins-bad/Config.in
@@ -21,6 +21,10 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_AIFFPARSE
 config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_AMRPARSE
 	bool "amrparse"
 
+config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_APEXSINK
+	bool "apexsink"
+	select BR2_PACKAGE_OPENSSL
+
 config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_AUTOCONVERT
 	bool "autoconvert"
 
diff --git a/package/multimedia/gst-plugins-bad/gst-plugins-bad.mk b/package/multimedia/gst-plugins-bad/gst-plugins-bad.mk
index 282445e..8c73bf0 100644
--- a/package/multimedia/gst-plugins-bad/gst-plugins-bad.mk
+++ b/package/multimedia/gst-plugins-bad/gst-plugins-bad.mk
@@ -33,6 +33,13 @@ else
 GST_PLUGINS_BAD_CONF_OPT += --disable-amrparse
 endif
 
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_APEXSINK),y)
+GST_PLUGINS_BAD_CONF_OPT += --enable-apexsink
+GST_PLUGINS_BAD_DEPENDENCIES += openssl
+else
+GST_PLUGINS_BAD_CONF_OPT += --disable-apexsink
+endif
+
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_AUTOCONVERT),y)
 GST_PLUGINS_BAD_CONF_OPT += --enable-autoconvert
 else
-- 
1.6.5.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 4/6] package: Added libdvdread package (dependency of gst-plugins-bad)
  2009-12-10 23:31 [Buildroot] [PATCH 0/6] gst-plugins-bad dependencies fix v2 llandwerlin at gmail.com
                   ` (2 preceding siblings ...)
  2009-12-10 23:31 ` [Buildroot] [PATCH 3/6] gst-plugins-bad: Fix dependency on openssl through the apexsink element llandwerlin at gmail.com
@ 2009-12-10 23:31 ` llandwerlin at gmail.com
  2009-12-12  2:23   ` Lionel Landwerlin
  2009-12-10 23:31 ` [Buildroot] [PATCH 5/6] package: Added libdvdnav " llandwerlin at gmail.com
  2009-12-10 23:31 ` [Buildroot] [PATCH 6/6] gst-plugins-bad: Fix dependency on libdvdnav llandwerlin at gmail.com
  5 siblings, 1 reply; 14+ messages in thread
From: llandwerlin at gmail.com @ 2009-12-10 23:31 UTC (permalink / raw)
  To: buildroot

From: Lionel Landwerlin <llandwerlin@gmail.com>

Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
---
 package/multimedia/Config.in                |    1 +
 package/multimedia/libdvdread/Config.in     |    7 +++++++
 package/multimedia/libdvdread/libdvdread.mk |   13 +++++++++++++
 3 files changed, 21 insertions(+), 0 deletions(-)
 create mode 100644 package/multimedia/libdvdread/Config.in
 create mode 100644 package/multimedia/libdvdread/libdvdread.mk

diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in
index 7f60dcd..cd07fdc 100644
--- a/package/multimedia/Config.in
+++ b/package/multimedia/Config.in
@@ -10,6 +10,7 @@ source "package/multimedia/gst-plugins-good/Config.in"
 source "package/multimedia/gst-plugins-bad/Config.in"
 source "package/multimedia/gst-plugins-ugly/Config.in"
 source "package/multimedia/libcdaudio/Config.in"
+source "package/multimedia/libdvdread/Config.in"
 source "package/multimedia/libid3tag/Config.in"
 source "package/multimedia/libmad/Config.in"
 source "package/multimedia/libmms/Config.in"
diff --git a/package/multimedia/libdvdread/Config.in b/package/multimedia/libdvdread/Config.in
new file mode 100644
index 0000000..892f25d
--- /dev/null
+++ b/package/multimedia/libdvdread/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBDVDREAD
+	bool "libdvdread"
+	help
+	  libdvdread provides a simple foundation for reading
+	  DVD-Video images.
+
+          http://www.mplayerhq.hu
diff --git a/package/multimedia/libdvdread/libdvdread.mk b/package/multimedia/libdvdread/libdvdread.mk
new file mode 100644
index 0000000..f28c8ac
--- /dev/null
+++ b/package/multimedia/libdvdread/libdvdread.mk
@@ -0,0 +1,13 @@
+#############################################################
+#
+# libdvdread
+#
+#############################################################
+
+LIBDVDREAD_VERSION = 4.1.3
+LIBDVDREAD_SOURCE = libdvdread_$(LIBDVDREAD_VERSION).orig.tar.gz
+LIBDVDREAD_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/libd/libdvdread/
+LIBDVDREAD_INSTALL_STAGING = YES
+LIBDVDREAD_INSTALL_TARGET = YES
+
+$(eval $(call AUTOTARGETS,package/multimedia,libdvdread))
-- 
1.6.5.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 5/6] package: Added libdvdnav package (dependency of gst-plugins-bad)
  2009-12-10 23:31 [Buildroot] [PATCH 0/6] gst-plugins-bad dependencies fix v2 llandwerlin at gmail.com
                   ` (3 preceding siblings ...)
  2009-12-10 23:31 ` [Buildroot] [PATCH 4/6] package: Added libdvdread package (dependency of gst-plugins-bad) llandwerlin at gmail.com
@ 2009-12-10 23:31 ` llandwerlin at gmail.com
  2009-12-11 22:07   ` Peter Korsgaard
  2009-12-10 23:31 ` [Buildroot] [PATCH 6/6] gst-plugins-bad: Fix dependency on libdvdnav llandwerlin at gmail.com
  5 siblings, 1 reply; 14+ messages in thread
From: llandwerlin at gmail.com @ 2009-12-10 23:31 UTC (permalink / raw)
  To: buildroot

From: Lionel Landwerlin <llandwerlin@gmail.com>

Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
---
 package/multimedia/Config.in              |    1 +
 package/multimedia/libdvdnav/Config.in    |    9 +++++++++
 package/multimedia/libdvdnav/libdvdnav.mk |   19 +++++++++++++++++++
 3 files changed, 29 insertions(+), 0 deletions(-)
 create mode 100644 package/multimedia/libdvdnav/Config.in
 create mode 100644 package/multimedia/libdvdnav/libdvdnav.mk

diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in
index cd07fdc..1958e2a 100644
--- a/package/multimedia/Config.in
+++ b/package/multimedia/Config.in
@@ -11,6 +11,7 @@ source "package/multimedia/gst-plugins-bad/Config.in"
 source "package/multimedia/gst-plugins-ugly/Config.in"
 source "package/multimedia/libcdaudio/Config.in"
 source "package/multimedia/libdvdread/Config.in"
+source "package/multimedia/libdvdnav/Config.in"
 source "package/multimedia/libid3tag/Config.in"
 source "package/multimedia/libmad/Config.in"
 source "package/multimedia/libmms/Config.in"
diff --git a/package/multimedia/libdvdnav/Config.in b/package/multimedia/libdvdnav/Config.in
new file mode 100644
index 0000000..07381fa
--- /dev/null
+++ b/package/multimedia/libdvdnav/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_LIBDVDNAV
+	bool "libdvdnav"
+        select BR2_PACKAGE_LIBDVDREAD
+	help
+	  libdvdnav is a library that allows easy use of sophisticated
+	  DVD navigation features such as DVD menus, multiangle
+	  playback and even interactive DVD games.
+
+          http://www.mplayerhq.hu
diff --git a/package/multimedia/libdvdnav/libdvdnav.mk b/package/multimedia/libdvdnav/libdvdnav.mk
new file mode 100644
index 0000000..7ecfbc0
--- /dev/null
+++ b/package/multimedia/libdvdnav/libdvdnav.mk
@@ -0,0 +1,19 @@
+#############################################################
+#
+# libdvdnav
+#
+#############################################################
+
+LIBDVDNAV_VERSION = 4.1.3
+LIBDVDNAV_SOURCE = libdvdnav_$(LIBDVDNAV_VERSION).orig.tar.gz
+LIBDVDNAV_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/libd/libdvdnav/
+LIBDVDNAV_INSTALL_STAGING = YES
+LIBDVDNAV_INSTALL_TARGET = YES
+
+LIBDVDNAV_DEPENDENCIES = libdvdread
+
+# By default libdvdnav tries to find dvdread-config in $PATH. Because
+# of cross compilation, we prefer using pkg-config.
+LIBDVDNAV_CONF_OPT = --with-dvdread-config="$(PKG_CONFIG_HOST_BINARY) dvdread"
+
+$(eval $(call AUTOTARGETS,package/multimedia,libdvdnav))
-- 
1.6.5.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 6/6] gst-plugins-bad: Fix dependency on libdvdnav
  2009-12-10 23:31 [Buildroot] [PATCH 0/6] gst-plugins-bad dependencies fix v2 llandwerlin at gmail.com
                   ` (4 preceding siblings ...)
  2009-12-10 23:31 ` [Buildroot] [PATCH 5/6] package: Added libdvdnav " llandwerlin at gmail.com
@ 2009-12-10 23:31 ` llandwerlin at gmail.com
  5 siblings, 0 replies; 14+ messages in thread
From: llandwerlin at gmail.com @ 2009-12-10 23:31 UTC (permalink / raw)
  To: buildroot

From: Lionel Landwerlin <llandwerlin@gmail.com>

Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
---
 package/multimedia/gst-plugins-bad/Config.in       |    4 ++++
 .../multimedia/gst-plugins-bad/gst-plugins-bad.mk  |    7 +++++++
 2 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/package/multimedia/gst-plugins-bad/Config.in b/package/multimedia/gst-plugins-bad/Config.in
index 3061822..132a770 100644
--- a/package/multimedia/gst-plugins-bad/Config.in
+++ b/package/multimedia/gst-plugins-bad/Config.in
@@ -53,6 +53,10 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DEBUGUTILS
 config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DTMF
 	bool "dtmf"
 
+config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDNAV
+	bool "dvdnav"
+        select BR2_PACKAGE_LIBDVDNAV
+
 config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDSPU
 	bool "dvdspu"
 
diff --git a/package/multimedia/gst-plugins-bad/gst-plugins-bad.mk b/package/multimedia/gst-plugins-bad/gst-plugins-bad.mk
index 8c73bf0..10cd226 100644
--- a/package/multimedia/gst-plugins-bad/gst-plugins-bad.mk
+++ b/package/multimedia/gst-plugins-bad/gst-plugins-bad.mk
@@ -95,6 +95,13 @@ else
 GST_PLUGINS_BAD_CONF_OPT += --disable-dtmf
 endif
 
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDNAV),y)
+GST_PLUGINS_BAD_CONF_OPT += --enable-dvdnav
+GST_PLUGINS_BAD_DEPENDENCIES += libdvdnav
+else
+GST_PLUGINS_BAD_CONF_OPT += --disable-dvdnav
+endif
+
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDSPU),y)
 GST_PLUGINS_BAD_CONF_OPT += --enable-dvdspu
 else
-- 
1.6.5.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 5/6] package: Added libdvdnav package (dependency of gst-plugins-bad)
  2009-12-10 23:31 ` [Buildroot] [PATCH 5/6] package: Added libdvdnav " llandwerlin at gmail.com
@ 2009-12-11 22:07   ` Peter Korsgaard
  2009-12-12  2:22     ` Lionel Landwerlin
  0 siblings, 1 reply; 14+ messages in thread
From: Peter Korsgaard @ 2009-12-11 22:07 UTC (permalink / raw)
  To: buildroot

>>>>> "Lionel" == llandwerlin  <llandwerlin@gmail.com> writes:

 Lionel> From: Lionel Landwerlin <llandwerlin@gmail.com>
 Lionel> Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>

Hmm, this seems pretty broken - Does it really build for you?
First of all, there's no configure script in the tarball. There is a
configure2 script, and adding a symlink gets us to the build step where
it dies trying to find the libdvdread headers:

make[1]: Entering directory `/tmp/br/build/libdvdnav-4.1.3'
sh "/tmp/br/build/libdvdnav-4.1.3"/version.sh "/tmp/br/build/libdvdnav-4.1.3" "4.1.3"
cd obj && gcc -fPIC -DPIC -MD -O3  -g -Wall -funsigned-char -I/tmp/br/build/libdvdnav-4.1.3 -I"/tmp/br/build/libdvdnav-4.1.3"/src -I"/tmp/br/build/libdvdnav-4.1.3"/src/vm -DDVDNAV_COMPILE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -DHAVE_CONFIG_H -DHAVE_DLFCN_H  -c -o dvdnav.so /tmp/br/build/libdvdnav-4.1.3/src/dvdnav.c
/tmp/br/build/libdvdnav-4.1.3/src/dvdnav.c:40:32: error: dvdread/dvd_reader.h: No such file or directory

Also notice that it uses the host compiler.

 Lionel> +config BR2_PACKAGE_LIBDVDNAV
 Lionel> +	bool "libdvdnav"
 Lionel> +        select BR2_PACKAGE_LIBDVDREAD
 Lionel> +	help
 Lionel> +	  libdvdnav is a library that allows easy use of sophisticated
 Lionel> +	  DVD navigation features such as DVD menus, multiangle
 Lionel> +	  playback and even interactive DVD games.
 Lionel> +
 Lionel> +          http://www.mplayerhq.hu

Indentation is off here.

 Lionel> +++ b/package/multimedia/libdvdnav/libdvdnav.mk
 Lionel> @@ -0,0 +1,19 @@
 Lionel> +#############################################################
 Lionel> +#
 Lionel> +# libdvdnav
 Lionel> +#
 Lionel> +#############################################################
 Lionel> +
 Lionel> +LIBDVDNAV_VERSION = 4.1.3
 Lionel> +LIBDVDNAV_SOURCE = libdvdnav_$(LIBDVDNAV_VERSION).orig.tar.gz
 Lionel> +LIBDVDNAV_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/libd/libdvdnav/

The official upstream location is afaik
http://www.mplayerhq.hu/MPlayer/releases/dvdnav/

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 5/6] package: Added libdvdnav package (dependency of gst-plugins-bad)
  2009-12-11 22:07   ` Peter Korsgaard
@ 2009-12-12  2:22     ` Lionel Landwerlin
  2009-12-12  7:55       ` Peter Korsgaard
  0 siblings, 1 reply; 14+ messages in thread
From: Lionel Landwerlin @ 2009-12-12  2:22 UTC (permalink / raw)
  To: buildroot

Le vendredi 11 d?cembre 2009 ? 23:07 +0100, Peter Korsgaard a ?crit :
> >>>>> "Lionel" == llandwerlin  <llandwerlin@gmail.com> writes:
> 
>  Lionel> From: Lionel Landwerlin <llandwerlin@gmail.com>
>  Lionel> Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
> 
> Hmm, this seems pretty broken - Does it really build for you?
> First of all, there's no configure script in the tarball. There is a
> configure2 script, and adding a symlink gets us to the build step where
> it dies trying to find the libdvdread headers:
> 
> make[1]: Entering directory `/tmp/br/build/libdvdnav-4.1.3'
> sh "/tmp/br/build/libdvdnav-4.1.3"/version.sh "/tmp/br/build/libdvdnav-4.1.3" "4.1.3"
> cd obj && gcc -fPIC -DPIC -MD -O3  -g -Wall -funsigned-char -I/tmp/br/build/libdvdnav-4.1.3 -I"/tmp/br/build/libdvdnav-4.1.3"/src -I"/tmp/br/build/libdvdnav-4.1.3"/src/vm -DDVDNAV_COMPILE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -DHAVE_CONFIG_H -DHAVE_DLFCN_H  -c -o dvdnav.so /tmp/br/build/libdvdnav-4.1.3/src/dvdnav.c
> /tmp/br/build/libdvdnav-4.1.3/src/dvdnav.c:40:32: error: dvdread/dvd_reader.h: No such file or directory
> 
> Also notice that it uses the host compiler.

Arg...

I'm sorry, I removed the AUTORECONF option...
I used to set autoreconf & libtool patching by default on almost every
package I compiled otherwise it broke compilation with my cross sh4
toolchain.

When rebasing my patchs I removed them all, forgetting this was usefull
for libdvdread & libdvdnav packages...

Please find a corrected patch as attachment.

> 
>  Lionel> +config BR2_PACKAGE_LIBDVDNAV
>  Lionel> +	bool "libdvdnav"
>  Lionel> +        select BR2_PACKAGE_LIBDVDREAD
>  Lionel> +	help
>  Lionel> +	  libdvdnav is a library that allows easy use of sophisticated
>  Lionel> +	  DVD navigation features such as DVD menus, multiangle
>  Lionel> +	  playback and even interactive DVD games.
>  Lionel> +
>  Lionel> +          http://www.mplayerhq.hu
> 
> Indentation is off here.
> 
>  Lionel> +++ b/package/multimedia/libdvdnav/libdvdnav.mk
>  Lionel> @@ -0,0 +1,19 @@
>  Lionel> +#############################################################
>  Lionel> +#
>  Lionel> +# libdvdnav
>  Lionel> +#
>  Lionel> +#############################################################
>  Lionel> +
>  Lionel> +LIBDVDNAV_VERSION = 4.1.3
>  Lionel> +LIBDVDNAV_SOURCE = libdvdnav_$(LIBDVDNAV_VERSION).orig.tar.gz
>  Lionel> +LIBDVDNAV_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/libd/libdvdnav/
> 
> The official upstream location is afaik
> http://www.mplayerhq.hu/MPlayer/releases/dvdnav/
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-package-Added-libdvdnav-package-dependency-of-gst-pl.patch
Type: text/x-patch
Size: 2690 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20091212/498f4815/attachment.bin>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 4/6] package: Added libdvdread package (dependency of gst-plugins-bad)
  2009-12-10 23:31 ` [Buildroot] [PATCH 4/6] package: Added libdvdread package (dependency of gst-plugins-bad) llandwerlin at gmail.com
@ 2009-12-12  2:23   ` Lionel Landwerlin
  2009-12-12  8:02     ` Peter Korsgaard
  0 siblings, 1 reply; 14+ messages in thread
From: Lionel Landwerlin @ 2009-12-12  2:23 UTC (permalink / raw)
  To: buildroot

Le vendredi 11 d?cembre 2009 ? 00:31 +0100, llandwerlin at gmail.com a
?crit :
> From: Lionel Landwerlin <llandwerlin@gmail.com>
> 
> Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
> ---
>  package/multimedia/Config.in                |    1 +
>  package/multimedia/libdvdread/Config.in     |    7 +++++++
>  package/multimedia/libdvdread/libdvdread.mk |   13 +++++++++++++
>  3 files changed, 21 insertions(+), 0 deletions(-)
>  create mode 100644 package/multimedia/libdvdread/Config.in
>  create mode 100644 package/multimedia/libdvdread/libdvdread.mk
> 
> diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in
> index 7f60dcd..cd07fdc 100644

> +
> +LIBDVDREAD_VERSION = 4.1.3
> +LIBDVDREAD_SOURCE = libdvdread_$(LIBDVDREAD_VERSION).orig.tar.gz
> +LIBDVDREAD_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/libd/libdvdread/
> +LIBDVDREAD_INSTALL_STAGING = YES
> +LIBDVDREAD_INSTALL_TARGET = YES
> +
> +$(eval $(call AUTOTARGETS,package/multimedia,libdvdread))

This one was broken too...

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-package-Added-libdvdread-package-dependency-of-gst-p.patch
Type: text/x-patch
Size: 2364 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20091212/32055ee0/attachment.bin>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 5/6] package: Added libdvdnav package (dependency of gst-plugins-bad)
  2009-12-12  2:22     ` Lionel Landwerlin
@ 2009-12-12  7:55       ` Peter Korsgaard
  0 siblings, 0 replies; 14+ messages in thread
From: Peter Korsgaard @ 2009-12-12  7:55 UTC (permalink / raw)
  To: buildroot

>>>>> "Lionel" == Lionel Landwerlin <llandwerlin@gmail.com> writes:

Hi,

 Lionel> I'm sorry, I removed the AUTORECONF option...
 Lionel> I used to set autoreconf & libtool patching by default on
 Lionel> almost every package I compiled otherwise it broke compilation
 Lionel> with my cross sh4 toolchain.

 Lionel> When rebasing my patchs I removed them all, forgetting this was
 Lionel> usefull for libdvdread & libdvdnav packages...

 Lionel> Please find a corrected patch as attachment.

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 4/6] package: Added libdvdread package (dependency of gst-plugins-bad)
  2009-12-12  2:23   ` Lionel Landwerlin
@ 2009-12-12  8:02     ` Peter Korsgaard
  2009-12-12 12:30       ` Lionel Landwerlin
  0 siblings, 1 reply; 14+ messages in thread
From: Peter Korsgaard @ 2009-12-12  8:02 UTC (permalink / raw)
  To: buildroot

>>>>> "Lionel" == Lionel Landwerlin <llandwerlin@gmail.com> writes:

 Lionel> This one was broken too...

It was? It built ok here. From what I can see, the only difference
between what I committed and this (besides the upstream URL) is that you
now turned off the libtool patching - Why?

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 4/6] package: Added libdvdread package (dependency of gst-plugins-bad)
  2009-12-12  8:02     ` Peter Korsgaard
@ 2009-12-12 12:30       ` Lionel Landwerlin
  2009-12-12 13:35         ` Peter Korsgaard
  0 siblings, 1 reply; 14+ messages in thread
From: Lionel Landwerlin @ 2009-12-12 12:30 UTC (permalink / raw)
  To: buildroot

Le samedi 12 d?cembre 2009 ? 09:02 +0100, Peter Korsgaard a ?crit :
> >>>>> "Lionel" == Lionel Landwerlin <llandwerlin@gmail.com> writes:
> 
>  Lionel> This one was broken too...
> 
> It was? It built ok here. From what I can see, the only difference
> between what I committed and this (besides the upstream URL) is that you
> now turned off the libtool patching - Why?
> 

There 3 versions of the patch :

- the first one, you had committed and which works, even if the libtool
patch is probably useless.
- the second, which is broken because the autoreconf & libtool was
removed.
- the third, which only use autoreconf and which works.

I said the second was broken, but you probably haven't tested it,
because you already committed the first.

Thx a lot for your patience.

-- 
Lionel Landwerlin

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 4/6] package: Added libdvdread package (dependency of gst-plugins-bad)
  2009-12-12 12:30       ` Lionel Landwerlin
@ 2009-12-12 13:35         ` Peter Korsgaard
  0 siblings, 0 replies; 14+ messages in thread
From: Peter Korsgaard @ 2009-12-12 13:35 UTC (permalink / raw)
  To: buildroot

>>>>> "Lionel" == Lionel Landwerlin <llandwerlin@gmail.com> writes:

Hi,

 Lionel> Thx a lot for your patience.

You too.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2009-12-12 13:35 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-10 23:31 [Buildroot] [PATCH 0/6] gst-plugins-bad dependencies fix v2 llandwerlin at gmail.com
2009-12-10 23:31 ` [Buildroot] [PATCH 1/6] package: Added libcdaudio package (dependency of gst-plugins-bad) llandwerlin at gmail.com
2009-12-10 23:31 ` [Buildroot] [PATCH 2/6] gst-plugins-bad: Fix dependency on libcdaudio llandwerlin at gmail.com
2009-12-10 23:31 ` [Buildroot] [PATCH 3/6] gst-plugins-bad: Fix dependency on openssl through the apexsink element llandwerlin at gmail.com
2009-12-10 23:31 ` [Buildroot] [PATCH 4/6] package: Added libdvdread package (dependency of gst-plugins-bad) llandwerlin at gmail.com
2009-12-12  2:23   ` Lionel Landwerlin
2009-12-12  8:02     ` Peter Korsgaard
2009-12-12 12:30       ` Lionel Landwerlin
2009-12-12 13:35         ` Peter Korsgaard
2009-12-10 23:31 ` [Buildroot] [PATCH 5/6] package: Added libdvdnav " llandwerlin at gmail.com
2009-12-11 22:07   ` Peter Korsgaard
2009-12-12  2:22     ` Lionel Landwerlin
2009-12-12  7:55       ` Peter Korsgaard
2009-12-10 23:31 ` [Buildroot] [PATCH 6/6] gst-plugins-bad: Fix dependency on libdvdnav llandwerlin at gmail.com

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.