Re: [Qemu-devel] [7118] linux-user: prefer glibc over direct syscalls

[Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>]

Laurent Desnogues <laurent.desnogues@gmail.com> writes:

Hi,

>> +#ifdef TARGET_NR_utimensat
>> +static int sys_utimensat(int dirfd, const char *pathname,
>> +    const struct timespec times[2], int flags)
>> +{
>> +  return (utimensat(dirfd, pathname, times, flags));
>> +}
>> +#endif
>
> Just to point that my system has all *at functions except for utimensat.
> This breaks compilation.  Shouldn't all *at functions be tested in the
> configure script?

This utimensat change is broken, I've sent a patch to revert to the
syscall interface. As a side effect, it'll bring back the check :

#if defined(TARGET_NR_utimensat) && defined(__NR_utimensat)

It will likely solve your trouble. Lets hope the patch will be merged :)

>
> For the record I am running CentOS 5.3 x86_64.

hmm... glibc older than 2.6 or kernel older than 2.6.22 ?

Arnaud