From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Do not mess with libc's prototypes
Date: Wed, 13 Aug 2008 12:21:07 +0200 [thread overview]
Message-ID: <87wsil8bcc.fsf@xs4all.nl> (raw)
In-Reply-To: <35247.89.103.133.237.1218178352.squirrel@mail.netbsd.sk> (lkundrak@v3.sk's message of "Fri, 8 Aug 2008 02:52:32 -0400 (EDT)")
lkundrak@v3.sk writes:
> Due to some more breakage, here's some more patch:
>
> According to POSIX memmove and memcpy can actually be macros or whatever
> (IIRC). We'd better not play with those in code that uses libc's headers
> and is to be linked with libc.
>
> 2008-08-08 Lubomir Rintel <lkundrak@fedoraproject.org>
>
> * include/grub/misc.h: Surround memmove and memcpy prototypes with
> #ifndef GRUB_UTIL
> * kern/misc.c: Surround memmove, memcpy and memset prototypes with
> #ifndef GRUB_UTIL
This is not for GRUB_UTIL, so please don't do this. Perhaps your
problem can be fixed in another way. IIRC, this was added because on
the PPC, memcpy was required by libgcc, which is used there...
--
Marco
prev parent reply other threads:[~2008-08-13 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 20:42 [PATCH] Do not mess with libc's prototypes lkundrak
2008-08-08 6:52 ` lkundrak
2008-08-13 10:21 ` Marco Gerards [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wsil8bcc.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.