From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] skip over invalid BSD partitions
Date: Tue, 05 Aug 2008 17:41:07 +0200 [thread overview]
Message-ID: <87wsivcvvw.fsf@xs4all.nl> (raw)
In-Reply-To: <1217942346.20134.1.camel@fz.local> (Felix Zielcke's message of "Tue, 05 Aug 2008 15:19:06 +0200")
Felix Zielcke <fzielcke@z-51.de> writes:
> Am Dienstag, den 05.08.2008, 15:10 +0200 schrieb Marco Gerards:
>> Felix Zielcke <fzielcke87@googlemail.com> writes:
>>
>> > 2008-08-05 Felix Zielcke <fzielcke@z-51.de>
>> >
>> > * partmap/pc.c (pc_partition_map_iterate): Do not abort on an invalid BSD
>> > magic or if there's no space left, use grub_dprintf to issue a warning.
>>
>> Looks fine.
> Hurray.
>
>> > + {
>> > + grub_dprintf ("partition",
>> > + "invalid disk label magic 0x%x on partition %d\n"
>> > + label.magic, p.index);
>> > + continue;
>> > + }
>>
>> Isn't a comma missing after the second string? I am surprised that
>> this compiles. Or am I missing something?
>>
> You're right, shame on me I notice to missing spaces but not a missing
> comma.
> Attached.
Seems fine to me :-)
--
Marco
prev parent reply other threads:[~2008-08-05 15:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 23:19 [PATCH] skip over invalid BSD partitions Felix Zielcke
2008-08-01 10:40 ` Marco Gerards
2008-08-01 10:48 ` Felix Zielcke
2008-08-01 13:02 ` Robert Millan
2008-08-05 10:16 ` Marco Gerards
2008-08-05 10:49 ` Felix Zielcke
2008-08-05 11:38 ` Felix Zielcke
2008-08-05 13:10 ` Marco Gerards
2008-08-05 13:15 ` Felix Zielcke
2008-08-05 13:19 ` Felix Zielcke
2008-08-05 15:41 ` Marco Gerards [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wsivcvvw.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.