From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] skip over invalid BSD partitions
Date: Fri, 1 Aug 2008 15:02:22 +0200 [thread overview]
Message-ID: <20080801130222.GA12405@thorin> (raw)
In-Reply-To: <877ib1hvce.fsf@xs4all.nl>
On Fri, Aug 01, 2008 at 12:40:17PM +0200, Marco Gerards wrote:
> > - return grub_error (GRUB_ERR_BAD_PART_TABLE,
> > - "no space for disk label");
> > -
> > + {
> > + grub_error (GRUB_ERR_BAD_PART_TABLE,
> > + "no space for disk label");
> > + continue;
> > + }
>
> If you continue as no error occured, why do you throw an error?
Uhm nobody's going to handle this error. The caller will simply see that
some partitions are not processed.
How about using grub_dprintf instead?
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2008-08-01 13:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 23:19 [PATCH] skip over invalid BSD partitions Felix Zielcke
2008-08-01 10:40 ` Marco Gerards
2008-08-01 10:48 ` Felix Zielcke
2008-08-01 13:02 ` Robert Millan [this message]
2008-08-05 10:16 ` Marco Gerards
2008-08-05 10:49 ` Felix Zielcke
2008-08-05 11:38 ` Felix Zielcke
2008-08-05 13:10 ` Marco Gerards
2008-08-05 13:15 ` Felix Zielcke
2008-08-05 13:19 ` Felix Zielcke
2008-08-05 15:41 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080801130222.GA12405@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.