Re: [PATCH] Misc patches for grub2

[Marco Gerards <mgerards@xs4all.nl>]

Hi,

Bean <bean123ch@gmail.com> writes:

> This is a collection of miscellaneous patches, it includes:

Please do not collect patches.  Independant changes can better go into
independant patches.  Mails like this are easily overseen and so are
important changes made by such patch.

> 1, move util/envblk.c to lib/envblk.c
>
> As envblk.c is used by module loadenv and tool grub-editenv, I think
> it's better to move it to lib directory.


For some reason I have some doubts about lib/.  But I do not have a
better name in mind either.  What does belong in there?  Do you happen
to have other names in mind as a suggestion? :-)

> 2. seperate hexdump function, and move it to lib/hexdump.c
>
> hexdump module consists of two parts, one is hexdump function, the
> other is user land command. I move the hexdump function to lib, as
> it's also used in other place, for example grub-fstest.

Same here :-)

> 3. add new command crc
>
> Just like hexdump, this module is split into two parts, lib/crc.c for
> the crc function, commands/crc.c for the user land command that
> calculate the crc checksum of selected file.

If it is for users, it should go into util/

When and how is it used?

> 4. rename appleloader command to bootcamp
>
> The name appleloader may be a little confusing, bootcamp seems to be a
> better choice.

How about legacyloader or even legacy?  Isn't that what it does
without actually using possibly trademarked names people are afraid of
using?

--
Marco