From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] use of grub_dprintf in grub_mm_init_region() is misleading
Date: Wed, 23 Jan 2008 14:53:58 +0100 [thread overview]
Message-ID: <87wsq0odft.fsf@xs4all.nl> (raw)
In-Reply-To: <20080123131855.GA29373@thorin> (Robert Millan's message of "Wed, 23 Jan 2008 14:18:55 +0100")
Robert Millan <rmh@aybabtu.com> writes:
> Using grub_dprintf() in grub_mm_init_region() easily leads to think that one
> can activate this debug message by issuing `grub_env_set ("debug", "mem")' in
> grub_machine_init(), before memory initialisation.
>
> However, that's completely false. grub_env_set will silently [1] ignore your
> call because grub_malloc() ain't usable, possibly making you think for a while
> that no free memory was found, and that memory was not initialized at all!
>
> I propose turning it into a disabled grub_printf().
Fine for me.
--
Marco
prev parent reply other threads:[~2008-01-23 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 13:18 [PATCH] use of grub_dprintf in grub_mm_init_region() is misleading Robert Millan
2008-01-23 13:53 ` Marco Gerards [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wsq0odft.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.