All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: mtdswap: remove debugfs stats file on teardown
Date: Mon, 22 Jun 2026 11:19:14 +0200	[thread overview]
Message-ID: <87y0g72ar1.fsf@bootlin.com> (raw)
In-Reply-To: <20260615090850.80659-1-pengpeng@iscas.ac.cn> (Pengpeng Hou's message of "Mon, 15 Jun 2026 17:08:50 +0800")

Hello,

> @@ -1463,6 +1465,8 @@ static void mtdswap_remove_dev(struct mtd_blktrans_dev *dev)
>  {
>  	struct mtdswap_dev *d = MTDSWAP_MBD_TO_MTDSWAP(dev);
>  
> +	if (!IS_ERR_OR_NULL(d->debugfs_stats))
> +		debugfs_remove(d->debugfs_stats);

Please check debugfs_remove() implementation, the 'if' condition
is already handled and therefore does not need to be done here.

Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: mtdswap: remove debugfs stats file on teardown
Date: Mon, 22 Jun 2026 11:19:14 +0200	[thread overview]
Message-ID: <87y0g72ar1.fsf@bootlin.com> (raw)
In-Reply-To: <20260615090850.80659-1-pengpeng@iscas.ac.cn> (Pengpeng Hou's message of "Mon, 15 Jun 2026 17:08:50 +0800")

Hello,

> @@ -1463,6 +1465,8 @@ static void mtdswap_remove_dev(struct mtd_blktrans_dev *dev)
>  {
>  	struct mtdswap_dev *d = MTDSWAP_MBD_TO_MTDSWAP(dev);
>  
> +	if (!IS_ERR_OR_NULL(d->debugfs_stats))
> +		debugfs_remove(d->debugfs_stats);

Please check debugfs_remove() implementation, the 'if' condition
is already handled and therefore does not need to be done here.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2026-06-22  9:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15  9:08 [PATCH] mtd: mtdswap: remove debugfs stats file on teardown Pengpeng Hou
2026-06-15  9:08 ` Pengpeng Hou
2026-06-22  9:19 ` Miquel Raynal [this message]
2026-06-22  9:19   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0g72ar1.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=pengpeng@iscas.ac.cn \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.