[PATCH 1/1] boot: let BOOTSTAGE_RECORD_COUNT default to 50

[PATCH 1/1] boot: let BOOTSTAGE_RECORD_COUNT default to 50

[Heinrich Schuchardt]

BOOTSTAGE_RECORD_COUNT=30 is too small to record booting a FIT image
with EFI kernel, initrd, dtb as seen on the StarFive VisionFive 2
board.

Increase the default for BOOTSTAGE_RECORD_COUNT to 50.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 boot/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/boot/Kconfig b/boot/Kconfig
index fb37d912bc9..2456856a572 100644
--- a/boot/Kconfig
+++ b/boot/Kconfig
@@ -1170,7 +1170,7 @@ config BOOTSTAGE_REPORT
 config BOOTSTAGE_RECORD_COUNT
 	int "Number of boot stage records to store"
 	depends on BOOTSTAGE
-	default 30
+	default 50
 	help
 	  This is the size of the bootstage record list and is the maximum
 	  number of bootstage records that can be recorded.
-- 
2.48.1

Re: [PATCH 1/1] boot: let BOOTSTAGE_RECORD_COUNT default to 50

[Heinrich Schuchardt]

On 30.04.25 09:34, Heinrich Schuchardt wrote:
> BOOTSTAGE_RECORD_COUNT=30 is too small to record booting a FIT image
> with EFI kernel, initrd, dtb as seen on the StarFive VisionFive 2
> board.
> 
> Increase the default for BOOTSTAGE_RECORD_COUNT to 50.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>   boot/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/boot/Kconfig b/boot/Kconfig
> index fb37d912bc9..2456856a572 100644
> --- a/boot/Kconfig
> +++ b/boot/Kconfig
> @@ -1170,7 +1170,7 @@ config BOOTSTAGE_REPORT
>   config BOOTSTAGE_RECORD_COUNT
>   	int "Number of boot stage records to store"
>   	depends on BOOTSTAGE
> -	default 30
> +	default 50
>   	help
>   	  This is the size of the bootstage record list and is the maximum
>   	  number of bootstage records that can be recorded.


Here is a bootstage report for the board:

StarFive # bootstage report
Timer summary in microseconds (40 records):
        Mark    Elapsed  Stage
           0          0  reset
   3,181,398  3,181,398  board_init_f
   3,229,302     47,904  board_init_r
   4,182,564    953,262  eth_common_init
   4,276,615     94,051  eth_initialize
   4,280,818      4,203  main_loop
   4,380,713     99,895  usb_start
   5,684,111  1,303,398  cli_loop
  56,443,312 50,759,201  bootm_start
  56,443,313          1  boot_get_kernel
  56,448,158      4,845  fit_image_load
  56,448,186         28  fit_image_load
  56,448,187          1  fit_image_load
  56,451,971      3,784  fit_image_load
  56,483,951     31,980  fit_image_load
  56,483,956          5  fit_image_load
  56,483,984         28  fit_image_load
  56,484,001         17  fit_image_load
  56,484,008          7  fit_image_load
  56,488,891      4,883  fit_image_load
  56,488,918         27  fit_image_load
  56,488,919          1  fit_image_load
  56,524,164     35,245  fit_image_load
  56,524,170          6  fit_image_load
  56,524,201         31  fit_image_load
  56,524,216         15  fit_image_load
  56,528,502      4,286  fit_image_load
  56,533,091      4,589  fit_image_load
  56,533,118         27  fit_image_load
  56,533,119          1  fit_image_load
  56,562,211     29,092  fit_image_load
  56,562,216          5  fit_image_load
  56,562,219          3  fit_image_load
  56,562,232         13  fit_image_load
  56,566,246      4,014  fit_image_load
  56,575,882      9,636  bootm_load_os
  56,575,893         11  boot_ramdisk_high
  56,585,438      9,545  do_bootm_efi

Accumulated time:
                 14,772  dm_f
                 88,688  dm_r

Re: [PATCH 1/1] boot: let BOOTSTAGE_RECORD_COUNT default to 50

[Simon Glass]

On Wed, 30 Apr 2025 at 02:32, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> On 30.04.25 09:34, Heinrich Schuchardt wrote:
> > BOOTSTAGE_RECORD_COUNT=30 is too small to record booting a FIT image
> > with EFI kernel, initrd, dtb as seen on the StarFive VisionFive 2
> > board.
> >
> > Increase the default for BOOTSTAGE_RECORD_COUNT to 50.
> >
> > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> > ---
> >   boot/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >

Reviewed-by: Simon Glass <sjg@chromium.org>

There is some opportunity to reduce the size of struct
bootstage_record on 64-bit machines if you like, but we don't lack for
memory these days, only code space.

Regards,
Simon

Re: [PATCH 1/1] boot: let BOOTSTAGE_RECORD_COUNT default to 50

[Mattijs Korpershoek]

Hi Heinrich,

Thank you for the patch.

On mer., avril 30, 2025 at 09:34, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote:

> BOOTSTAGE_RECORD_COUNT=30 is too small to record booting a FIT image
> with EFI kernel, initrd, dtb as seen on the StarFive VisionFive 2
> board.
>
> Increase the default for BOOTSTAGE_RECORD_COUNT to 50.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
>  boot/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/boot/Kconfig b/boot/Kconfig
> index fb37d912bc9..2456856a572 100644
> --- a/boot/Kconfig
> +++ b/boot/Kconfig
> @@ -1170,7 +1170,7 @@ config BOOTSTAGE_REPORT
>  config BOOTSTAGE_RECORD_COUNT
>  	int "Number of boot stage records to store"
>  	depends on BOOTSTAGE
> -	default 30
> +	default 50
>  	help
>  	  This is the size of the bootstage record list and is the maximum
>  	  number of bootstage records that can be recorded.
> -- 
> 2.48.1

Re: [PATCH 1/1] boot: let BOOTSTAGE_RECORD_COUNT default to 50

[Ilias Apalodimas]

On Wed, 30 Apr 2025 at 10:34, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> BOOTSTAGE_RECORD_COUNT=30 is too small to record booting a FIT image
> with EFI kernel, initrd, dtb as seen on the StarFive VisionFive 2
> board.
>
> Increase the default for BOOTSTAGE_RECORD_COUNT to 50.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  boot/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/boot/Kconfig b/boot/Kconfig
> index fb37d912bc9..2456856a572 100644
> --- a/boot/Kconfig
> +++ b/boot/Kconfig
> @@ -1170,7 +1170,7 @@ config BOOTSTAGE_REPORT
>  config BOOTSTAGE_RECORD_COUNT
>         int "Number of boot stage records to store"
>         depends on BOOTSTAGE
> -       default 30
> +       default 50
>         help
>           This is the size of the bootstage record list and is the maximum
>           number of bootstage records that can be recorded.
> --
> 2.48.1
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>