All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC] drm/i915/psr: Disable psr1 if setup_time > vblank
@ 2024-10-29  5:00 Animesh Manna
  2024-10-29  7:05 ` Hogander, Jouni
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Animesh Manna @ 2024-10-29  5:00 UTC (permalink / raw)
  To: intel-gfx; +Cc: jouni.hogander, Animesh Manna

Issue is seen when PSR enabled with setup frames and when try to disable
PSR at SRDONACK State (0x1). PSR FSM is stuck at SRDONACK(0x1) for more
than 5 seconds. Issue not seen with Setup frames disabled. Currently
disable psr1 if setuptime > vblank to workaround the above issue.

HSD: 16024594674

Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 4176163ec19a..887fa8a8f878 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1640,6 +1640,15 @@ _panel_replay_compute_config(struct intel_dp *intel_dp,
 	return true;
 }
 
+static bool intel_psr_needs_wa_18037818876(struct intel_dp *intel_dp,
+					   struct intel_crtc_state *crtc_state)
+{
+	struct intel_display *display = to_intel_display(intel_dp);
+
+	return ((DISPLAY_VER(display) == 20) && intel_dp->psr.entry_setup_frames > 0 &&
+		!crtc_state->has_sel_update);
+}
+
 void intel_psr_compute_config(struct intel_dp *intel_dp,
 			      struct intel_crtc_state *crtc_state,
 			      struct drm_connector_state *conn_state)
@@ -1686,6 +1695,10 @@ void intel_psr_compute_config(struct intel_dp *intel_dp,
 		return;
 
 	crtc_state->has_sel_update = intel_sel_update_config_valid(intel_dp, crtc_state);
+
+	/* Wa_18037818876 */
+	if (intel_psr_needs_wa_18037818876(intel_dp, crtc_state))
+		crtc_state->has_psr = false;
 }
 
 void intel_psr_get_config(struct intel_encoder *encoder,
-- 
2.29.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-10-30  3:23 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-29  5:00 [RFC] drm/i915/psr: Disable psr1 if setup_time > vblank Animesh Manna
2024-10-29  7:05 ` Hogander, Jouni
2024-10-29  7:37   ` Manna, Animesh
2024-10-29  8:36 ` Jani Nikula
2024-10-29 17:44 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-10-30  2:21 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-10-30  3:23 ` [RFC] " Garg, Nemesa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.