From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH] arm64: dts: marvell: align thermal node names with bindings
Date: Fri, 07 Apr 2023 17:08:16 +0200 [thread overview]
Message-ID: <87y1n33f33.fsf@BL-laptop> (raw)
In-Reply-To: <20230312201313.498434-1-krzysztof.kozlowski@linaro.org>
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
> Bindings expect thermal node names to end with '-thermal':
>
> armada-8040-db.dtb: thermal-zones: 'ap-thermal-cpu0', ... do not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
Applied on mvebu/dt64
Thanks,
Gregory
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/marvell/armada-ap80x.dtsi | 10 +++++-----
> arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 2 +-
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> index 4e6d29ad32eb..2c920e22cec2 100644
> --- a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> @@ -317,7 +317,7 @@ ap_thermal: thermal-sensor@80 {
> * first one that will have a critical trip point will be chosen.
> */
> thermal-zones {
> - ap_thermal_ic: ap-thermal-ic {
> + ap_thermal_ic: ap-ic-thermal {
> polling-delay-passive = <0>; /* Interrupt driven */
> polling-delay = <0>; /* Interrupt driven */
>
> @@ -334,7 +334,7 @@ ap_crit: ap-crit {
> cooling-maps { };
> };
>
> - ap_thermal_cpu0: ap-thermal-cpu0 {
> + ap_thermal_cpu0: ap-cpu0-thermal {
> polling-delay-passive = <1000>;
> polling-delay = <1000>;
>
> @@ -367,7 +367,7 @@ map0_emerg: map0-ermerg {
> };
> };
>
> - ap_thermal_cpu1: ap-thermal-cpu1 {
> + ap_thermal_cpu1: ap-cpu1-thermal {
> polling-delay-passive = <1000>;
> polling-delay = <1000>;
>
> @@ -400,7 +400,7 @@ map1_emerg: map1-emerg {
> };
> };
>
> - ap_thermal_cpu2: ap-thermal-cpu2 {
> + ap_thermal_cpu2: ap-cpu2-thermal {
> polling-delay-passive = <1000>;
> polling-delay = <1000>;
>
> @@ -433,7 +433,7 @@ map2_emerg: map2-emerg {
> };
> };
>
> - ap_thermal_cpu3: ap-thermal-cpu3 {
> + ap_thermal_cpu3: ap-cpu3-thermal {
> polling-delay-passive = <1000>;
> polling-delay = <1000>;
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> index 7d0043824f2a..0cc9ee9871e7 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> @@ -25,7 +25,7 @@ / {
> * The cooling maps are empty as there are no cooling devices.
> */
> thermal-zones {
> - CP11X_LABEL(thermal_ic): CP11X_NODE_NAME(thermal-ic) {
> + CP11X_LABEL(thermal_ic): CP11X_NODE_NAME(ic-thermal) {
> polling-delay-passive = <0>; /* Interrupt driven */
> polling-delay = <0>; /* Interrupt driven */
>
> --
> 2.34.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH] arm64: dts: marvell: align thermal node names with bindings
Date: Fri, 07 Apr 2023 17:08:16 +0200 [thread overview]
Message-ID: <87y1n33f33.fsf@BL-laptop> (raw)
In-Reply-To: <20230312201313.498434-1-krzysztof.kozlowski@linaro.org>
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
> Bindings expect thermal node names to end with '-thermal':
>
> armada-8040-db.dtb: thermal-zones: 'ap-thermal-cpu0', ... do not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
Applied on mvebu/dt64
Thanks,
Gregory
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/marvell/armada-ap80x.dtsi | 10 +++++-----
> arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 2 +-
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> index 4e6d29ad32eb..2c920e22cec2 100644
> --- a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> @@ -317,7 +317,7 @@ ap_thermal: thermal-sensor@80 {
> * first one that will have a critical trip point will be chosen.
> */
> thermal-zones {
> - ap_thermal_ic: ap-thermal-ic {
> + ap_thermal_ic: ap-ic-thermal {
> polling-delay-passive = <0>; /* Interrupt driven */
> polling-delay = <0>; /* Interrupt driven */
>
> @@ -334,7 +334,7 @@ ap_crit: ap-crit {
> cooling-maps { };
> };
>
> - ap_thermal_cpu0: ap-thermal-cpu0 {
> + ap_thermal_cpu0: ap-cpu0-thermal {
> polling-delay-passive = <1000>;
> polling-delay = <1000>;
>
> @@ -367,7 +367,7 @@ map0_emerg: map0-ermerg {
> };
> };
>
> - ap_thermal_cpu1: ap-thermal-cpu1 {
> + ap_thermal_cpu1: ap-cpu1-thermal {
> polling-delay-passive = <1000>;
> polling-delay = <1000>;
>
> @@ -400,7 +400,7 @@ map1_emerg: map1-emerg {
> };
> };
>
> - ap_thermal_cpu2: ap-thermal-cpu2 {
> + ap_thermal_cpu2: ap-cpu2-thermal {
> polling-delay-passive = <1000>;
> polling-delay = <1000>;
>
> @@ -433,7 +433,7 @@ map2_emerg: map2-emerg {
> };
> };
>
> - ap_thermal_cpu3: ap-thermal-cpu3 {
> + ap_thermal_cpu3: ap-cpu3-thermal {
> polling-delay-passive = <1000>;
> polling-delay = <1000>;
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> index 7d0043824f2a..0cc9ee9871e7 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> @@ -25,7 +25,7 @@ / {
> * The cooling maps are empty as there are no cooling devices.
> */
> thermal-zones {
> - CP11X_LABEL(thermal_ic): CP11X_NODE_NAME(thermal-ic) {
> + CP11X_LABEL(thermal_ic): CP11X_NODE_NAME(ic-thermal) {
> polling-delay-passive = <0>; /* Interrupt driven */
> polling-delay = <0>; /* Interrupt driven */
>
> --
> 2.34.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2023-04-07 15:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 20:13 [PATCH] arm64: dts: marvell: align thermal node names with bindings Krzysztof Kozlowski
2023-03-12 20:13 ` Krzysztof Kozlowski
2023-04-07 15:08 ` Gregory CLEMENT [this message]
2023-04-07 15:08 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1n33f33.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.