All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: "Tyler J. Stachecki" <stachecki.tyler@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	 Jakub Kicinski <kuba@kernel.org>,
	 ath11k@lists.infradead.org (open list:QUALCOMM ATHEROS ATH11K
	WIRELESS DRIVER),
	 linux-wireless@vger.kernel.org (open list:NETWORKING DRIVERS
	(WIRELESS)),
	 netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
	 linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] ath11k: Fix QCN9074 firmware boot on x86
Date: Tue, 01 Nov 2022 16:46:22 +0200	[thread overview]
Message-ID: <87y1sug2bl.fsf@kernel.org> (raw)
In-Reply-To: <20221022042728.43015-1-stachecki.tyler@gmail.com> (Tyler J. Stachecki's message of "Sat, 22 Oct 2022 00:27:28 -0400")

"Tyler J. Stachecki" <stachecki.tyler@gmail.com> writes:

> The 2.7.0 series of QCN9074's firmware requests 5 segments
> of memory instead of 3 (as in the 2.5.0 series).
>
> The first segment (11M) is too large to be kalloc'd in one
> go on x86 and requires piecemeal 1MB allocations, as was
> the case with the prior public firmware (2.5.0, 15M).
>
> Since f6f92968e1e5, ath11k will break the memory requests,
> but only if there were fewer than 3 segments requested by
> the firmware. It seems that 5 segments works fine and
> allows QCN9074 to boot on x86 with firmware 2.7.0, so
> change things accordingly.
>
> Signed-off-by: Tyler J. Stachecki <stachecki.tyler@gmail.com>

Ouch, that's pretty bad. Thanks for fixing this!

Does the 2.5.0.1 firmware branch still work with this patch? It's
important that we don't break the old firmware.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: "Tyler J. Stachecki" <stachecki.tyler@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	ath11k@lists.infradead.org (open list:QUALCOMM ATHEROS ATH11K
	WIRELESS DRIVER),
	linux-wireless@vger.kernel.org (open list:NETWORKING DRIVERS
	(WIRELESS)),
	netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
	linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] ath11k: Fix QCN9074 firmware boot on x86
Date: Tue, 01 Nov 2022 16:46:22 +0200	[thread overview]
Message-ID: <87y1sug2bl.fsf@kernel.org> (raw)
In-Reply-To: <20221022042728.43015-1-stachecki.tyler@gmail.com> (Tyler J. Stachecki's message of "Sat, 22 Oct 2022 00:27:28 -0400")

"Tyler J. Stachecki" <stachecki.tyler@gmail.com> writes:

> The 2.7.0 series of QCN9074's firmware requests 5 segments
> of memory instead of 3 (as in the 2.5.0 series).
>
> The first segment (11M) is too large to be kalloc'd in one
> go on x86 and requires piecemeal 1MB allocations, as was
> the case with the prior public firmware (2.5.0, 15M).
>
> Since f6f92968e1e5, ath11k will break the memory requests,
> but only if there were fewer than 3 segments requested by
> the firmware. It seems that 5 segments works fine and
> allows QCN9074 to boot on x86 with firmware 2.7.0, so
> change things accordingly.
>
> Signed-off-by: Tyler J. Stachecki <stachecki.tyler@gmail.com>

Ouch, that's pretty bad. Thanks for fixing this!

Does the 2.5.0.1 firmware branch still work with this patch? It's
important that we don't break the old firmware.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2022-11-01 14:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-22  4:27 [PATCH] ath11k: Fix QCN9074 firmware boot on x86 Tyler J. Stachecki
2022-10-22  4:27 ` Tyler J. Stachecki
2022-11-01 14:46 ` Kalle Valo [this message]
2022-11-01 14:46   ` Kalle Valo
2022-11-02  0:51   ` Tyler Stachecki
2022-11-02  0:51     ` Tyler Stachecki
2022-11-02  5:45     ` Kalle Valo
2022-11-02  5:45       ` Kalle Valo
2022-11-02 10:37       ` Kalle Valo
2022-11-02 10:37         ` Kalle Valo
2022-11-02 17:15 ` Kalle Valo
2022-11-02 17:15   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1sug2bl.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stachecki.tyler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.