From: Kalle Valo <kvalo@kernel.org>
To: Wen Gong <quic_wgong@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] ath11k: report tx bitrate for iw wlan station dump
Date: Tue, 14 Dec 2021 19:58:53 +0200 [thread overview]
Message-ID: <87y24ngjaa.fsf@codeaurora.org> (raw)
In-Reply-To: <20211213102723.4857-1-quic_wgong@quicinc.com> (Wen Gong's message of "Mon, 13 Dec 2021 05:27:23 -0500")
Wen Gong <quic_wgong@quicinc.com> writes:
> HTT_T2H_MSG_TYPE_PPDU_STATS_IND is a message which include the ppdu
> info, currently it is not report from firmware for ath11k, then the
> tx bitrate of "iw wlan0 station dump" always show an invalid value
> "tx bitrate: 6.0 MBit/s".
>
> To address the issue, this is to parse the info of tx complete report
> from firmware and indicate the tx rate to mac80211.
>
> After that, "iw wlan0 station dump" show the correct tx bit rate such
> as "tx bitrate: 1921.5 MBit/s 160MHz HE-MCS 9 HE-NSS 2 HE-GI 0 HE-DCM 0".
>
> Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1
>
> Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
I briefly tested this and tx rate didn't look correct to me:
$ iw wlan0 link
Connected to xx (on wlan0)
SSID: <censored>
freq: 2442
RX: 8838 bytes (80 packets)
TX: 1551 bytes (15 packets)
signal: -104 dBm
rx bitrate: 39.0 MBit/s MCS 4
tx bitrate: (unknown) MCS 253
I guess the signal isn't correct either, are you planning to fix it also
at some point?
Also I see new warnings with this patch:
[ 174.373905] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 174.386303] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 174.388733] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 174.472723] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 174.573331] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 174.838234] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 174.881577] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 174.985640] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 175.076154] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 175.113921] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 180.206378] ath11k_warn: 34 callbacks suppressed
[ 180.206396] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Wen Gong <quic_wgong@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] ath11k: report tx bitrate for iw wlan station dump
Date: Tue, 14 Dec 2021 19:58:53 +0200 [thread overview]
Message-ID: <87y24ngjaa.fsf@codeaurora.org> (raw)
In-Reply-To: <20211213102723.4857-1-quic_wgong@quicinc.com> (Wen Gong's message of "Mon, 13 Dec 2021 05:27:23 -0500")
Wen Gong <quic_wgong@quicinc.com> writes:
> HTT_T2H_MSG_TYPE_PPDU_STATS_IND is a message which include the ppdu
> info, currently it is not report from firmware for ath11k, then the
> tx bitrate of "iw wlan0 station dump" always show an invalid value
> "tx bitrate: 6.0 MBit/s".
>
> To address the issue, this is to parse the info of tx complete report
> from firmware and indicate the tx rate to mac80211.
>
> After that, "iw wlan0 station dump" show the correct tx bit rate such
> as "tx bitrate: 1921.5 MBit/s 160MHz HE-MCS 9 HE-NSS 2 HE-GI 0 HE-DCM 0".
>
> Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1
>
> Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
I briefly tested this and tx rate didn't look correct to me:
$ iw wlan0 link
Connected to xx (on wlan0)
SSID: <censored>
freq: 2442
RX: 8838 bytes (80 packets)
TX: 1551 bytes (15 packets)
signal: -104 dBm
rx bitrate: 39.0 MBit/s MCS 4
tx bitrate: (unknown) MCS 253
I guess the signal isn't correct either, are you planning to fix it also
at some point?
Also I see new warnings with this patch:
[ 174.373905] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 174.386303] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 174.388733] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 174.472723] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 174.573331] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 174.838234] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 174.881577] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 174.985640] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 175.076154] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 175.113921] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
[ 180.206378] ath11k_warn: 34 callbacks suppressed
[ 180.206396] ath11k_pci 0000:06:00.0: failed to find the peer by id 14
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-12-14 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 10:27 [PATCH v2] ath11k: report tx bitrate for iw wlan station dump Wen Gong
2021-12-13 10:27 ` Wen Gong
2021-12-14 17:58 ` Kalle Valo [this message]
2021-12-14 17:58 ` Kalle Valo
2021-12-16 10:41 ` Wen Gong
2021-12-16 10:41 ` Wen Gong
2021-12-16 13:51 ` Kalle Valo
2021-12-16 13:51 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y24ngjaa.fsf@codeaurora.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_wgong@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.