All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	Harald Hoyer <harald@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-options: Fix bad "macaddr" property in the documentation
Date: Mon, 13 Aug 2018 14:31:48 +0200	[thread overview]
Message-ID: <87y3da5txn.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1534161104-8253-1-git-send-email-thuth@redhat.com> (Thomas Huth's message of "Mon, 13 Aug 2018 13:51:44 +0200")

Thomas Huth <thuth@redhat.com> writes:

> When using the "-device" option, the property is called "mac".
> "macaddr" is only used for the legacy "-net nic" option.

Indeed:

    #define DEFINE_NIC_PROPERTIES(_state, _conf)                            \
--->    DEFINE_PROP_MACADDR("mac",   _state, _conf.macaddr),                \
        DEFINE_PROP_NETDEV("netdev", _state, _conf.peers)

> Reported-by: Harald Hoyer <harald@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index b1bf0f4..3495531 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2345,7 +2345,7 @@ qemu-system-i386 linux.img \
>                   -netdev socket,id=n2,mcast=230.0.0.1:1234
>  # launch yet another QEMU instance on same "bus"
>  qemu-system-i386 linux.img \
> -                 -device e1000,netdev=n3,macaddr=52:54:00:12:34:58 \
> +                 -device e1000,netdev=n3,mac=52:54:00:12:34:58 \
>                   -netdev socket,id=n3,mcast=230.0.0.1:1234
>  @end example

Reviewed-by: Markus Armbruster <armbru@redhat.com>


WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	Harald Hoyer <harald@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-options: Fix bad "macaddr" property in the documentation
Date: Mon, 13 Aug 2018 14:31:48 +0200	[thread overview]
Message-ID: <87y3da5txn.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1534161104-8253-1-git-send-email-thuth@redhat.com> (Thomas Huth's message of "Mon, 13 Aug 2018 13:51:44 +0200")

Thomas Huth <thuth@redhat.com> writes:

> When using the "-device" option, the property is called "mac".
> "macaddr" is only used for the legacy "-net nic" option.

Indeed:

    #define DEFINE_NIC_PROPERTIES(_state, _conf)                            \
--->    DEFINE_PROP_MACADDR("mac",   _state, _conf.macaddr),                \
        DEFINE_PROP_NETDEV("netdev", _state, _conf.peers)

> Reported-by: Harald Hoyer <harald@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index b1bf0f4..3495531 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2345,7 +2345,7 @@ qemu-system-i386 linux.img \
>                   -netdev socket,id=n2,mcast=230.0.0.1:1234
>  # launch yet another QEMU instance on same "bus"
>  qemu-system-i386 linux.img \
> -                 -device e1000,netdev=n3,macaddr=52:54:00:12:34:58 \
> +                 -device e1000,netdev=n3,mac=52:54:00:12:34:58 \
>                   -netdev socket,id=n3,mcast=230.0.0.1:1234
>  @end example

Reviewed-by: Markus Armbruster <armbru@redhat.com>

  reply	other threads:[~2018-08-13 12:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-13 11:51 [Qemu-trivial] [PATCH] qemu-options: Fix bad "macaddr" property in the documentation Thomas Huth
2018-08-13 11:51 ` [Qemu-devel] " Thomas Huth
2018-08-13 12:31 ` Markus Armbruster [this message]
2018-08-13 12:31   ` Markus Armbruster
2018-08-15  3:06   ` [Qemu-trivial] " Jason Wang
2018-08-15  3:06     ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3da5txn.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=harald@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.