[1/2] usb: gadget: r8a66597: Fix two possible sleep-in-atomic-context bugs in init_controller()

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Felipe Balbi <balbi@kernel.org>
To: Robert Jarzmik <robert.jarzmik@free.fr>,
	Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: gregkh@linuxfoundation.org, nicolas.ferre@microchip.com,
	keescook@chromium.org, allen.lkml@gmail.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [1/2] usb: gadget: r8a66597: Fix two possible sleep-in-atomic-context bugs in init_controller()
Date: Fri, 29 Jun 2018 09:35:10 +0300	[thread overview]
Message-ID: <87y3eydrs1.fsf@linux.intel.com> (raw)

Hi,

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> Jia-Ju Bai <baijiaju1990@gmail.com> writes:
>
>> The driver may sleep with holding a spinlock.
>> The function call paths (from bottom to top) in Linux-4.16.7 are:
>>
>> [FUNC] msleep
>> drivers/usb/gadget/udc/r8a66597-udc.c, 839: 
>> 		msleep in init_controller
>> drivers/usb/gadget/udc/r8a66597-udc.c, 96: 
>> 		init_controller in r8a66597_usb_disconnect
>> drivers/usb/gadget/udc/r8a66597-udc.c, 93: 
>> 		spin_lock in r8a66597_usb_disconnect
>
> That should not happen...
>
> If think the issue you have is that your usb_connect() and usb_disconnect() are
> called from interrupt context. I think the proper fix, as what is done in most
> udc phys, is to schedule a workqueue, see drivers/usb/phy/phy-gpio-vbus-usb.c,
> gpio_vbus_data.vbus.

argh, no. No workqueues needed here. Sorry

WARNING: multiple messages have this Message-ID (diff)

From: Felipe Balbi <balbi@kernel.org>
To: Robert Jarzmik <robert.jarzmik@free.fr>,
	Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: gregkh@linuxfoundation.org, nicolas.ferre@microchip.com,
	keescook@chromium.org, allen.lkml@gmail.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: gadget: r8a66597: Fix two possible sleep-in-atomic-context bugs in init_controller()
Date: Fri, 29 Jun 2018 09:35:10 +0300	[thread overview]
Message-ID: <87y3eydrs1.fsf@linux.intel.com> (raw)
In-Reply-To: <87efh0o6f9.fsf@belgarion.home>


Hi,

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> Jia-Ju Bai <baijiaju1990@gmail.com> writes:
>
>> The driver may sleep with holding a spinlock.
>> The function call paths (from bottom to top) in Linux-4.16.7 are:
>>
>> [FUNC] msleep
>> drivers/usb/gadget/udc/r8a66597-udc.c, 839: 
>> 		msleep in init_controller
>> drivers/usb/gadget/udc/r8a66597-udc.c, 96: 
>> 		init_controller in r8a66597_usb_disconnect
>> drivers/usb/gadget/udc/r8a66597-udc.c, 93: 
>> 		spin_lock in r8a66597_usb_disconnect
>
> That should not happen...
>
> If think the issue you have is that your usb_connect() and usb_disconnect() are
> called from interrupt context. I think the proper fix, as what is done in most
> udc phys, is to schedule a workqueue, see drivers/usb/phy/phy-gpio-vbus-usb.c,
> gpio_vbus_data.vbus.

argh, no. No workqueues needed here. Sorry

-- 
balbi

next             reply	other threads:[~2018-06-29  6:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-29  6:35 Felipe Balbi [this message]
2018-06-29  6:35 ` [PATCH 1/2] usb: gadget: r8a66597: Fix two possible sleep-in-atomic-context bugs in init_controller() Felipe Balbi
  -- strict thread matches above, loose matches on Subject: below --
2018-06-29 13:21 [1/2] " Robert Jarzmik
2018-06-29 13:21 ` [PATCH 1/2] " Robert Jarzmik
2018-06-29 11:15 [1/2] " Felipe Balbi
2018-06-29 11:15 ` [PATCH 1/2] " Felipe Balbi
2018-06-29 11:04 [1/2] " Robert Jarzmik
2018-06-29 11:04 ` [PATCH 1/2] " Robert Jarzmik
2018-06-29 10:25 [1/2] " Felipe Balbi
2018-06-29 10:25 ` [PATCH 1/2] " Felipe Balbi
2018-06-29  6:48 [1/2] " Robert Jarzmik
2018-06-29  6:48 ` [PATCH 1/2] " Robert Jarzmik
2018-06-21  9:06 [1/2] " Robert Jarzmik
2018-06-21  9:06 ` [PATCH 1/2] " Robert Jarzmik
2018-06-20  3:54 [1/2] " Jia-Ju Bai
2018-06-20  3:54 ` [PATCH 1/2] " Jia-Ju Bai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3eydrs1.fsf@linux.intel.com \
    --to=balbi@kernel.org \
    --cc=allen.lkml@gmail.com \
    --cc=baijiaju1990@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.