All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, qemu-arm@nongnu.org
Subject: Re: [Qemu-arm] [PATCH v6 00/35] target/arm SVE patches
Date: Thu, 28 Jun 2018 12:30:59 +0100	[thread overview]
Message-ID: <87y3ezuozw.fsf@linaro.org> (raw)
In-Reply-To: <20180627043328.11531-1-richard.henderson@linaro.org>


Richard Henderson <richard.henderson@linaro.org> writes:

> This is the remainder of the SVE enablement patches,
> with an extra bonus patch to enable ARMv8.2-DotProd.
>
> V6 updates based on review.

One failure from the VQ3 test set:

../qemu.git/aarch64-linux-user/qemu-aarch64 \
  ./risu --test-sve=3 \
  sve-all-short-v8.3+sve@vq3/insn_sdiv_z_p_zz___INC.risu.bin \
  --trace=sve-all-short-v8.3+sve@vq3/insn_sdiv_z_p_zz___INC.risu.bin.trace

Gives:

  loading test image
  sve-all-short-v8.3+sve@vq3/insn_sdiv_z_p_zz___INC.risu.bin...
  starting apprentice image at 0x4000801000
  starting image
  fish: “../qemu.git/aarch64-linux-user/…” terminated by signal SIGFPE
  (Floating point exception)

From:

  http://people.linaro.org/~alex.bennee/testcases/arm64.risu/sve-all-short-v8.3+sve@vq3.tar.xz

>
> Patches with changes:
>   0002-target-arm-Implement-SVE-Contiguous-Load-first-fa.patch
>   0007-target-arm-Implement-SVE-FP-Multiply-Add-Group.patch
>   0009-target-arm-Implement-SVE-load-and-broadcast-eleme.patch
>   0010-target-arm-Implement-SVE-store-vector-predicate-r.patch
>   0011-target-arm-Implement-SVE-scatter-stores.patch
>   0013-target-arm-Implement-SVE-gather-loads.patch
>   0023-target-arm-Implement-SVE-floating-point-convert-p.patch
>   0027-target-arm-Implement-SVE-MOVPRFX.patch
>   0030-target-arm-Pass-index-to-AdvSIMD-FCMLA-indexed.patch
>   0033-target-arm-Implement-SVE-dot-product-indexed.patch
>   0034-target-arm-Enable-SVE-for-aarch64-linux-user.patch
>   0035-target-arm-Implement-ARMv8.2-DotProd.patch
>
> Patches lacking reviews:
>   0002-target-arm-Implement-SVE-Contiguous-Load-first-fa.patch
>   0007-target-arm-Implement-SVE-FP-Multiply-Add-Group.patch
>   0013-target-arm-Implement-SVE-gather-loads.patch
>   0030-target-arm-Pass-index-to-AdvSIMD-FCMLA-indexed.patch
>   0031-target-arm-Implement-SVE-fp-complex-multiply-add-.patch
>   0033-target-arm-Implement-SVE-dot-product-indexed.patch
>
>
> r~
>
>
> Richard Henderson (35):
>   target/arm: Implement SVE Memory Contiguous Load Group
>   target/arm: Implement SVE Contiguous Load, first-fault and no-fault
>   target/arm: Implement SVE Memory Contiguous Store Group
>   target/arm: Implement SVE load and broadcast quadword
>   target/arm: Implement SVE integer convert to floating-point
>   target/arm: Implement SVE floating-point arithmetic (predicated)
>   target/arm: Implement SVE FP Multiply-Add Group
>   target/arm: Implement SVE Floating Point Accumulating Reduction Group
>   target/arm: Implement SVE load and broadcast element
>   target/arm: Implement SVE store vector/predicate register
>   target/arm: Implement SVE scatter stores
>   target/arm: Implement SVE prefetches
>   target/arm: Implement SVE gather loads
>   target/arm: Implement SVE first-fault gather loads
>   target/arm: Implement SVE scatter store vector immediate
>   target/arm: Implement SVE floating-point compare vectors
>   target/arm: Implement SVE floating-point arithmetic with immediate
>   target/arm: Implement SVE Floating Point Multiply Indexed Group
>   target/arm: Implement SVE FP Fast Reduction Group
>   target/arm: Implement SVE Floating Point Unary Operations -
>     Unpredicated Group
>   target/arm: Implement SVE FP Compare with Zero Group
>   target/arm: Implement SVE floating-point trig multiply-add coefficient
>   target/arm: Implement SVE floating-point convert precision
>   target/arm: Implement SVE floating-point convert to integer
>   target/arm: Implement SVE floating-point round to integral value
>   target/arm: Implement SVE floating-point unary operations
>   target/arm: Implement SVE MOVPRFX
>   target/arm: Implement SVE floating-point complex add
>   target/arm: Implement SVE fp complex multiply add
>   target/arm: Pass index to AdvSIMD FCMLA (indexed)
>   target/arm: Implement SVE fp complex multiply add (indexed)
>   target/arm: Implement SVE dot product (vectors)
>   target/arm: Implement SVE dot product (indexed)
>   target/arm: Enable SVE for aarch64-linux-user
>   target/arm: Implement ARMv8.2-DotProd
>
>  target/arm/cpu.h           |    1 +
>  target/arm/helper-sve.h    |  682 +++++++++++++
>  target/arm/helper.h        |   44 +-
>  linux-user/elfload.c       |    2 +
>  target/arm/cpu.c           |    8 +
>  target/arm/cpu64.c         |    2 +
>  target/arm/helper.c        |    2 +-
>  target/arm/sve_helper.c    | 1855 ++++++++++++++++++++++++++++++++++++
>  target/arm/translate-a64.c |   57 +-
>  target/arm/translate-sve.c | 1688 +++++++++++++++++++++++++++++++-
>  target/arm/translate.c     |  102 +-
>  target/arm/vec_helper.c    |  311 +++++-
>  target/arm/sve.decode      |  427 +++++++++
>  13 files changed, 5116 insertions(+), 65 deletions(-)


--
Alex Bennée

WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH v6 00/35] target/arm SVE patches
Date: Thu, 28 Jun 2018 12:30:59 +0100	[thread overview]
Message-ID: <87y3ezuozw.fsf@linaro.org> (raw)
In-Reply-To: <20180627043328.11531-1-richard.henderson@linaro.org>


Richard Henderson <richard.henderson@linaro.org> writes:

> This is the remainder of the SVE enablement patches,
> with an extra bonus patch to enable ARMv8.2-DotProd.
>
> V6 updates based on review.

One failure from the VQ3 test set:

../qemu.git/aarch64-linux-user/qemu-aarch64 \
  ./risu --test-sve=3 \
  sve-all-short-v8.3+sve@vq3/insn_sdiv_z_p_zz___INC.risu.bin \
  --trace=sve-all-short-v8.3+sve@vq3/insn_sdiv_z_p_zz___INC.risu.bin.trace

Gives:

  loading test image
  sve-all-short-v8.3+sve@vq3/insn_sdiv_z_p_zz___INC.risu.bin...
  starting apprentice image at 0x4000801000
  starting image
  fish: “../qemu.git/aarch64-linux-user/…” terminated by signal SIGFPE
  (Floating point exception)

From:

  http://people.linaro.org/~alex.bennee/testcases/arm64.risu/sve-all-short-v8.3+sve@vq3.tar.xz

>
> Patches with changes:
>   0002-target-arm-Implement-SVE-Contiguous-Load-first-fa.patch
>   0007-target-arm-Implement-SVE-FP-Multiply-Add-Group.patch
>   0009-target-arm-Implement-SVE-load-and-broadcast-eleme.patch
>   0010-target-arm-Implement-SVE-store-vector-predicate-r.patch
>   0011-target-arm-Implement-SVE-scatter-stores.patch
>   0013-target-arm-Implement-SVE-gather-loads.patch
>   0023-target-arm-Implement-SVE-floating-point-convert-p.patch
>   0027-target-arm-Implement-SVE-MOVPRFX.patch
>   0030-target-arm-Pass-index-to-AdvSIMD-FCMLA-indexed.patch
>   0033-target-arm-Implement-SVE-dot-product-indexed.patch
>   0034-target-arm-Enable-SVE-for-aarch64-linux-user.patch
>   0035-target-arm-Implement-ARMv8.2-DotProd.patch
>
> Patches lacking reviews:
>   0002-target-arm-Implement-SVE-Contiguous-Load-first-fa.patch
>   0007-target-arm-Implement-SVE-FP-Multiply-Add-Group.patch
>   0013-target-arm-Implement-SVE-gather-loads.patch
>   0030-target-arm-Pass-index-to-AdvSIMD-FCMLA-indexed.patch
>   0031-target-arm-Implement-SVE-fp-complex-multiply-add-.patch
>   0033-target-arm-Implement-SVE-dot-product-indexed.patch
>
>
> r~
>
>
> Richard Henderson (35):
>   target/arm: Implement SVE Memory Contiguous Load Group
>   target/arm: Implement SVE Contiguous Load, first-fault and no-fault
>   target/arm: Implement SVE Memory Contiguous Store Group
>   target/arm: Implement SVE load and broadcast quadword
>   target/arm: Implement SVE integer convert to floating-point
>   target/arm: Implement SVE floating-point arithmetic (predicated)
>   target/arm: Implement SVE FP Multiply-Add Group
>   target/arm: Implement SVE Floating Point Accumulating Reduction Group
>   target/arm: Implement SVE load and broadcast element
>   target/arm: Implement SVE store vector/predicate register
>   target/arm: Implement SVE scatter stores
>   target/arm: Implement SVE prefetches
>   target/arm: Implement SVE gather loads
>   target/arm: Implement SVE first-fault gather loads
>   target/arm: Implement SVE scatter store vector immediate
>   target/arm: Implement SVE floating-point compare vectors
>   target/arm: Implement SVE floating-point arithmetic with immediate
>   target/arm: Implement SVE Floating Point Multiply Indexed Group
>   target/arm: Implement SVE FP Fast Reduction Group
>   target/arm: Implement SVE Floating Point Unary Operations -
>     Unpredicated Group
>   target/arm: Implement SVE FP Compare with Zero Group
>   target/arm: Implement SVE floating-point trig multiply-add coefficient
>   target/arm: Implement SVE floating-point convert precision
>   target/arm: Implement SVE floating-point convert to integer
>   target/arm: Implement SVE floating-point round to integral value
>   target/arm: Implement SVE floating-point unary operations
>   target/arm: Implement SVE MOVPRFX
>   target/arm: Implement SVE floating-point complex add
>   target/arm: Implement SVE fp complex multiply add
>   target/arm: Pass index to AdvSIMD FCMLA (indexed)
>   target/arm: Implement SVE fp complex multiply add (indexed)
>   target/arm: Implement SVE dot product (vectors)
>   target/arm: Implement SVE dot product (indexed)
>   target/arm: Enable SVE for aarch64-linux-user
>   target/arm: Implement ARMv8.2-DotProd
>
>  target/arm/cpu.h           |    1 +
>  target/arm/helper-sve.h    |  682 +++++++++++++
>  target/arm/helper.h        |   44 +-
>  linux-user/elfload.c       |    2 +
>  target/arm/cpu.c           |    8 +
>  target/arm/cpu64.c         |    2 +
>  target/arm/helper.c        |    2 +-
>  target/arm/sve_helper.c    | 1855 ++++++++++++++++++++++++++++++++++++
>  target/arm/translate-a64.c |   57 +-
>  target/arm/translate-sve.c | 1688 +++++++++++++++++++++++++++++++-
>  target/arm/translate.c     |  102 +-
>  target/arm/vec_helper.c    |  311 +++++-
>  target/arm/sve.decode      |  427 +++++++++
>  13 files changed, 5116 insertions(+), 65 deletions(-)


--
Alex Bennée

  parent reply	other threads:[~2018-06-28 11:31 UTC|newest]

Thread overview: 112+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27  4:32 [Qemu-arm] [PATCH v6 00/35] target/arm SVE patches Richard Henderson
2018-06-27  4:32 ` [Qemu-devel] " Richard Henderson
2018-06-27  4:32 ` [Qemu-arm] [PATCH v6 01/35] target/arm: Implement SVE Memory Contiguous Load Group Richard Henderson
2018-06-27  4:32   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:32 ` [Qemu-arm] [PATCH v6 02/35] target/arm: Implement SVE Contiguous Load, first-fault and no-fault Richard Henderson
2018-06-27  4:32   ` [Qemu-devel] " Richard Henderson
2018-06-27 15:56   ` [Qemu-arm] " Alex Bennée
2018-06-27 15:56     ` [Qemu-devel] " Alex Bennée
2018-06-27  4:32 ` [Qemu-devel] [PATCH v6 03/35] target/arm: Implement SVE Memory Contiguous Store Group Richard Henderson
2018-06-27  4:32   ` Richard Henderson
2018-06-27  4:32 ` [Qemu-arm] [PATCH v6 04/35] target/arm: Implement SVE load and broadcast quadword Richard Henderson
2018-06-27  4:32   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:32 ` [Qemu-arm] [PATCH v6 05/35] target/arm: Implement SVE integer convert to floating-point Richard Henderson
2018-06-27  4:32   ` [Qemu-devel] " Richard Henderson
2018-06-28 12:49   ` Peter Maydell
2018-06-28 12:49     ` Peter Maydell
2018-06-27  4:32 ` [Qemu-arm] [PATCH v6 06/35] target/arm: Implement SVE floating-point arithmetic (predicated) Richard Henderson
2018-06-27  4:32   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-devel] [PATCH v6 07/35] target/arm: Implement SVE FP Multiply-Add Group Richard Henderson
2018-06-27  4:33   ` Richard Henderson
2018-06-28 10:29   ` [Qemu-arm] " Peter Maydell
2018-06-28 10:29     ` [Qemu-devel] " Peter Maydell
2018-06-28 10:53   ` Alex Bennée
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 08/35] target/arm: Implement SVE Floating Point Accumulating Reduction Group Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-devel] [PATCH v6 09/35] target/arm: Implement SVE load and broadcast element Richard Henderson
2018-06-27  4:33   ` Richard Henderson
2018-06-27  4:33 ` [Qemu-devel] [PATCH v6 10/35] target/arm: Implement SVE store vector/predicate register Richard Henderson
2018-06-27  4:33   ` Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 11/35] target/arm: Implement SVE scatter stores Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 12/35] target/arm: Implement SVE prefetches Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 13/35] target/arm: Implement SVE gather loads Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-28 10:37   ` Peter Maydell
2018-06-28 10:37     ` Peter Maydell
2018-06-28 13:18   ` [Qemu-arm] " Alex Bennée
2018-06-28 13:18     ` [Qemu-devel] " Alex Bennée
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 14/35] target/arm: Implement SVE first-fault " Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 15/35] target/arm: Implement SVE scatter store vector immediate Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 16/35] target/arm: Implement SVE floating-point compare vectors Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 17/35] target/arm: Implement SVE floating-point arithmetic with immediate Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-devel] [PATCH v6 18/35] target/arm: Implement SVE Floating Point Multiply Indexed Group Richard Henderson
2018-06-27  4:33   ` Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 19/35] target/arm: Implement SVE FP Fast Reduction Group Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-devel] [PATCH v6 20/35] target/arm: Implement SVE Floating Point Unary Operations - Unpredicated Group Richard Henderson
2018-06-27  4:33   ` Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 21/35] target/arm: Implement SVE FP Compare with Zero Group Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 22/35] target/arm: Implement SVE floating-point trig multiply-add coefficient Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-devel] [PATCH v6 23/35] target/arm: Implement SVE floating-point convert precision Richard Henderson
2018-06-27  4:33   ` Richard Henderson
2018-06-28 12:55   ` [Qemu-arm] " Peter Maydell
2018-06-28 12:55     ` [Qemu-devel] " Peter Maydell
2018-06-27  4:33 ` [Qemu-devel] [PATCH v6 24/35] target/arm: Implement SVE floating-point convert to integer Richard Henderson
2018-06-27  4:33   ` Richard Henderson
2018-06-27  4:33 ` [Qemu-devel] [PATCH v6 25/35] target/arm: Implement SVE floating-point round to integral value Richard Henderson
2018-06-27  4:33   ` Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 26/35] target/arm: Implement SVE floating-point unary operations Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-devel] [PATCH v6 27/35] target/arm: Implement SVE MOVPRFX Richard Henderson
2018-06-27  4:33   ` Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 28/35] target/arm: Implement SVE floating-point complex add Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 29/35] target/arm: Implement SVE fp complex multiply add Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 30/35] target/arm: Pass index to AdvSIMD FCMLA (indexed) Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-28 10:52   ` [Qemu-arm] " Peter Maydell
2018-06-28 10:52     ` [Qemu-devel] " Peter Maydell
2018-06-28 13:25   ` [Qemu-arm] " Alex Bennée
2018-06-28 13:25     ` [Qemu-devel] " Alex Bennée
2018-06-27  4:33 ` [Qemu-devel] [PATCH v6 31/35] target/arm: Implement SVE fp complex multiply add (indexed) Richard Henderson
2018-06-27  4:33   ` Richard Henderson
2018-06-28 12:47   ` [Qemu-arm] " Peter Maydell
2018-06-28 12:47     ` [Qemu-devel] " Peter Maydell
2018-06-28 13:55   ` Alex Bennée
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 32/35] target/arm: Implement SVE dot product (vectors) Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 33/35] target/arm: Implement SVE dot product (indexed) Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-28 13:07   ` [Qemu-arm] " Peter Maydell
2018-06-28 13:07     ` [Qemu-devel] " Peter Maydell
2018-06-28 15:57     ` [Qemu-arm] " Richard Henderson
2018-06-28 15:57       ` [Qemu-devel] " Richard Henderson
2018-06-28 16:07       ` [Qemu-arm] " Peter Maydell
2018-06-28 16:07         ` [Qemu-devel] " Peter Maydell
2018-06-28 14:04   ` [Qemu-arm] " Alex Bennée
2018-06-28 14:04     ` [Qemu-devel] " Alex Bennée
2018-06-28 15:47     ` Richard Henderson
2018-06-28 15:47       ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 34/35] target/arm: Enable SVE for aarch64-linux-user Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-27  4:33 ` [Qemu-arm] [PATCH v6 35/35] target/arm: Implement ARMv8.2-DotProd Richard Henderson
2018-06-27  4:33   ` [Qemu-devel] " Richard Henderson
2018-06-28 11:30 ` Alex Bennée [this message]
2018-06-28 11:30   ` [Qemu-devel] [Qemu-arm] [PATCH v6 00/35] target/arm SVE patches Alex Bennée
2018-06-28 14:12   ` Peter Maydell
2018-06-28 14:12     ` [Qemu-devel] " Peter Maydell
2018-06-28 14:55     ` Peter Maydell
2018-06-28 14:55       ` [Qemu-devel] " Peter Maydell
2018-06-28 14:55     ` Alex Bennée
2018-06-28 14:55       ` [Qemu-devel] " Alex Bennée
2018-06-28 14:05 ` Alex Bennée
2018-06-28 14:05   ` [Qemu-devel] " Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3ezuozw.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.