All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fix typo in assignment of fs default overflow gid
@ 2017-12-14 18:13 Wolffhardt Schwabe
  2017-12-14 22:32 ` Eric W. Biederman
  0 siblings, 1 reply; 2+ messages in thread
From: Wolffhardt Schwabe @ 2017-12-14 18:13 UTC (permalink / raw)
  To: linux-kernel
  Cc: mingo, viro, ebiederm, ptikhomirov, sds, Dave.Martin, fweisbec,
	ktkhai, mhocko, linux-kernel, Wolffhardt Schwabe,
	Anatoliy Cherepantsev

fix typo in assignment of fs default overflow gid

The patch remains without practical effect since
both macros carry identical values.
Still, it might become a problem in the future
if (for whatever reason) the default overflow uid
and gid differ.
The DEFAULT_FS_OVERFLOWGID macro was previously unused.

Signed-off-by: Wolffhardt Schwabe <wolffhardt.schwabe@fau.de>
Signed-off-by: Anatoliy Cherepantsev <anatoliy.cherepantsev@fau.de>
---
 kernel/sys.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sys.c b/kernel/sys.c
index 83ffd7d..f2289de 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -135,7 +135,7 @@ EXPORT_SYMBOL(overflowgid);
  */
 
 int fs_overflowuid = DEFAULT_FS_OVERFLOWUID;
-int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
+int fs_overflowgid = DEFAULT_FS_OVERFLOWGID;
 
 EXPORT_SYMBOL(fs_overflowuid);
 EXPORT_SYMBOL(fs_overflowgid);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix typo in assignment of fs default overflow gid
  2017-12-14 18:13 [PATCH] fix typo in assignment of fs default overflow gid Wolffhardt Schwabe
@ 2017-12-14 22:32 ` Eric W. Biederman
  0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2017-12-14 22:32 UTC (permalink / raw)
  To: Wolffhardt Schwabe
  Cc: linux-kernel, mingo, viro, ptikhomirov, sds, Dave.Martin,
	fweisbec, ktkhai, mhocko, linux-kernel, Anatoliy Cherepantsev

Wolffhardt Schwabe <wolffhardt.schwabe@fau.de> writes:

> fix typo in assignment of fs default overflow gid
>
> The patch remains without practical effect since
> both macros carry identical values.
> Still, it might become a problem in the future
> if (for whatever reason) the default overflow uid
> and gid differ.
> The DEFAULT_FS_OVERFLOWGID macro was previously unused.
>
> Signed-off-by: Wolffhardt Schwabe <wolffhardt.schwabe@fau.de>
> Signed-off-by: Anatoliy Cherepantsev <anatoliy.cherepantsev@fau.de>

Applied.  Thank you.

Eric

> ---
>  kernel/sys.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sys.c b/kernel/sys.c
> index 83ffd7d..f2289de 100644
> --- a/kernel/sys.c
> +++ b/kernel/sys.c
> @@ -135,7 +135,7 @@ EXPORT_SYMBOL(overflowgid);
>   */
>  
>  int fs_overflowuid = DEFAULT_FS_OVERFLOWUID;
> -int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
> +int fs_overflowgid = DEFAULT_FS_OVERFLOWGID;
>  
>  EXPORT_SYMBOL(fs_overflowuid);
>  EXPORT_SYMBOL(fs_overflowgid);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-12-14 22:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-14 18:13 [PATCH] fix typo in assignment of fs default overflow gid Wolffhardt Schwabe
2017-12-14 22:32 ` Eric W. Biederman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.