From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Jan Luebbe <jlu@pengutronix.de>, Bjorn Helgaas <helgaas@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 0/2] fix 4GB DRAM window support on mvebu
Date: Thu, 31 Aug 2017 10:11:34 +0200 [thread overview]
Message-ID: <87y3q017ih.fsf@free-electrons.com> (raw)
In-Reply-To: <20170830200700.GX8154@bhelgaas-glaptop.roam.corp.google.com> (Bjorn Helgaas's message of "Wed, 30 Aug 2017 15:07:00 -0500")
Hi Bjorn and Jan,
=20
On mer., ao=C3=BBt 30 2017, Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Mon, Aug 28, 2017 at 05:25:15PM +0200, Jan Luebbe wrote:
>> The current MBUS DRAM window calculation fails for 4GB windows because it
>> overflows. This is fixed in the first patch by using u64 instead of u32 =
to
>> store the size. The second excplicitly checks that we don't try to confi=
gure a
>> too large memory window in the pci driver.
>>=20
>> As they don't depend on each other, they could also go in separatly.
>>=20
>> Jan Luebbe (2):
>> bus: mbus: fix window size calculation for 4GB windows
>> PCI: mvebu: Check DRAM window size
>>=20
>> drivers/bus/mvebu-mbus.c | 2 +-
>> drivers/pci/host/pci-mvebu.c | 27 ++++++++++++++++++++++-----
>> include/linux/mbus.h | 4 ++--
>> 3 files changed, 25 insertions(+), 8 deletions(-)
>
> Since these can be applied separately, I'll let somebody else take care of
> the drivers/bus/mvebu-mbus.c part.
I think I am the one who should take it. I will apply it when v4.14-rc1
will be released as it is too late for me for 4.14 now.
However I am not against the fact that it is applied through an other
tree because we don't touch this file for the next release so there is
no risk for a conflict, I can give my Acked-by if needed.
Thanks,
Gregory
>
> I'll look for an ack from Thomas or Jason before applying the second patc=
h,
> which touches drivers/pci/host/pci-mvebu.c.
--=20
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] fix 4GB DRAM window support on mvebu
Date: Thu, 31 Aug 2017 10:11:34 +0200 [thread overview]
Message-ID: <87y3q017ih.fsf@free-electrons.com> (raw)
In-Reply-To: <20170830200700.GX8154@bhelgaas-glaptop.roam.corp.google.com> (Bjorn Helgaas's message of "Wed, 30 Aug 2017 15:07:00 -0500")
Hi Bjorn and Jan,
On mer., ao?t 30 2017, Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Mon, Aug 28, 2017 at 05:25:15PM +0200, Jan Luebbe wrote:
>> The current MBUS DRAM window calculation fails for 4GB windows because it
>> overflows. This is fixed in the first patch by using u64 instead of u32 to
>> store the size. The second excplicitly checks that we don't try to configure a
>> too large memory window in the pci driver.
>>
>> As they don't depend on each other, they could also go in separatly.
>>
>> Jan Luebbe (2):
>> bus: mbus: fix window size calculation for 4GB windows
>> PCI: mvebu: Check DRAM window size
>>
>> drivers/bus/mvebu-mbus.c | 2 +-
>> drivers/pci/host/pci-mvebu.c | 27 ++++++++++++++++++++++-----
>> include/linux/mbus.h | 4 ++--
>> 3 files changed, 25 insertions(+), 8 deletions(-)
>
> Since these can be applied separately, I'll let somebody else take care of
> the drivers/bus/mvebu-mbus.c part.
I think I am the one who should take it. I will apply it when v4.14-rc1
will be released as it is too late for me for 4.14 now.
However I am not against the fact that it is applied through an other
tree because we don't touch this file for the next release so there is
no risk for a conflict, I can give my Acked-by if needed.
Thanks,
Gregory
>
> I'll look for an ack from Thomas or Jason before applying the second patch,
> which touches drivers/pci/host/pci-mvebu.c.
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Jan Luebbe <jlu@pengutronix.de>, Bjorn Helgaas <helgaas@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 0/2] fix 4GB DRAM window support on mvebu
Date: Thu, 31 Aug 2017 10:11:34 +0200 [thread overview]
Message-ID: <87y3q017ih.fsf@free-electrons.com> (raw)
In-Reply-To: <20170830200700.GX8154@bhelgaas-glaptop.roam.corp.google.com> (Bjorn Helgaas's message of "Wed, 30 Aug 2017 15:07:00 -0500")
Hi Bjorn and Jan,
On mer., août 30 2017, Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Mon, Aug 28, 2017 at 05:25:15PM +0200, Jan Luebbe wrote:
>> The current MBUS DRAM window calculation fails for 4GB windows because it
>> overflows. This is fixed in the first patch by using u64 instead of u32 to
>> store the size. The second excplicitly checks that we don't try to configure a
>> too large memory window in the pci driver.
>>
>> As they don't depend on each other, they could also go in separatly.
>>
>> Jan Luebbe (2):
>> bus: mbus: fix window size calculation for 4GB windows
>> PCI: mvebu: Check DRAM window size
>>
>> drivers/bus/mvebu-mbus.c | 2 +-
>> drivers/pci/host/pci-mvebu.c | 27 ++++++++++++++++++++++-----
>> include/linux/mbus.h | 4 ++--
>> 3 files changed, 25 insertions(+), 8 deletions(-)
>
> Since these can be applied separately, I'll let somebody else take care of
> the drivers/bus/mvebu-mbus.c part.
I think I am the one who should take it. I will apply it when v4.14-rc1
will be released as it is too late for me for 4.14 now.
However I am not against the fact that it is applied through an other
tree because we don't touch this file for the next release so there is
no risk for a conflict, I can give my Acked-by if needed.
Thanks,
Gregory
>
> I'll look for an ack from Thomas or Jason before applying the second patch,
> which touches drivers/pci/host/pci-mvebu.c.
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-08-31 8:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 15:25 [PATCH 0/2] fix 4GB DRAM window support on mvebu Jan Luebbe
2017-08-28 15:25 ` Jan Luebbe
2017-08-28 15:25 ` [PATCH 1/2] bus: mbus: fix window size calculation for 4GB windows Jan Luebbe
2017-08-28 15:25 ` Jan Luebbe
2017-08-28 15:25 ` Jan Luebbe
2017-09-19 14:43 ` Gregory CLEMENT
2017-09-19 14:43 ` Gregory CLEMENT
2017-09-19 14:43 ` Gregory CLEMENT
2017-09-20 16:37 ` Uwe Kleine-König
2017-09-20 16:37 ` Uwe Kleine-König
2017-09-20 16:37 ` Uwe Kleine-König
2017-08-28 15:25 ` [PATCH 2/2] PCI: mvebu: Check DRAM window size Jan Luebbe
2017-08-28 15:25 ` Jan Luebbe
2017-09-25 23:56 ` Bjorn Helgaas
2017-09-25 23:56 ` Bjorn Helgaas
2017-09-25 23:56 ` Bjorn Helgaas
2017-10-05 21:16 ` Bjorn Helgaas
2017-10-05 21:16 ` Bjorn Helgaas
2017-11-06 19:17 ` Bjorn Helgaas
2017-11-06 19:17 ` Bjorn Helgaas
2017-11-06 19:17 ` Bjorn Helgaas
2017-08-28 15:30 ` [RFC] ARM: Orion: " Jan Luebbe
2017-08-28 15:30 ` Jan Luebbe
2017-08-28 15:51 ` Andrew Lunn
2017-08-28 15:51 ` Andrew Lunn
2017-08-28 15:51 ` Andrew Lunn
2017-08-30 20:07 ` [PATCH 0/2] fix 4GB DRAM window support on mvebu Bjorn Helgaas
2017-08-30 20:07 ` Bjorn Helgaas
2017-08-30 20:07 ` Bjorn Helgaas
2017-08-31 8:11 ` Gregory CLEMENT [this message]
2017-08-31 8:11 ` Gregory CLEMENT
2017-08-31 8:11 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3q017ih.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=helgaas@kernel.org \
--cc=jason@lakedaemon.net \
--cc=jlu@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.