From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] coverity: Model g_poll()
Date: Tue, 01 Dec 2015 14:34:41 +0100 [thread overview]
Message-ID: <87y4decmxa.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <565D9CF2.10300@redhat.com> (Paolo Bonzini's message of "Tue, 1 Dec 2015 14:13:22 +0100")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 01/12/2015 14:03, Markus Armbruster wrote:
>> Coverity now reports two more CHECKED_RETURN:
>>
>> * qemu-char.c:1248: Should be fixed by Paolo's "qemu-char: retry
>> g_poll on EINTR".
>>
>> * migration/qemu-file-unix.c:75: if g_poll() fails, we retry sending
>> before the file descriptor is ready. Errors other than EINTR are
>> mostly theoretical, though.
>
> EINTR is harmless too here, you'll just get another EAGAIN. I'll mark
> it as Intentional / Fix Required in the coverity dashboard.
I posted a cleanup patch anyway. Migration maintainers can decide
whether they want it or not.
prev parent reply other threads:[~2015-12-01 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 13:03 [Qemu-devel] [PATCH] coverity: Model g_poll() Markus Armbruster
2015-12-01 13:13 ` Paolo Bonzini
2015-12-01 13:34 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4decmxa.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.