From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 net 6/6] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0
Date: Fri, 27 Nov 2015 17:29:18 +0100 [thread overview]
Message-ID: <87y4dj76e9.fsf@free-electrons.com> (raw)
In-Reply-To: <1448639066-13074-7-git-send-email-mw@semihalf.com> (Marcin Wojtas's message of "Fri, 27 Nov 2015 16:44:26 +0100")
Hi Marcin,
On ven., nov. 27 2015, Marcin Wojtas <mw@semihalf.com> wrote:
> The Ethernet controller found in the Armada 38x SoC's family support
> TCP/IP checksumming with frame sizes larger than 1600 bytes, however
> only on port 0.
>
> This commit enables it by setting 'tx-csum-limit' to 9800B in
> 'ethernet at 70000' node.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> arch/arm/boot/dts/armada-38x.dtsi | 1 +
This commit should not be merged through the network subsystem but
through mvebu and then arm-soc.
Indeed we tried to centralize all the dts change in only one subsystem
to reduce the merge conflict.
Could you rename it in "mvebu: dts: enable IP checksum with jumbo frames
for Armada 38x on Port0" ?
I will applied on in mvebu/dts as soon as the network part will be
applied.
Thanks,
Gregory
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
> index c6a0e9d..e8b7f67 100644
> --- a/arch/arm/boot/dts/armada-38x.dtsi
> +++ b/arch/arm/boot/dts/armada-38x.dtsi
> @@ -498,6 +498,7 @@
> reg = <0x70000 0x4000>;
> interrupts-extended = <&mpic 8>;
> clocks = <&gateclk 4>;
> + tx-csum-limit = <9800>;
> status = "disabled";
> };
>
> --
> 1.8.3.1
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
davem@davemloft.net, linux@arm.linux.org.uk,
sebastian.hesselbarth@gmail.com, andrew@lunn.ch,
jason@lakedaemon.net, thomas.petazzoni@free-electrons.com,
simon.guinot@sequanux.org, nadavh@marvell.com, alior@marvell.com,
xswang@marvell.com, myair@marvell.com, nitroshift@yahoo.com,
jaz@semihalf.com, tn@semihalf.com
Subject: Re: [PATCH v3 net 6/6] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0
Date: Fri, 27 Nov 2015 17:29:18 +0100 [thread overview]
Message-ID: <87y4dj76e9.fsf@free-electrons.com> (raw)
In-Reply-To: <1448639066-13074-7-git-send-email-mw@semihalf.com> (Marcin Wojtas's message of "Fri, 27 Nov 2015 16:44:26 +0100")
Hi Marcin,
On ven., nov. 27 2015, Marcin Wojtas <mw@semihalf.com> wrote:
> The Ethernet controller found in the Armada 38x SoC's family support
> TCP/IP checksumming with frame sizes larger than 1600 bytes, however
> only on port 0.
>
> This commit enables it by setting 'tx-csum-limit' to 9800B in
> 'ethernet@70000' node.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> arch/arm/boot/dts/armada-38x.dtsi | 1 +
This commit should not be merged through the network subsystem but
through mvebu and then arm-soc.
Indeed we tried to centralize all the dts change in only one subsystem
to reduce the merge conflict.
Could you rename it in "mvebu: dts: enable IP checksum with jumbo frames
for Armada 38x on Port0" ?
I will applied on in mvebu/dts as soon as the network part will be
applied.
Thanks,
Gregory
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
> index c6a0e9d..e8b7f67 100644
> --- a/arch/arm/boot/dts/armada-38x.dtsi
> +++ b/arch/arm/boot/dts/armada-38x.dtsi
> @@ -498,6 +498,7 @@
> reg = <0x70000 0x4000>;
> interrupts-extended = <&mpic 8>;
> clocks = <&gateclk 4>;
> + tx-csum-limit = <9800>;
> status = "disabled";
> };
>
> --
> 1.8.3.1
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2015-11-27 16:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 15:44 [PATCH v2 net 0/6] Marvell Armada XP/370/38X Neta fixes Marcin Wojtas
2015-11-27 15:44 ` Marcin Wojtas
2015-11-27 15:44 ` [PATCH v3 net 1/6] net: mvneta: add configuration for MBUS windows access protection Marcin Wojtas
2015-11-27 15:44 ` Marcin Wojtas
2015-11-27 15:44 ` Marcin Wojtas
2015-11-27 15:44 ` [PATCH v3 net 2/6] net: mvneta: fix bit assignment in MVNETA_RXQ_CONFIG_REG Marcin Wojtas
2015-11-27 15:44 ` Marcin Wojtas
2015-11-27 15:44 ` [PATCH v3 net 3/6] net: mvneta: fix bit assignment for RX packet irq enable Marcin Wojtas
2015-11-27 15:44 ` Marcin Wojtas
2015-11-27 15:44 ` [PATCH v3 net 4/6] net: mvneta: fix error path for building skb Marcin Wojtas
2015-11-27 15:44 ` Marcin Wojtas
2015-11-27 15:44 ` [PATCH v3 net 5/6] net: mvneta: enable setting custom TX IP checksum limit Marcin Wojtas
2015-11-27 15:44 ` Marcin Wojtas
2015-11-27 15:44 ` [PATCH v3 net 6/6] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0 Marcin Wojtas
2015-11-27 15:44 ` Marcin Wojtas
2015-11-27 16:29 ` Gregory CLEMENT [this message]
2015-11-27 16:29 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4dj76e9.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.