* [PATCH net-next] ipv6: log src and dst along with "udp checksum is 0"
@ 2014-02-25 19:34 Bjørn Mork
2014-02-25 19:44 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Bjørn Mork @ 2014-02-25 19:34 UTC (permalink / raw)
To: netdev; +Cc: Bjørn Mork
These info messages are rather pointless without any means to identify
the source of the bogus packets. Logging the src and dst addresses
may help a bit.
Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
net/ipv6/ip6_checksum.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv6/ip6_checksum.c b/net/ipv6/ip6_checksum.c
index 72d198b8e4d2..652716b06c2b 100644
--- a/net/ipv6/ip6_checksum.c
+++ b/net/ipv6/ip6_checksum.c
@@ -79,7 +79,8 @@ int udp6_csum_init(struct sk_buff *skb, struct udphdr *uh, int proto)
/* RFC 2460 section 8.1 says that we SHOULD log
this error. Well, it is reasonable.
*/
- LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0\n");
+ LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0 [%pI6c > %pI6c]\n",
+ &ipv6_hdr(skb)->saddr, &ipv6_hdr(skb)->daddr);
return 1;
}
if (skb->ip_summed == CHECKSUM_COMPLETE &&
--
1.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv6: log src and dst along with "udp checksum is 0"
2014-02-25 19:34 [PATCH net-next] ipv6: log src and dst along with "udp checksum is 0" Bjørn Mork
@ 2014-02-25 19:44 ` Joe Perches
2014-02-25 20:07 ` Bjørn Mork
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2014-02-25 19:44 UTC (permalink / raw)
To: Bjørn Mork; +Cc: netdev
On Tue, 2014-02-25 at 20:34 +0100, Bjørn Mork wrote:
> These info messages are rather pointless without any means to identify
> the source of the bogus packets. Logging the src and dst addresses
> may help a bit.
[]
> diff --git a/net/ipv6/ip6_checksum.c b/net/ipv6/ip6_checksum.c
[]
> @@ -79,7 +79,8 @@ int udp6_csum_init(struct sk_buff *skb, struct udphdr *uh, int proto)
> /* RFC 2460 section 8.1 says that we SHOULD log
> this error. Well, it is reasonable.
> */
> - LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0\n");
> + LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0 [%pI6c > %pI6c]\n",
> + &ipv6_hdr(skb)->saddr, &ipv6_hdr(skb)->daddr);
Might be useful to mirror the ipv4 form and add port #'s too.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv6: log src and dst along with "udp checksum is 0"
2014-02-25 19:44 ` Joe Perches
@ 2014-02-25 20:07 ` Bjørn Mork
0 siblings, 0 replies; 3+ messages in thread
From: Bjørn Mork @ 2014-02-25 20:07 UTC (permalink / raw)
To: Joe Perches; +Cc: netdev
Joe Perches <joe@perches.com> writes:
> On Tue, 2014-02-25 at 20:34 +0100, Bjørn Mork wrote:
>> These info messages are rather pointless without any means to identify
>> the source of the bogus packets. Logging the src and dst addresses
>> may help a bit.
> []
>> diff --git a/net/ipv6/ip6_checksum.c b/net/ipv6/ip6_checksum.c
> []
>> @@ -79,7 +79,8 @@ int udp6_csum_init(struct sk_buff *skb, struct udphdr *uh, int proto)
>> /* RFC 2460 section 8.1 says that we SHOULD log
>> this error. Well, it is reasonable.
>> */
>> - LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0\n");
>> + LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0 [%pI6c > %pI6c]\n",
>> + &ipv6_hdr(skb)->saddr, &ipv6_hdr(skb)->daddr);
>
> Might be useful to mirror the ipv4 form and add port #'s too.
Good point. New version coming up.
Bjørn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-25 20:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-25 19:34 [PATCH net-next] ipv6: log src and dst along with "udp checksum is 0" Bjørn Mork
2014-02-25 19:44 ` Joe Perches
2014-02-25 20:07 ` Bjørn Mork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.