Re: [PATCH 1/2] drm/i915: Move default: to the end of the switch

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 05 Jun 2013, Damien Lespiau <damien.lespiau@intel.com> wrote:
> As it's usual to do, don't leave it in the middle of valid cases.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_irq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 63996aa..a8ef086 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -1484,14 +1484,14 @@ static void i915_get_extra_instdone(struct drm_device *dev,
>  		instdone[0] = I915_READ(INSTDONE_I965);
>  		instdone[1] = I915_READ(INSTDONE1);
>  		break;
> -	default:
> -		WARN_ONCE(1, "Unsupported platform\n");

This is a functional change because of the follow through here. The
commit message should reflect this.

BR,
Jani.

>  	case 7:
>  		instdone[0] = I915_READ(GEN7_INSTDONE_1);
>  		instdone[1] = I915_READ(GEN7_SC_INSTDONE);
>  		instdone[2] = I915_READ(GEN7_SAMPLER_INSTDONE);
>  		instdone[3] = I915_READ(GEN7_ROW_INSTDONE);
>  		break;
> +	default:
> +		WARN_ONCE(1, "Unsupported platform\n");
>  	}
>  }
>  
> -- 
> 1.8.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center