All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 1/2] ath10k: Move debug structures to debug.h
Date: Fri, 3 May 2013 13:59:31 +0300	[thread overview]
Message-ID: <87y5bwba7g.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20866.6443.838239.166937@gargle.gargle.HOWL> (Sujith Manoharan's message of "Thu, 2 May 2013 13:13:39 +0530")

Sujith Manoharan <sujith@msujith.org> writes:

> Kalle Valo wrote:
>> The idea is that everything within ar variable can be found from core.h.
>> That way people don't need to track down where it's actually defined.
>
> That doesn't seem to be the way things are organized. "ar" contains instances of
> HTT, HTC, WMI, BMI, HIF - which all have separate header files. Likewise, having
> a self-contained debug header files makes things cleaner, IMO.

That's what the original codebase had (separate structures for each
module), but we started moving it to the direction of having complete
struct ath10k in core.h. It's a lot easier to manage everything that
way.

-- 
Kalle Valo

  reply	other threads:[~2013-05-03 10:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-30 10:12 [ath9k-devel] [PATCH 1/2] ath10k: Move debug structures to debug.h Sujith Manoharan
2013-04-30 10:12 ` [ath9k-devel] [PATCH 2/2] ath10k: Add host statistics Sujith Manoharan
2013-05-02  7:10   ` Kalle Valo
2013-05-02  7:02 ` [ath9k-devel] [PATCH 1/2] ath10k: Move debug structures to debug.h Kalle Valo
2013-05-02  7:14   ` Sujith Manoharan
2013-05-02  7:36     ` Kalle Valo
2013-05-02  7:43       ` Sujith Manoharan
2013-05-03 10:59         ` Kalle Valo [this message]
2013-05-03 11:03           ` Sujith Manoharan
2013-05-03 11:07             ` Sujith Manoharan
2013-05-03 11:13               ` Sujith Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5bwba7g.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.