All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Paul Bolle <pebolle@tiscali.nl>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 3/8] virtio: do not export "u16" and "u64" to userspace
Date: Tue, 02 Apr 2013 09:59:54 +1030	[thread overview]
Message-ID: <87y5d16d8t.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1364839156.21627.65.camel@x61.thuisdomein>

Paul Bolle <pebolle@tiscali.nl> writes:
> virtio_balloon.h exports "u16" and "u64" to userspace. Use "__u16" and
> "__u64" instead.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Tested with a kernel build.
>
> 1) Both types are used in this header for quite some time now. So is my
> patch flawed or doesn't userspace actually use virtio_balloon.h?

qemu rolls its own copy, but this is still a valid fix.

Thanks,
Rusty.

WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Paul Bolle <pebolle@tiscali.nl>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] virtio: do not export "u16" and "u64" to userspace
Date: Tue, 02 Apr 2013 09:59:54 +1030	[thread overview]
Message-ID: <87y5d16d8t.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1364839156.21627.65.camel@x61.thuisdomein>

Paul Bolle <pebolle@tiscali.nl> writes:
> virtio_balloon.h exports "u16" and "u64" to userspace. Use "__u16" and
> "__u64" instead.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Tested with a kernel build.
>
> 1) Both types are used in this header for quite some time now. So is my
> patch flawed or doesn't userspace actually use virtio_balloon.h?

qemu rolls its own copy, but this is still a valid fix.

Thanks,
Rusty.

  reply	other threads:[~2013-04-01 23:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01 17:59 [PATCH 3/8] virtio: do not export "u16" and "u64" to userspace Paul Bolle
2013-04-01 17:59 ` Paul Bolle
2013-04-01 23:29 ` Rusty Russell [this message]
2013-04-01 23:29   ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5d16d8t.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pebolle@tiscali.nl \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.