From: Kevin Hilman <khilman@ti.com>
To: "DebBarma, Tarun Kanti" <tarun.kanti@ti.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com, b-cousson@ti.com,
grant.likely@secretlab.ca, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 RESEND 6/7] gpio/omap: fix incorrect update to context.irqenable1
Date: Wed, 21 Mar 2012 07:06:30 -0700 [thread overview]
Message-ID: <87y5qurqu1.fsf@ti.com> (raw)
In-Reply-To: <CAC83ZvLgPWO2C6cpRBEsoqFdac1rMyo4OvTXB2_y_mCzaFzJXA@mail.gmail.com> (Tarun Kanti DebBarma's message of "Wed, 21 Mar 2012 10:31:48 +0530")
"DebBarma, Tarun Kanti" <tarun.kanti@ti.com> writes:
> On Wed, Mar 21, 2012 at 8:10 AM, DebBarma, Tarun Kanti
> <tarun.kanti@ti.com> wrote:
>> On Tue, Mar 20, 2012 at 11:31 PM, Kevin Hilman <khilman@ti.com> wrote:
>>> Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:
>>>
>>>> In _enable_gpio_irqbank() when bank->regs->set_irqenable is valid,
>>>> gpio_mask can be directly set by writing to set_irqenable register
>>>> without overwriting current value. In order to ensure the same is
>>>> stored in context.irqenable1, we must read from regs->irqenable
>>>> instead of overwriting it with gpio_mask.
>>>
>>>> The overwriting makes sense only in the second case where irqenable
>>>> is explicitly read and updated with new gpio_mask before writing it
>>>> back. However, for consistency reading regs->irqenable into the
>>>> bank->context.irqenable1 takes care of both the scenarios.
>>>
>>> ...except that the code doesn't do this anymore.
>> Yes.
>>>
>>> I like the newer version (I hope so, since I suggested it :), but please
>>> update the changlog to describe what the code is actually doing.
>> Sure.
> I have updated the change log here:
> git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev
> for_3.4/gpio_more_fixes
Please also post and updated version of the patch for review.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 RESEND 6/7] gpio/omap: fix incorrect update to context.irqenable1
Date: Wed, 21 Mar 2012 07:06:30 -0700 [thread overview]
Message-ID: <87y5qurqu1.fsf@ti.com> (raw)
In-Reply-To: <CAC83ZvLgPWO2C6cpRBEsoqFdac1rMyo4OvTXB2_y_mCzaFzJXA@mail.gmail.com> (Tarun Kanti DebBarma's message of "Wed, 21 Mar 2012 10:31:48 +0530")
"DebBarma, Tarun Kanti" <tarun.kanti@ti.com> writes:
> On Wed, Mar 21, 2012 at 8:10 AM, DebBarma, Tarun Kanti
> <tarun.kanti@ti.com> wrote:
>> On Tue, Mar 20, 2012 at 11:31 PM, Kevin Hilman <khilman@ti.com> wrote:
>>> Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:
>>>
>>>> In _enable_gpio_irqbank() when bank->regs->set_irqenable is valid,
>>>> gpio_mask can be directly set by writing to set_irqenable register
>>>> without overwriting current value. In order to ensure the same is
>>>> stored in context.irqenable1, we must read from regs->irqenable
>>>> instead of overwriting it with gpio_mask.
>>>
>>>> The overwriting makes sense only in the second case where irqenable
>>>> is explicitly read and updated with new gpio_mask before writing it
>>>> back. However, for consistency reading regs->irqenable into the
>>>> bank->context.irqenable1 takes care of both the scenarios.
>>>
>>> ...except that the code doesn't do this anymore.
>> Yes.
>>>
>>> I like the newer version (I hope so, since I suggested it :), but please
>>> update the changlog to describe what the code is actually doing.
>> Sure.
> I have updated the change log here:
> git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev
> for_3.4/gpio_more_fixes
Please also post and updated version of the patch for review.
Kevin
next prev parent reply other threads:[~2012-03-21 14:06 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 10:53 [PATCH v4 RESEND 0/7] gpio/omap: Some more driver fixes Tarun Kanti DebBarma
2012-03-20 10:53 ` Tarun Kanti DebBarma
2012-03-20 10:53 ` [PATCH v4 RESEND 1/7] gpio/omap: fix wakeup_en register update in _set_gpio_wakeup() Tarun Kanti DebBarma
2012-03-20 10:53 ` Tarun Kanti DebBarma
2012-03-20 10:53 ` [PATCH v4 RESEND 2/7] gpio/omap: fix trigger type to unsigned Tarun Kanti DebBarma
2012-03-20 10:53 ` Tarun Kanti DebBarma
2012-03-20 10:53 ` [PATCH v4 RESEND 3/7] gpio/omap: fix _set_gpio_irqenable implementation Tarun Kanti DebBarma
2012-03-20 10:53 ` Tarun Kanti DebBarma
2012-03-20 10:53 ` [PATCH v4 RESEND 4/7] gpio/omap: fix missing dataout context save in _set_gpio_dataout_reg Tarun Kanti DebBarma
2012-03-20 10:53 ` Tarun Kanti DebBarma
2012-03-20 10:53 ` [PATCH v4 RESEND 5/7] gpio/omap: fix incorrect context restore logic in omap_gpio_runtime_* Tarun Kanti DebBarma
2012-03-20 10:53 ` Tarun Kanti DebBarma
2012-03-20 10:53 ` [PATCH v4 RESEND 6/7] gpio/omap: fix incorrect update to context.irqenable1 Tarun Kanti DebBarma
2012-03-20 10:53 ` Tarun Kanti DebBarma
2012-03-20 18:01 ` Kevin Hilman
2012-03-20 18:01 ` Kevin Hilman
2012-03-21 2:40 ` DebBarma, Tarun Kanti
2012-03-21 2:40 ` DebBarma, Tarun Kanti
2012-03-21 5:01 ` DebBarma, Tarun Kanti
2012-03-21 5:01 ` DebBarma, Tarun Kanti
2012-03-21 14:06 ` Kevin Hilman [this message]
2012-03-21 14:06 ` Kevin Hilman
2012-03-22 2:10 ` DebBarma, Tarun Kanti
2012-03-22 2:10 ` DebBarma, Tarun Kanti
2012-03-20 10:53 ` [PATCH v4 RESEND 7/7] gpio/omap: fix redundant decoding of gpio offset Tarun Kanti DebBarma
2012-03-20 10:53 ` Tarun Kanti DebBarma
2012-03-20 14:35 ` [PATCH v4 RESEND 0/7] gpio/omap: Some more driver fixes Grant Likely
2012-03-20 14:35 ` Grant Likely
2012-03-20 17:46 ` Kevin Hilman
2012-03-20 17:46 ` Kevin Hilman
2012-03-21 14:34 ` Grant Likely
2012-03-21 14:34 ` Grant Likely
2012-03-22 17:02 ` Kevin Hilman
2012-03-22 17:02 ` Kevin Hilman
-- strict thread matches above, loose matches on Subject: below --
2012-03-22 5:12 [PATCH v4 RESEND 6/7] gpio/omap: fix incorrect update to context.irqenable1 Tarun Kanti DebBarma
2012-03-22 5:12 ` Tarun Kanti DebBarma
2012-03-22 23:09 ` Kevin Hilman
2012-03-22 23:09 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5qurqu1.fsf@ti.com \
--to=khilman@ti.com \
--cc=b-cousson@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tarun.kanti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.