From: Rusty Russell <rusty@rustcorp.com.au>
To: Amit Shah <amit.shah@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: stable@kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio-pci: fix use after free
Date: Tue, 08 Nov 2011 20:49:27 +1030 [thread overview]
Message-ID: <87y5vqrk5s.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20111108054616.GC2068@amit-x200.redhat.com>
On Tue, 8 Nov 2011 11:16:16 +0530, Amit Shah <amit.shah@redhat.com> wrote:
> On (Mon) 07 Nov 2011 [18:37:05], Michael S. Tsirkin wrote:
> > Commit 31a3ddda166cda86d2b5111e09ba4bda5239fae6 introduced
> > a use after free in virtio-pci. The main issue is
> > that the release method signals removal of the virtio device,
> > while remove signals removal of the pci device.
> >
> > For example, on driver removal or hot-unplug,
> > virtio_pci_release_dev is called before virtio_pci_remove.
> > We then might get a crash as virtio_pci_remove tries to use the
> > device freed by virtio_pci_release_dev.
> >
> > We allocate/free all resources together with the
> > pci device, so we can leave the release method empty.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Acked-by: Amit Shah <amit.shah@redhat.com>
>
> (note: Adding CC: stable@kernel.org to the commit log is the way
> patches get automatically pulled from upstream when committed; CC'ing
> stable on submissions won't help with that.)
Yeah, I fixed it though.
Cheers,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Amit Shah <amit.shah@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] virtio-pci: fix use after free
Date: Tue, 08 Nov 2011 20:49:27 +1030 [thread overview]
Message-ID: <87y5vqrk5s.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20111108054616.GC2068@amit-x200.redhat.com>
On Tue, 8 Nov 2011 11:16:16 +0530, Amit Shah <amit.shah@redhat.com> wrote:
> On (Mon) 07 Nov 2011 [18:37:05], Michael S. Tsirkin wrote:
> > Commit 31a3ddda166cda86d2b5111e09ba4bda5239fae6 introduced
> > a use after free in virtio-pci. The main issue is
> > that the release method signals removal of the virtio device,
> > while remove signals removal of the pci device.
> >
> > For example, on driver removal or hot-unplug,
> > virtio_pci_release_dev is called before virtio_pci_remove.
> > We then might get a crash as virtio_pci_remove tries to use the
> > device freed by virtio_pci_release_dev.
> >
> > We allocate/free all resources together with the
> > pci device, so we can leave the release method empty.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Acked-by: Amit Shah <amit.shah@redhat.com>
>
> (note: Adding CC: stable@kernel.org to the commit log is the way
> patches get automatically pulled from upstream when committed; CC'ing
> stable on submissions won't help with that.)
Yeah, I fixed it though.
Cheers,
Rusty.
next prev parent reply other threads:[~2011-11-08 10:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 16:37 [PATCH] virtio-pci: fix use after free Michael S. Tsirkin
2011-11-07 23:12 ` Rusty Russell
2011-11-07 23:12 ` Rusty Russell
2011-11-08 5:46 ` Amit Shah
2011-11-08 5:46 ` Amit Shah
2011-11-08 10:19 ` Rusty Russell [this message]
2011-11-08 10:19 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5vqrk5s.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=amit.shah@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stable@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.