From: Jim Meyering <jim@meyering.net>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] qcow2: don't ignore failed update_refcount
Date: Mon, 08 Feb 2010 16:32:57 +0100 [thread overview]
Message-ID: <87y6j3rbdi.fsf@meyering.net> (raw)
In-Reply-To: <4B702B60.4000904@redhat.com> (Kevin Wolf's message of "Mon, 08 Feb 2010 16:18:56 +0100")
Kevin Wolf wrote:
...
> I'm currently working on fixing exactly this, and unfortunaly, no, it's
> not that easy. What you introduce looks like proper error handling at
> first sight, but what happens in fact is that while the current write
> request correctly fails now we're running with corrupted metadata for
> all future requests (the new refcount table/block is already in use, but
> it has a refcount of 0 and will be overwritten sooner or later).
>
> Actually, I have found it impossible to fix the current approach, so the
> fix I'm working on will be more of a rewrite of the two functions.
Nicely worded NACK ;-)
Thanks.
prev parent reply other threads:[~2010-02-08 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 15:01 [Qemu-devel] [PATCH] qcow2: don't ignore failed update_refcount Jim Meyering
2010-02-08 15:18 ` [Qemu-devel] " Kevin Wolf
2010-02-08 15:32 ` Jim Meyering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y6j3rbdi.fsf@meyering.net \
--to=jim@meyering.net \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.