[Cluster-devel] [PATCH] avoid build failure: css.h: no such file

[Cluster-devel] [PATCH] avoid build failure: css.h: no such file

[Jim Meyering]

Building fence, as just described, I get this:

  agent.c:15:17: fatal error: ccs.h: No such file or directory
  compilation terminated.
  make[2]: *** [libfence_la-agent.lo] Error 1
  make[2]: Leaving directory `/h/meyering/w/co/fence/fence/libfence'

The fix is to arrange to compile with the corosync CFLAGS from pkg-config:

From 9f44500477465e04654e42363e627c9845dc2596 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Fri, 19 Jun 2009 19:52:44 +0200
Subject: [PATCH] avoid build failure: css.h: no such file

* configure.ac: Use PKG_CHECK_MODULES([corosync],[corosync]).
* fence/libfence/Makefile.am (libfence_la_CFLAGS):
Append $(corosync_CFLAGS).
---
 configure.ac               |    1 +
 fence/libfence/Makefile.am |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index e569176..b0a014b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -77,6 +77,7 @@ check_lib_no_libs() {
 }

 # corosync libs
+PKG_CHECK_MODULES([corosync],[corosync])
 PKG_CHECK_MODULES([cfg],[libcfg])
 PKG_CHECK_MODULES([cpg],[libcpg])
 PKG_CHECK_MODULES([quorum],[libquorum])
diff --git a/fence/libfence/Makefile.am b/fence/libfence/Makefile.am
index dff9098..13b48cb 100644
--- a/fence/libfence/Makefile.am
+++ b/fence/libfence/Makefile.am
@@ -12,7 +12,7 @@ lib_LTLIBRARIES		= libfence.la

 libfence_la_SOURCES	= agent.c

-libfence_la_CFLAGS	= $(css_CFLAGS)
+libfence_la_CFLAGS	= $(css_CFLAGS) $(corosync_CFLAGS)

 libfence_la_LDFLAGS	= $(ccs_LIBS) \
 			  -version-info $(libversion)
--
1.6.3.2.416.g04d0

[Cluster-devel] [PATCH] avoid build failure: css.h: no such file

[Jim Meyering]

Jim Meyering wrote:
> Building fence, as just described, I get this:
>
>   agent.c:15:17: fatal error: ccs.h: No such file or directory
>   compilation terminated.
>   make[2]: *** [libfence_la-agent.lo] Error 1
>   make[2]: Leaving directory `/h/meyering/w/co/fence/fence/libfence'
>
> The fix is to arrange to compile with the corosync CFLAGS from pkg-config:

While my patch worked, it wasn't right ;-)
Fabio found the real cause: a typo: css_... instead of css_...

Here's the patch:

From b124cd70ce01d12eb0a11e89c7f8c740cf4dbf30 Mon Sep 17 00:00:00 2001
From: Fabio M. Di Nitto <fdinitto@redhat.com>
Date: Fri, 19 Jun 2009 19:52:44 +0200
Subject: [PATCH] avoid build failure: css.h: no such file

* fence/libfence/Makefile.am (libfence_la_CFLAGS): Fix typo:
s/css_CFLAGS/ccs_CFLAGS/
---
 fence/libfence/Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fence/libfence/Makefile.am b/fence/libfence/Makefile.am
index dff9098..ef99b57 100644
--- a/fence/libfence/Makefile.am
+++ b/fence/libfence/Makefile.am
@@ -12,7 +12,7 @@ lib_LTLIBRARIES		= libfence.la

 libfence_la_SOURCES	= agent.c

-libfence_la_CFLAGS	= $(css_CFLAGS)
+libfence_la_CFLAGS	= $(ccs_CFLAGS)

 libfence_la_LDFLAGS	= $(ccs_LIBS) \
 			  -version-info $(libversion)
--
1.6.3.2.416.g04d0

[Cluster-devel] [PATCH] avoid build failure: css.h: no such file

[Fabio M. Di Nitto]

good to in of course :)

Fabio

On Fri, 2009-06-19 at 23:42 +0200, Jim Meyering wrote:
> Jim Meyering wrote:
> > Building fence, as just described, I get this:
> >
> >   agent.c:15:17: fatal error: ccs.h: No such file or directory
> >   compilation terminated.
> >   make[2]: *** [libfence_la-agent.lo] Error 1
> >   make[2]: Leaving directory `/h/meyering/w/co/fence/fence/libfence'
> >
> > The fix is to arrange to compile with the corosync CFLAGS from pkg-config:
> 
> While my patch worked, it wasn't right ;-)
> Fabio found the real cause: a typo: css_... instead of css_...
> 
> Here's the patch:
> 
> >From b124cd70ce01d12eb0a11e89c7f8c740cf4dbf30 Mon Sep 17 00:00:00 2001
> From: Fabio M. Di Nitto <fdinitto@redhat.com>
> Date: Fri, 19 Jun 2009 19:52:44 +0200
> Subject: [PATCH] avoid build failure: css.h: no such file
> 
> * fence/libfence/Makefile.am (libfence_la_CFLAGS): Fix typo:
> s/css_CFLAGS/ccs_CFLAGS/
> ---
>  fence/libfence/Makefile.am |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fence/libfence/Makefile.am b/fence/libfence/Makefile.am
> index dff9098..ef99b57 100644
> --- a/fence/libfence/Makefile.am
> +++ b/fence/libfence/Makefile.am
> @@ -12,7 +12,7 @@ lib_LTLIBRARIES		= libfence.la
> 
>  libfence_la_SOURCES	= agent.c
> 
> -libfence_la_CFLAGS	= $(css_CFLAGS)
> +libfence_la_CFLAGS	= $(ccs_CFLAGS)
> 
>  libfence_la_LDFLAGS	= $(ccs_LIBS) \
>  			  -version-info $(libversion)
> --
> 1.6.3.2.416.g04d0

[Cluster-devel] [PATCH] avoid build failure: css.h: no such file

[Jim Meyering]

Fabio M. Di Nitto wrote:

> good to in of course :)

Pushed.
...
>> >From b124cd70ce01d12eb0a11e89c7f8c740cf4dbf30 Mon Sep 17 00:00:00 2001
>> From: Fabio M. Di Nitto <fdinitto@redhat.com>
>> Date: Fri, 19 Jun 2009 19:52:44 +0200
>> Subject: [PATCH] avoid build failure: css.h: no such file
>>
>> * fence/libfence/Makefile.am (libfence_la_CFLAGS): Fix typo:
>> s/css_CFLAGS/ccs_CFLAGS/
...