All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/wireguard-tools: switch to git-based source download
@ 2026-11-13  9:26 Sebastian Michel
  2026-11-14 14:00 ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Michel @ 2026-11-13  9:26 UTC (permalink / raw)
  To: buildroot; +Cc: Sebastian Michel

Upstream wireguard-tools has replaced published release
tarballs in the past, causing Buildroot's hash validation to fail
despite the version being unchanged.
Switch to fetching sources directly from git tags to avoid relying
on potentially changing release archives.

Signed-off-by: Sebastian Michel <sebastian.michel@oss.othermo.de>
---
 package/wireguard-tools/wireguard-tools.hash | 2 +-
 package/wireguard-tools/wireguard-tools.mk   | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/wireguard-tools/wireguard-tools.hash b/package/wireguard-tools/wireguard-tools.hash
index 52e50fb752..ae6a9e4ae8 100644
--- a/package/wireguard-tools/wireguard-tools.hash
+++ b/package/wireguard-tools/wireguard-tools.hash
@@ -1,4 +1,4 @@
 # https://lists.zx2c4.com/pipermail/wireguard/2026-February/009514.html
-sha256  af459827b80bfd31b83b08077f4b5843acb7d18ad9a33a2ef532d3090f291fbf  wireguard-tools-1.0.20260223.tar.xz
 # Locally calculated
+sha256  f8c66849ab99ba1244360d7ed5fcc3280650b2364b5694d79b683c52b1445461  wireguard-tools-v1.0.20260223-git4.tar.gz
 sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
diff --git a/package/wireguard-tools/wireguard-tools.mk b/package/wireguard-tools/wireguard-tools.mk
index 444581b397..8c8fc2dd2f 100644
--- a/package/wireguard-tools/wireguard-tools.mk
+++ b/package/wireguard-tools/wireguard-tools.mk
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-WIREGUARD_TOOLS_VERSION = 1.0.20260223
-WIREGUARD_TOOLS_SITE = https://git.zx2c4.com/wireguard-tools/snapshot
-WIREGUARD_TOOLS_SOURCE = wireguard-tools-$(WIREGUARD_TOOLS_VERSION).tar.xz
+WIREGUARD_TOOLS_VERSION = v1.0.20260223
+WIREGUARD_TOOLS_SITE = https://git.zx2c4.com/wireguard-tools/
+WIREGUARD_TOOLS_SITE_METHOD = git
 WIREGUARD_TOOLS_LICENSE = GPL-2.0
 WIREGUARD_TOOLS_LICENSE_FILES = COPYING
 WIREGUARD_TOOLS_SELINUX_MODULES = wireguard
-- 
2.56.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/wireguard-tools: switch to git-based source download
  2026-11-13  9:26 [Buildroot] [PATCH] package/wireguard-tools: switch to git-based source download Sebastian Michel
@ 2026-11-14 14:00 ` Peter Korsgaard
  2026-11-16  8:15   ` Sebastian Michel
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2026-11-14 14:00 UTC (permalink / raw)
  To: Sebastian Michel; +Cc: buildroot

>>>>> "Sebastian" == Sebastian Michel <sebastian.michel@oss.othermo.de> writes:

 > Upstream wireguard-tools has replaced published release
 > tarballs in the past, causing Buildroot's hash validation to fail
 > despite the version being unchanged.

Ahh, as the author of cgit, Jason would probably like to know about
that. Did you contact him?

I just did a try here:

wget https://git.zx2c4.com/wireguard-tools/snapshot/wireguard-tools-1.0.20260223.tar.xz
--2026-11-14 14:57:27--  https://git.zx2c4.com/wireguard-tools/snapshot/wireguard-tools-1.0.20260223.tar.xz
Resolving git.zx2c4.com (git.zx2c4.com)... 45.77.67.64, 2001:19f0:6c01:174a:925a:8ff:fe78:9eae
Connecting to git.zx2c4.com (git.zx2c4.com)|45.77.67.64|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-xz]
Saving to: ‘wireguard-tools-1.0.20260223.tar.xz’

wireguard-tools-1.0.20260223.ta     [ <=>                                                   ]  98.12K  --.-KB/s    in 0.06s

2026-11-14 14:57:33 (1.66 MB/s) - ‘wireguard-tools-1.0.20260223.tar.xz’ saved [100472]

sha256sum wireguard-tools-1.0.20260223.tar.xz
af459827b80bfd31b83b08077f4b5843acb7d18ad9a33a2ef532d3090f291fbf  wireguard-tools-1.0.20260223.tar.xz

Which matches what we have in the .hash file?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/wireguard-tools: switch to git-based source download
  2026-11-14 14:00 ` Peter Korsgaard
@ 2026-11-16  8:15   ` Sebastian Michel
  2026-11-16  9:38     ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Michel @ 2026-11-16  8:15 UTC (permalink / raw)
  To: Peter Korsgaard; +Cc: buildroot


[-- Attachment #1.1: Type: text/plain, Size: 5092 bytes --]

Am 14.11.26 um 15:00 schrieb Peter Korsgaard:
>>>>>> "Sebastian" == Sebastian Michel<sebastian.michel@oss.othermo.de> writes:
>   > Upstream wireguard-tools has replaced published release
>   > tarballs in the past, causing Buildroot's hash validation to fail
>   > despite the version being unchanged.
>
> Ahh, as the author of cgit, Jason would probably like to know about
> that. Did you contact him?
>
> I just did a try here:
>
> wgethttps://git.zx2c4.com/wireguard-tools/snapshot/wireguard-tools-1.0.20260223.tar.xz
> --2026-11-14 14:57:27--https://git.zx2c4.com/wireguard-tools/snapshot/wireguard-tools-1.0.20260223.tar.xz
> Resolving git.zx2c4.com (git.zx2c4.com)... 45.77.67.64, 2001:19f0:6c01:174a:925a:8ff:fe78:9eae
> Connecting to git.zx2c4.com (git.zx2c4.com)|45.77.67.64|:443... connected.
> HTTP request sent, awaiting response... 200 OK
> Length: unspecified [application/x-xz]
> Saving to: ‘wireguard-tools-1.0.20260223.tar.xz’
>
> wireguard-tools-1.0.20260223.ta     [ <=>                                                   ]  98.12K  --.-KB/s    in 0.06s
>
> 2026-11-14 14:57:33 (1.66 MB/s) - ‘wireguard-tools-1.0.20260223.tar.xz’ saved [100472]
>
> sha256sum wireguard-tools-1.0.20260223.tar.xz
> af459827b80bfd31b83b08077f4b5843acb7d18ad9a33a2ef532d3090f291fbf  wireguard-tools-1.0.20260223.tar.xz
>
> Which matches what we have in the .hash file?
>
>... Which matches what we have in the .hash file?
Ah sorry, I should have given more context here.
I am having the issue for package `wireguard-tools-1.0.20250521`, which 
was the previous release of that package in buildroot.
I suspect that wireguard-tools was re-packaged for some reason and then 
uploaded using the same file name.
To prevent this from happening again in the future, I created this patch.
Take a look at the following log.
The first downloads hash verification fails, source: 
https://git.zx2c4.com/wireguard-tools/snapshot/wireguard-tools-1.0.20250521.tar.xz
The second download succeeds, source: 
https://sources.buildroot.net/wireguard-tools/wireguard-tools-1.0.20250521.tar.xz
```
>>> wireguard-tools 1.0.20250521 Downloading
wget -nd -t 3 --connect-timeout=10 -O 
'/home/seb/code/upstream/buildroot-oss/output/build/.wireguard-tools-1.0.20250521.tar.xz.PqUNRA/output' 
'https://git.zx2c4.com/wireguard-tools/snapshot/wireguard-tools-1.0.20250521.tar.xz' 

--2026-11-16 07:49:09-- 
https://git.zx2c4.com/wireguard-tools/snapshot/wireguard-tools-1.0.20250521.tar.xz
Resolving git.zx2c4.com (git.zx2c4.com)... 
2001:19f0:6c01:174a:925a:8ff:fe78:9eae, 45.77.67.64
Connecting to git.zx2c4.com 
(git.zx2c4.com)|2001:19f0:6c01:174a:925a:8ff:fe78:9eae|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-xz]
Saving to: 
‘/home/seb/code/upstream/buildroot-oss/output/build/.wireguard-tools-1.0.20250521.tar.xz.PqUNRA/output’
/home/seb/code/upstream/buildroot-oss/output/build/.wireguard-tools-1.0.2025 
[ <=> ] 98.00K --.-KB/s in 0.04s
2026-11-16 07:49:11 (2.40 MB/s) - 
‘/home/seb/code/upstream/buildroot-oss/output/build/.wireguard-tools-1.0.20250521.tar.xz.PqUNRA/output’ 
saved [100348]
ERROR: while checking hashes from 
package/wireguard-tools/wireguard-tools.hash
ERROR: wireguard-tools-1.0.20250521.tar.xz has wrong sha256 hash:
ERROR: expected: 
b6f2628b85b1b23cc06517ec9c74f82d52c4cdbd020f3dd2f00c972a1782950e
ERROR: got : 
61f520e7c1664ae9301fa36a2b8e90cf4680887a71f456c290d5d8b879f1e2e6
ERROR: Incomplete download, or man-in-the-middle (MITM) attack
wget -nd -t 3 --connect-timeout=10 -O 
'/home/seb/code/upstream/buildroot-oss/output/build/.wireguard-tools-1.0.20250521.tar.xz.0weWLX/output' 
'https://sources.buildroot.net/wireguard-tools/wireguard-tools-1.0.20250521.tar.xz' 

--2026-11-16 07:49:11-- 
https://sources.buildroot.net/wireguard-tools/wireguard-tools-1.0.20250521.tar.xz
Resolving sources.buildroot.net (sources.buildroot.net)... 
2606:4700:20::681a:125, 2606:4700:20::681a:25, 2606:4700:20::ac43:4838, ...
Connecting to sources.buildroot.net 
(sources.buildroot.net)|2606:4700:20::681a:125|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 100340 (98K) [application/x-xz]
Saving to: 
‘/home/seb/code/upstream/buildroot-oss/output/build/.wireguard-tools-1.0.20250521.tar.xz.0weWLX/output’
/home/seb/code/upstream/buildroot-oss/output/build/.wireguard-tools-1.0.2025 
100%[==============================================================================================================================================================================================>] 
97.99K --.-KB/s in 0.02s
2026-11-16 07:49:11 (5.00 MB/s) - 
‘/home/seb/code/upstream/buildroot-oss/output/build/.wireguard-tools-1.0.20250521.tar.xz.0weWLX/output’ 
saved [100340/100340]
wireguard-tools-1.0.20250521.tar.xz: OK (sha256: 
b6f2628b85b1b23cc06517ec9c74f82d52c4cdbd020f3dd2f00c972a1782950e)
```
>Ahh, as the author of cgit, Jason would probably like to know about 
that. Did you contact him?
Not yet, thanks for the suggestion. I'll contact Jason to report the 
issue with the cgit snapshot download.


[-- Attachment #1.2: Type: text/html, Size: 9270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/wireguard-tools: switch to git-based source download
  2026-11-16  8:15   ` Sebastian Michel
@ 2026-11-16  9:38     ` Peter Korsgaard
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2026-11-16  9:38 UTC (permalink / raw)
  To: Sebastian Michel; +Cc: buildroot

>>>>> "Sebastian" == Sebastian Michel <sebastian.michel@oss.othermo.de> writes:

Hello,

 > Ah sorry, I should have given more context here.
 > I am having the issue for package `wireguard-tools-1.0.20250521`,
 > which was the previous release of that package in buildroot.
 > I suspect that wireguard-tools was re-packaged for some reason and
 > then uploaded using the same file name.
 > To prevent this from happening again in the future, I created this patch.
 > Take a look at the following log.
 > The first downloads hash verification fails, source:
 > https://git.zx2c4.com/wireguard-tools/snapshot/wireguard-tools-1.0.20250521.tar.xz
 > The second download succeeds, source:
 > https://sources.buildroot.net/wireguard-tools/wireguard-tools-1.0.20250521.tar.xz

Ahh, indeed, so the immeditate issue is only for 2025.02.x, where we
could change to git download OR simply to always fetch from
sources.buildroot.net.

Longer term we could indeed change master to fetch from git in case
similar issues occur in the future.


 >> Ahh, as the author of cgit, Jason would probably like to know about 
 >> that. Did you contact him?

 > Not yet, thanks for the suggestion. I'll contact Jason to report the
 > issue with the cgit snapshot download.

I had a look at the wireguard-tools-1.0.20250521.tar.xz differences, and
the .tar files are identical, but the .xz output differs, so it is most
likely caused by a (security) update of xz on the git.zx2c4.com machine.

I don't know how the cgit archive logic works. If there is come caching
then he could perhaps replace the 20250521 file with the copy we have on
sources.buildroot.net?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-16  9:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-13  9:26 [Buildroot] [PATCH] package/wireguard-tools: switch to git-based source download Sebastian Michel
2026-11-14 14:00 ` Peter Korsgaard
2026-11-16  8:15   ` Sebastian Michel
2026-11-16  9:38     ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.