Re: [PATCH 3/6] drm/xe: Drop redundant parameters from xe_info_init_early

[Gustavo Sousa <gustavo.sousa@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> writes:

> We can now obtain the const pointers to struct xe_device_desc and
> xe_subplatform_desc directly from the xe, no need to pass them as
> explicit parameters.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Gustavo Sousa <gustavo.sousa@intel.com>
> ---
>  drivers/gpu/drm/xe/tests/xe_pci.c | 2 +-
>  drivers/gpu/drm/xe/xe_pci.c       | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/tests/xe_pci.c b/drivers/gpu/drm/xe/tests/xe_pci.c
> index 48d5ee478fe6..c817692c0ce3 100644
> --- a/drivers/gpu/drm/xe/tests/xe_pci.c
> +++ b/drivers/gpu/drm/xe/tests/xe_pci.c
> @@ -383,7 +383,7 @@ int xe_pci_fake_device_init(struct xe_device *xe)
>  	if (err)
>  		return err;
>  
> -	xe_info_init_early(xe, desc, subplatform_desc, &probed_info);
> +	xe_info_init_early(xe, &probed_info);
>  	xe_info_init(xe, &probed_info);
>  
>  	return 0;
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 191e69fb0e3d..d19478c9439e 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -771,10 +771,10 @@ static int xe_probe_info_early(struct xe_device *xe,
>   * passed to the driver at probe time from PCI ID table.
>   */
>  static int xe_info_init_early(struct xe_device *xe,
> -			      const struct xe_device_desc *desc,
> -			      const struct xe_subplatform_desc *subplatform_desc,
>  			      struct xe_probed_info *probed_info)
>  {
> +	const struct xe_subplatform_desc *subplatform_desc = xe->subplatform_desc;
> +	const struct xe_device_desc *desc = xe->desc;
>  	int err;
>  
>  	xe->info.devid = probed_info->devid;
> @@ -1222,7 +1222,7 @@ static int __xe_pci_probe(struct pci_dev *pdev, const struct xe_device_desc *des
>  	if (err)
>  		return err;
>  
> -	err = xe_info_init_early(xe, desc, subplatform_desc, &probed_info);
> +	err = xe_info_init_early(xe, &probed_info);
>  	if (err)
>  		return err;
>  
> -- 
> 2.47.1