Re: [PATCH RESEND] [v2] mtd: spinand: add support for additional Dosilicon models

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Qing,

On 19/05/2026 at 20:37:33 -04, Qing Wu <ses1er@gmail.com> wrote:

Could you please change the title for:

      "mtd: spinand: dosilicon: Add support for additional models"

> Add support for additional Dosilicon SPI NAND chips.
>
> Datasheets for chips included in this patch: https://www.dosilicon.com/SPI%20NAND%20Flash.html
>
> Tested on a TP-Link TL-7DR7250 with a Dosilicon DS35Q1GB (0xE5 0xF1)
>
> Link to original v2:
> https://lore.kernel.org/all/20260217221444.11171-1-ses1er@gmail.com/

This link should be below the three '---'.

> Signed-off-by: Qing Wu <ses1er@gmail.com>
> ---
> Changes in v2:
> - Fixed compilation errors.
> - Link to v1: https://lore.kernel.org/all/20260217211427.9120-1-ses1er@gmail.com
> ---
>  drivers/mtd/nand/spi/dosilicon.c | 203 +++++++++++++++++++++++++++++--
>  1 file changed, 196 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mtd/nand/spi/dosilicon.c b/drivers/mtd/nand/spi/dosilicon.c
> index f99899866ceb..6a5100c6bf99 100644
> --- a/drivers/mtd/nand/spi/dosilicon.c
> +++ b/drivers/mtd/nand/spi/dosilicon.c
> @@ -1,6 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
>   * Author: Ahmed Naseef <naseefkm@gmail.com>
> + * Additions: Qing Wu <ses1er@gmail.com>

There is Git for that, please drop that line.

> +static int ds35xxgb_ooblayout_free(struct mtd_info *mtd, int section,
> +				   struct mtd_oob_region *region)
> +{
> +	if (section)
> +		return -ERANGE;
> +
> +	/* Reserve 1 bytes for the BBM. */
> +	region->offset = 1;

Please reserve 2, that is what we have been doing so far.

Otherwise lgtm. I can take it for the next merge window if you resend
rapidly.

Thanks,
Miquèl