All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: niravkumarlaxmidas.rabara@altera.com
Cc: richard@nod.at,  vigneshr@ti.com,  linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: cadence: Add support for NV-DDR interface mode
Date: Fri, 24 Oct 2025 13:16:40 +0200	[thread overview]
Message-ID: <87zf9gpn1j.fsf@bootlin.com> (raw)
In-Reply-To: <20251024102611.310568-1-niravkumarlaxmidas.rabara@altera.com> (niravkumarlaxmidas rabara's message of "Fri, 24 Oct 2025 18:26:11 +0800")

Hi,

> +	if (nand_interface_is_sdr(conf)) {
> +		const struct nand_sdr_timings *sdr = nand_get_sdr_timings(conf);
> +
> +		if (IS_ERR(sdr))
> +			return PTR_ERR(sdr);
> +
> +		ret = cadence_nand_setup_sdr_interface(chip, sdr);
> +	} else {
> +		if (chipnr < 0)
> +			return ret;

I still think this is incorrect. The chipnr value shall not be treated
differently from the SDR path.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: niravkumarlaxmidas.rabara@altera.com
Cc: richard@nod.at,  vigneshr@ti.com,  linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: cadence: Add support for NV-DDR interface mode
Date: Fri, 24 Oct 2025 13:16:40 +0200	[thread overview]
Message-ID: <87zf9gpn1j.fsf@bootlin.com> (raw)
In-Reply-To: <20251024102611.310568-1-niravkumarlaxmidas.rabara@altera.com> (niravkumarlaxmidas rabara's message of "Fri, 24 Oct 2025 18:26:11 +0800")

Hi,

> +	if (nand_interface_is_sdr(conf)) {
> +		const struct nand_sdr_timings *sdr = nand_get_sdr_timings(conf);
> +
> +		if (IS_ERR(sdr))
> +			return PTR_ERR(sdr);
> +
> +		ret = cadence_nand_setup_sdr_interface(chip, sdr);
> +	} else {
> +		if (chipnr < 0)
> +			return ret;

I still think this is incorrect. The chipnr value shall not be treated
differently from the SDR path.

Thanks,
Miquèl

  reply	other threads:[~2025-10-24 11:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-24 10:26 [PATCH v2] mtd: rawnand: cadence: Add support for NV-DDR interface mode niravkumarlaxmidas.rabara
2025-10-24 10:26 ` niravkumarlaxmidas.rabara
2025-10-24 11:16 ` Miquel Raynal [this message]
2025-10-24 11:16   ` Miquel Raynal
2025-10-25  2:20   ` Niravkumar L Rabara
2025-10-25  2:20     ` Niravkumar L Rabara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zf9gpn1j.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=niravkumarlaxmidas.rabara@altera.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.