All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH Dovetail 6.10 - 6.16] x86: irq_pipeline: Fix build failure for !IRQ_PIPELINE but X86_FRED
@ 2025-09-05  9:38 Florian Bezdeka
  2025-09-09 13:47 ` Philippe Gerum
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Bezdeka @ 2025-09-05  9:38 UTC (permalink / raw)
  To: xenomai
  Cc: Florian Bezdeka, Fabian Scheler, Tobias Schaffner, Jan Kiszka,
	Philippe Gerum

The POSTED_MSI_NOTIFICATION_VECTOR is present since 6.10, so
FIRST_SYSTEM_APIC_VECTOR was off by one resulting in the following build
warning:

./arch/x86/include/asm/irq_vectors.h:104:41: error: array index in initializer exceeds array bounds
  104 | #define POSTED_MSI_NOTIFICATION_VECTOR  0xeb
      |                                         ^~~~
arch/x86/entry/entry_fred.c:98:37: note: in definition of macro ‘SYSVEC’
   98 | #define SYSVEC(_vector, _function) [_vector - FIRST_SYSTEM_VECTOR] = fred_sysvec_##_function
      |                                     ^~~~~~~
arch/x86/entry/entry_fred.c:121:16: note: in expansion of macro ‘POSTED_MSI_NOTIFICATION_VECTOR’
  121 |         SYSVEC(POSTED_MSI_NOTIFICATION_VECTOR,  posted_msi_notification),
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./arch/x86/include/asm/irq_vectors.h:104:41: note: (near initialization for ‘sysvec_table’)
  104 | #define POSTED_MSI_NOTIFICATION_VECTOR  0xeb
      |                                         ^~~~
arch/x86/entry/entry_fred.c:98:37: note: in definition of macro ‘SYSVEC’
   98 | #define SYSVEC(_vector, _function) [_vector - FIRST_SYSTEM_VECTOR] = fred_sysvec_##_function
      |                                     ^~~~~~~
arch/x86/entry/entry_fred.c:121:16: note: in expansion of macro ‘POSTED_MSI_NOTIFICATION_VECTOR’
  121 |         SYSVEC(POSTED_MSI_NOTIFICATION_VECTOR,  posted_msi_notification),
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Required build configuration:
  - CONFIG_IRQ_PIPELINE = n
  - CONFIG_X86_FRED = y

Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
---
Cc: Fabian Scheler <fabian.scheler@siemens.com>
Cc: Tobias Schaffner <tobias.schaffner@siemens.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Philippe Gerum <rpm@xenomai.org>
---
 arch/x86/include/asm/irq_vectors.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/irq_vectors.h b/arch/x86/include/asm/irq_vectors.h
index de7592d870e9..dd755c95f3b4 100644
--- a/arch/x86/include/asm/irq_vectors.h
+++ b/arch/x86/include/asm/irq_vectors.h
@@ -109,7 +109,7 @@
 #define FIRST_SYSTEM_APIC_VECTOR	CALL_FUNCTION_OOB_VECTOR
 #define NR_APIC_VECTORS	        	(NR_VECTORS - FIRST_SYSTEM_VECTOR)
 #else
-#define FIRST_SYSTEM_APIC_VECTOR	LOCAL_TIMER_VECTOR
+#define FIRST_SYSTEM_APIC_VECTOR	POSTED_MSI_NOTIFICATION_VECTOR
 #endif
 
 #define NR_VECTORS			 256

---
base-commit: eec111a874f5899e1078ef785ccf29dff986e5a0
change-id: 20250905-wip-flo-fix-build-failure-no-pipline-but-fred-3951c96cb5a5

Best regards,
-- 
Florian Bezdeka <florian.bezdeka@siemens.com>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH Dovetail 6.10 - 6.16] x86: irq_pipeline: Fix build failure for !IRQ_PIPELINE but X86_FRED
  2025-09-05  9:38 [PATCH Dovetail 6.10 - 6.16] x86: irq_pipeline: Fix build failure for !IRQ_PIPELINE but X86_FRED Florian Bezdeka
@ 2025-09-09 13:47 ` Philippe Gerum
  0 siblings, 0 replies; 2+ messages in thread
From: Philippe Gerum @ 2025-09-09 13:47 UTC (permalink / raw)
  To: Florian Bezdeka; +Cc: xenomai, Fabian Scheler, Tobias Schaffner, Jan Kiszka

Florian Bezdeka <florian.bezdeka@siemens.com> writes:

> The POSTED_MSI_NOTIFICATION_VECTOR is present since 6.10, so
> FIRST_SYSTEM_APIC_VECTOR was off by one resulting in the following build
> warning:
>
> ./arch/x86/include/asm/irq_vectors.h:104:41: error: array index in initializer exceeds array bounds
>   104 | #define POSTED_MSI_NOTIFICATION_VECTOR  0xeb
>       |                                         ^~~~
> arch/x86/entry/entry_fred.c:98:37: note: in definition of macro ‘SYSVEC’
>    98 | #define SYSVEC(_vector, _function) [_vector - FIRST_SYSTEM_VECTOR] = fred_sysvec_##_function
>       |                                     ^~~~~~~
> arch/x86/entry/entry_fred.c:121:16: note: in expansion of macro ‘POSTED_MSI_NOTIFICATION_VECTOR’
>   121 |         SYSVEC(POSTED_MSI_NOTIFICATION_VECTOR,  posted_msi_notification),
>       |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ./arch/x86/include/asm/irq_vectors.h:104:41: note: (near initialization for ‘sysvec_table’)
>   104 | #define POSTED_MSI_NOTIFICATION_VECTOR  0xeb
>       |                                         ^~~~
> arch/x86/entry/entry_fred.c:98:37: note: in definition of macro ‘SYSVEC’
>    98 | #define SYSVEC(_vector, _function) [_vector - FIRST_SYSTEM_VECTOR] = fred_sysvec_##_function
>       |                                     ^~~~~~~
> arch/x86/entry/entry_fred.c:121:16: note: in expansion of macro ‘POSTED_MSI_NOTIFICATION_VECTOR’
>   121 |         SYSVEC(POSTED_MSI_NOTIFICATION_VECTOR,  posted_msi_notification),
>       |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Required build configuration:
>   - CONFIG_IRQ_PIPELINE = n
>   - CONFIG_X86_FRED = y
>
> Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
> ---
> Cc: Fabian Scheler <fabian.scheler@siemens.com>
> Cc: Tobias Schaffner <tobias.schaffner@siemens.com>
> Cc: Jan Kiszka <jan.kiszka@siemens.com>
> Cc: Philippe Gerum <rpm@xenomai.org>
> ---
>  arch/x86/include/asm/irq_vectors.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/irq_vectors.h b/arch/x86/include/asm/irq_vectors.h
> index de7592d870e9..dd755c95f3b4 100644
> --- a/arch/x86/include/asm/irq_vectors.h
> +++ b/arch/x86/include/asm/irq_vectors.h
> @@ -109,7 +109,7 @@
>  #define FIRST_SYSTEM_APIC_VECTOR	CALL_FUNCTION_OOB_VECTOR
>  #define NR_APIC_VECTORS	        	(NR_VECTORS - FIRST_SYSTEM_VECTOR)
>  #else
> -#define FIRST_SYSTEM_APIC_VECTOR	LOCAL_TIMER_VECTOR
> +#define FIRST_SYSTEM_APIC_VECTOR	POSTED_MSI_NOTIFICATION_VECTOR
>  #endif
>  
>  #define NR_VECTORS			 256
>
> ---
> base-commit: eec111a874f5899e1078ef785ccf29dff986e5a0
> change-id: 20250905-wip-flo-fix-build-failure-no-pipline-but-fred-3951c96cb5a5
>
> Best regards,

Merged into v6.12, v6.16. Thanks.

-- 
Philippe.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-09-09 13:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-05  9:38 [PATCH Dovetail 6.10 - 6.16] x86: irq_pipeline: Fix build failure for !IRQ_PIPELINE but X86_FRED Florian Bezdeka
2025-09-09 13:47 ` Philippe Gerum

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.